From 6f164648cd961236f244bf164e5aa0295a8fe3ac Mon Sep 17 00:00:00 2001 From: Hans-Peter Lehmann Date: Sun, 31 Aug 2025 12:27:20 +0200 Subject: [PATCH] Fix string being defined more than once (#7971) --- .../ui/episodeslist/FeedItemMenuHandler.java | 12 +++++++----- ui/i18n/src/main/res/values/strings.xml | 2 -- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/de/danoeh/antennapod/ui/episodeslist/FeedItemMenuHandler.java b/app/src/main/java/de/danoeh/antennapod/ui/episodeslist/FeedItemMenuHandler.java index 90c8725a9..410b2d286 100644 --- a/app/src/main/java/de/danoeh/antennapod/ui/episodeslist/FeedItemMenuHandler.java +++ b/app/src/main/java/de/danoeh/antennapod/ui/episodeslist/FeedItemMenuHandler.java @@ -284,25 +284,27 @@ public class FeedItemMenuHandler { } }; - int playStateStringRes; + String message; switch (playState) { default: case FeedItem.UNPLAYED: if (item.getPlayState() == FeedItem.NEW) { //was new - playStateStringRes = R.string.removed_from_inbox_message; + message = fragment.getString(R.string.removed_from_inbox_message); } else { //was played - playStateStringRes = R.string.marked_as_unplayed_message; + message = fragment.getResources().getQuantityString( + R.plurals.marked_as_unplayed_message, 1); } break; case FeedItem.PLAYED: - playStateStringRes = R.string.marked_as_played_message; + message = fragment.getResources().getQuantityString( + R.plurals.marked_as_played_message, 1); break; } if (showSnackbar) { - EventBus.getDefault().post(new MessageEvent(fragment.getString(playStateStringRes), + EventBus.getDefault().post(new MessageEvent(message, context -> { DBWriter.markItemPlayed(item.getPlayState(), item.getId()); // don't forget to cancel the thing that's going to remove the media diff --git a/ui/i18n/src/main/res/values/strings.xml b/ui/i18n/src/main/res/values/strings.xml index b5803ae8f..0b74dab1b 100644 --- a/ui/i18n/src/main/res/values/strings.xml +++ b/ui/i18n/src/main/res/values/strings.xml @@ -247,8 +247,6 @@ Removed from inbox Mark as played Toggle played state - Marked as played - Marked as unplayed Mark as read To jump to positions, you need to play the episode