diff --git a/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/FeedItemlistFragment.java b/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/FeedItemlistFragment.java index 46736c20e..da8925dce 100644 --- a/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/FeedItemlistFragment.java +++ b/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/FeedItemlistFragment.java @@ -284,7 +284,6 @@ public class FeedItemlistFragment extends Fragment implements AdapterView.OnItem if (feed.getState() == Feed.STATE_NOT_SUBSCRIBED) { viewBinding.toolbar.getMenu().findItem(R.id.sort_items).setVisible(false); viewBinding.toolbar.getMenu().findItem(R.id.refresh_item).setVisible(false); - viewBinding.toolbar.getMenu().findItem(R.id.rename_item).setVisible(false); viewBinding.toolbar.getMenu().findItem(R.id.action_search).setVisible(false); } else if (feed.getState() == Feed.STATE_ARCHIVED) { viewBinding.toolbar.getMenu().findItem(R.id.sort_items).setVisible(false); diff --git a/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/preferences/FeedSettingsPreferenceFragment.java b/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/preferences/FeedSettingsPreferenceFragment.java index b06db3f53..20a22d044 100644 --- a/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/preferences/FeedSettingsPreferenceFragment.java +++ b/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/preferences/FeedSettingsPreferenceFragment.java @@ -34,6 +34,7 @@ import de.danoeh.antennapod.storage.database.DBReader; import de.danoeh.antennapod.storage.database.DBWriter; import de.danoeh.antennapod.storage.preferences.UserPreferences; import de.danoeh.antennapod.ui.preferences.screen.synchronization.AuthenticationDialog; +import de.danoeh.antennapod.ui.screen.feed.RenameFeedDialog; import io.reactivex.rxjava3.core.Maybe; import io.reactivex.rxjava3.core.MaybeOnSubscribe; import io.reactivex.rxjava3.android.schedulers.AndroidSchedulers; @@ -54,11 +55,11 @@ public class FeedSettingsPreferenceFragment extends PreferenceFragmentCompat { private static final String PREF_SCREEN = "feedSettingsScreen"; private static final String PREF_AUTHENTICATION = "authentication"; private static final String PREF_AUTO_DELETE = "autoDelete"; - private static final String PREF_CATEGORY_AUTO_DOWNLOAD = "autoDownloadCategory"; private static final String PREF_NEW_EPISODES_ACTION = "feedNewEpisodesAction"; private static final String PREF_FEED_PLAYBACK_SPEED = "feedPlaybackSpeed"; private static final String PREF_AUTO_SKIP = "feedAutoSkip"; private static final String PREF_NOTIFICATION = "episodeNotification"; + private static final String PREF_RENAME = "rename"; private static final String PREF_TAGS = "tags"; private Feed feed; @@ -130,7 +131,8 @@ public class FeedSettingsPreferenceFragment extends PreferenceFragmentCompat { if (feed.isLocalFeed()) { findPreference(PREF_AUTHENTICATION).setVisible(false); - findPreference(PREF_CATEGORY_AUTO_DOWNLOAD).setVisible(false); + findPreference(PREF_AUTODOWNLOAD).setVisible(false); + findPreference(PREF_EPISODE_FILTER).setVisible(false); } findPreference(PREF_SCREEN).setVisible(true); @@ -254,6 +256,10 @@ public class FeedSettingsPreferenceFragment extends PreferenceFragmentCompat { notificationPreference.setChecked(checked); return false; }); + findPreference(PREF_RENAME).setOnPreferenceClickListener(preference -> { + new RenameFeedDialog(getActivity(), feed).show(); + return true; + }); } private void updateAutoDeleteSummary() { @@ -303,7 +309,7 @@ public class FeedSettingsPreferenceFragment extends PreferenceFragmentCompat { return; } boolean enabled = feed.getPreferences().isAutoDownload(UserPreferences.isEnableAutodownloadGlobal()); - findPreference(PREF_EPISODE_FILTER).setEnabled(enabled); + findPreference(PREF_EPISODE_FILTER).setVisible(enabled); ListPreference autoDownloadPreference = findPreference(PREF_AUTODOWNLOAD); String summary = switch (feedPreferences.getAutoDownload()) { case GLOBAL -> getString(R.string.global_default_with_value, diff --git a/app/src/main/java/de/danoeh/antennapod/ui/screen/subscriptions/FeedMenuHandler.java b/app/src/main/java/de/danoeh/antennapod/ui/screen/subscriptions/FeedMenuHandler.java index c4b385064..923f84e16 100644 --- a/app/src/main/java/de/danoeh/antennapod/ui/screen/subscriptions/FeedMenuHandler.java +++ b/app/src/main/java/de/danoeh/antennapod/ui/screen/subscriptions/FeedMenuHandler.java @@ -88,8 +88,6 @@ public abstract class FeedMenuHandler { } else if (menuItemId == R.id.edit_tags) { TagSettingsDialog.newInstance(Collections.singletonList(selectedFeed.getPreferences())) .show(fragment.getChildFragmentManager(), TagSettingsDialog.TAG); - } else if (menuItemId == R.id.rename_item) { - new RenameFeedDialog(fragment.getActivity(), selectedFeed).show(); } else if (menuItemId == R.id.remove_archive_feed || menuItemId == R.id.remove_restore_feed) { new RemoveFeedDialog(Collections.singletonList(selectedFeed)) .show(fragment.getChildFragmentManager(), null); diff --git a/app/src/main/res/menu/feedlist.xml b/app/src/main/res/menu/feedlist.xml index bc3038e46..f2932afd4 100644 --- a/app/src/main/res/menu/feedlist.xml +++ b/app/src/main/res/menu/feedlist.xml @@ -49,12 +49,6 @@ custom:showAsAction="collapseActionView" android:icon="@drawable/ic_check"/> - - - - - - + - + - + - - - - - - - - - - - + + android:title="@string/playback_pref"> + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/ui/common/src/main/res/drawable/ic_rename.xml b/ui/common/src/main/res/drawable/ic_rename.xml new file mode 100644 index 000000000..828b9556f --- /dev/null +++ b/ui/common/src/main/res/drawable/ic_rename.xml @@ -0,0 +1,13 @@ + + + + + + diff --git a/ui/i18n/src/main/res/values/strings.xml b/ui/i18n/src/main/res/values/strings.xml index e48fa3f24..c83f90a1d 100644 --- a/ui/i18n/src/main/res/values/strings.xml +++ b/ui/i18n/src/main/res/values/strings.xml @@ -607,6 +607,8 @@ Created: %1$s. Forum GitHub + Advanced + Display About @@ -808,7 +810,6 @@ All Untagged Only common tags from all selected subscriptions are shown. Other tags stay unaffected. - Automatically download episodes from the inbox Episode filter List of terms used to decide if an episode should be included or excluded when auto downloading Add term