From 98c7125a56eb807346d43e2e7ffd00dae9e3e133 Mon Sep 17 00:00:00 2001 From: Hans-Peter Lehmann Date: Sun, 12 Jul 2026 10:30:22 +0200 Subject: [PATCH] Fix starting to buffer over mobile data without confirmation (#8585) ### Description Fix starting to buffer over mobile data without confirmation. In the new playback service, when "Follow Queue" is off, the streaming-consent flow is not shown and the app silently starts streaming the next episode over mobile data. The episode won't auto-play, but data is consumed without asking the user. ### Checklist - [x] I have read the contribution guidelines: https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request - [x] I have performed a self-review of my code, going through my changes line by line and carefully considering why this line change is necessary - [x] I have run the automated code checks using `./gradlew checkstyle lint` - [x] My code follows the style guidelines of the AntennaPod project: https://antennapod.org/contribute/develop/app/code-style - [x] I have mentioned the corresponding issue and the relevant keyword (e.g., "Closes: #xy") in the description (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) - [x] If it is a core feature, I have added automated tests --- .../antennapod/playback/service/Media3PlaybackService.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/playback/service/src/main/java/de/danoeh/antennapod/playback/service/Media3PlaybackService.java b/playback/service/src/main/java/de/danoeh/antennapod/playback/service/Media3PlaybackService.java index f940b4cf7..da082b1f6 100644 --- a/playback/service/src/main/java/de/danoeh/antennapod/playback/service/Media3PlaybackService.java +++ b/playback/service/src/main/java/de/danoeh/antennapod/playback/service/Media3PlaybackService.java @@ -620,7 +620,9 @@ public class Media3PlaybackService extends MediaLibraryService { player.setMediaItem(confirmItem); player.setPlayWhenReady(false); player.prepare(); + PlaybackService.isRunning = false; EventBus.getDefault().post(new StreamingConfirmationEvent()); + EventBus.getDefault().post(new PlayerStatusEvent()); } private static boolean needsStreaming(FeedMedia media) { @@ -659,7 +661,7 @@ public class Media3PlaybackService extends MediaLibraryService { final FeedMedia nextMedia = pair.first; final MediaItem nextMediaItem = pair.second; if (needsStreaming(nextMedia) && !NetworkUtils.isStreamingAllowed() - && !allowStreamingThisTime && UserPreferences.isFollowQueue()) { + && !allowStreamingThisTime) { showStreamingConfirmation(nextMedia); return; }