mirror/AntennaPod
3
0
Fork 0
mirror of https://github.com/AntennaPod/AntennaPod.git synced 2026-02-04 07:45:34 +00:00
Code Issues Projects Releases Wiki Activity

Check description position in PR check (#8209)

Browse Source
This commit is contained in:
Hans-Peter Lehmann
2026-01-06 10:36:28 +01:00
committed by GitHub
parent 07fa1c7530
commit c50aa53f1a
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
.github/workflows/pr-conventions.yml vendored
View File

@ -16,10 +16,21 @@ jobs:
const issueRegex = /#\d+/i; const issueRegex = /#\d+/i;
if (issueRegex.test(context.payload.pull_request.title)) { if (issueRegex.test(context.payload.pull_request.title)) {
core.setFailed("Please mention the issue number in the PR description, not in the title. Make sure to write 'closes #<number>'."); core.setFailed("Please mention the issue number in the PR description, not in the title. Make sure to write 'closes #<number>'.");
return;
} }
const closingRegex = /\b(close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved):?\s+#\d+/i; const closingRegex = /\b(close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved|contributes to):?\s+#\d+/i;
if (issueRegex.test(context.payload.pull_request.body) && !closingRegex.test(context.payload.pull_request.body)) { if (issueRegex.test(context.payload.pull_request.body) && !closingRegex.test(context.payload.pull_request.body)) {
core.setFailed("The PR description must contain 'closes #<number>' to link to the issue that it closes."); core.setFailed("The PR description must contain 'closes #<number>' to link to the issue that it closes.");
return; return;
} }
const bodyLines = (context.payload.pull_request.body || "").split(/\r?\n/);
const checklistIndex = bodyLines.map(l => l.includes("https://antennapod.org")).lastIndexOf(true);
if (checklistIndex === -1) {
core.setFailed("It looks like you did not follow the PR template. The checklist from the template is missing or incomplete.");
return;
} else if (bodyLines.length - checklistIndex - 1 > 5) {
core.setFailed("It looks like you did not follow the PR template. Please add your description above the checklist, not below.");
return;
}