Commit Graph

78 Commits

Author SHA1 Message Date
1d2bd1c8f9 Fix feature requests getting labeled as bugs (#8606)
### Description

Fix feature requests getting labeled as bugs

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [x] I have run the automated code checks using `./gradlew checkstyle
lint`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-07-15 08:39:52 +02:00
6c69e0db15 Enforce issue template and reject issue assignment automatically (#8572)
### Description

We are receiving a lot of AI generated issues recently.
- Automatically apply the corresponding labels if they are missing
- Strengthen the AI instructions
- Close issues that do not follow the issue template (leaving a comment)
- While at it, also leave a comment when someone wants to be assigned to
an issue

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [x] I have run the automated code checks using `./gradlew checkstyle
lint`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-07-06 17:56:13 +02:00
f212a17a24 Update CI checks to use node 24 actions (#8490)
### Description

Update CI checks to use node 24 actions. Node 20 actions will be
deprecated next week. Also update the action to run in the target repo,
not the source repo. Maybe that helps to avoid a 403 error when trying
to assign the milestone.

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [x] I have run the automated code checks using `./gradlew checkstyle
lint`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-05-28 11:23:51 +02:00
aba09cba6b Automatically assign version milestones (#8489)
### Description

Automatically assign version milestones. People constantly ask what
version a feature will be released in. This adds a CI job to
automatically assign the next version milestone to merged PRs.

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [x] I have run the automated code checks using `./gradlew checkstyle
lint`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-05-28 10:55:57 +02:00
5fe70196eb Basic WearOS app (#8396)
### Description

An initial minimal implementation for a Wear OS app. So far, the wear
app can only display episodes and start them on the phone. No standalone
features available yet.

Contributes to #4264

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [x] I have run the automated code checks using `./gradlew checkstyle
lint spotbugsPlayDebug spotbugsDebug`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-05-14 14:17:54 +02:00
e43eeb5579 Add workflows to ping about play reviews (#7177)
### Description

* Set up workflow which checks each new and edited comment for Google
Play review links and applies the 'Needs: Review reply' label to the
issue if such link is present.
* Update script to create release notes file using GraphQL API, and
include issue numbers of those with Google Play review links.
* Set up workflow to run the changelog creation script manually and save
the output as artifact.
* Set up workflow which runs on [each new
release](https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=released#release)
and posts a comment on issues which are fixed or addressed in that
release (using the changelog script). It tags an the 'review-replyers'
team, so that we can flexibly adjust who should be informed. When tagged
the group should ping all team members.

Once replied, we ideally remove the label to avoid confusion. However,
the workflow will only comment on issues relevant to the new release.

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code
- [ ] I have run the automated code checks using `./gradlew checkstyle
spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug`
- [ ] My code follows the style guidelines of the AntennaPod project:
https://github.com/AntennaPod/AntennaPod/wiki/Code-style
- [ ] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [ ] If it is a core feature, I have added automated tests

---------

Co-authored-by: GitHub Copilot <github-copilot[bot]@users.noreply.github.com>
2026-04-04 22:18:27 +02:00
70b075a090 Lint all modules (#8371)
### Description

Run Lint check on all modules, not just on app, and fix the violations

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [x] I have run the automated code checks using `./gradlew checkstyle
spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-03-28 20:48:25 +01:00
00f99776b8 Require at least 10 non-whitespace chars in PR description (#8342)
### Description

Replace the fragile line-counting heuristic (anchored on
https://antennapod.org URLs, counting trailing lines) with a single
regex that captures text between `### Description` and `### Checklist`
and fails if that region is empty. This is robust to any content
GitHub/Copilot appends after the checklist (promo footers, "Original
prompt" sections, etc.).

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [ ] I have run the automated code checks using `./gradlew checkstyle
spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [ ] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests

<!-- START COPILOT CODING AGENT TIPS -->
---

📍 Connect Copilot coding agent with [Jira](https://gh.io/cca-jira-docs),
[Azure Boards](https://gh.io/cca-azure-boards-docs) or
[Linear](https://gh.io/cca-linear-docs) to delegate work to Copilot in
one click without leaving your project management tool.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ByteHamster <5811634+ByteHamster@users.noreply.github.com>
2026-03-15 08:44:38 +01:00
535a0adaab Add Copilot coding agent setup file (#8336)
### Description

Add Copilot coding agent setup file and tweak PR conventions check for
agents.

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [x] I have run the automated code checks using `./gradlew checkstyle
spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [ ] If it is a core feature, I have added automated tests

<!-- START COPILOT CODING AGENT TIPS -->
---

🔒 GitHub Advanced Security automatically protects Copilot coding agent
pull requests. You can protect all pull requests by enabling Advanced
Security for your repositories. [Learn more about Advanced
Security.](https://gh.io/cca-advanced-security)

---------

Co-authored-by: ByteHamster <5811634+ByteHamster@users.noreply.github.com>
2026-03-14 09:15:08 +01:00
bbfbd2fb72 Improve usability of error printer (#8330)
### Description

Improve usability of error printer. GitHub shows the first line in the
actions output, which in this case was a message talking about XML even
if the error is not actually about xml. Swapping them should make it
easier to see what is going on.

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code, going through my
changes line by line and carefully considering why this line change is
necessary
- [x] I have run the automated code checks using `./gradlew checkstyle
spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-03-10 00:32:51 +01:00
a0252f17e8 Upgrade target API version (#8286)
### Description

Upgrade target API version. For this, we need to upgrade robolectric and
transitively also the Java version and spotbugs version

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code
- [x] I have run the automated code checks using `./gradlew checkstyle
spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-02-18 13:03:21 +01:00
008913b999 Enhance self-review checklist in PR template (#8290)
### Description

Enhance self-review checklist in PR template. Be more explicit about how
to do a self review because it looks like it is too vague for some
people otherwise

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code
- [x] I have run the automated code checks using `./gradlew checkstyle
spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-02-18 08:26:39 +01:00
1562188546 Remove Android 5 support (#8276)
### Description

Remove Android 5 support. For supporting Chromecast playback via media3,
we need to upgrade the media3 library. This library no longer supports
Android 5, so we need to bump our minimum version as well. Only 0.13% of
our Google Play users are still on this ancient Android version released
in 2014. Dropping support seems okay now, especially considering that no
one should expose such an old device to the internet anymore. The app
will continue to work on Android 5 but will not receive updates anymore.

### Checklist
<!-- 
To help us keep the issue tracker clean and work as efficient as
possible,
  please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like
this: [x]
-->
- [x] I have read the contribution guidelines:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code
- [x] I have run the automated code checks using `./gradlew checkstyle
spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug`
- [x] My code follows the style guidelines of the AntennaPod project:
https://antennapod.org/contribute/develop/app/code-style
- [x] I have mentioned the corresponding issue and the relevant keyword
(e.g., "Closes: #xy") in the description (see
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] If it is a core feature, I have added automated tests
2026-02-14 22:06:08 +01:00
c50aa53f1a Check description position in PR check (#8209) 2026-01-06 10:36:28 +01:00
d7f279b7b3 Enforce 'closes' syntax for referencing issues (#8135) 2025-12-05 18:27:07 +01:00
cafb52766b Make emulator tests more stable (#8124) 2025-11-30 21:26:04 +01:00
0e1a5da0de Check that PR titles do not reference issue (#8118) 2025-11-29 11:23:31 +01:00
a6f7d2f783 Run emulator tests on old Android versions (#8097) 2025-11-22 13:55:02 +01:00
f923831dc0 Fix link to AntennaPod code style guidelines (#8057) 2025-10-24 07:01:02 +02:00
20601cc859 Update actions and address a deprecation (#8021) 2025-10-05 11:41:16 +02:00
c98150d80f Update label and description for crash logs field (#7988) 2025-09-14 08:18:27 +02:00
60f4c4cb20 Show error-printing step as failed on CI (#7982) 2025-09-12 21:26:30 +02:00
b0f52e01f7 Fix stale issue action (#7949)
Partially reverts 5e1ec5fc2e.
This prevented closing issues/PRs by removing the stale label again.
2025-08-27 18:17:41 +02:00
5e1ec5fc2e Add workflow to remove labels when an issue gets closed (#7910) 2025-08-02 17:16:39 +02:00
9acbafdba7 Remove app source from issue template (#7530)
Version code now shows which version was used and is more reliable than the memory of users.
2024-11-27 22:38:17 +01:00
8da45100d4 Make issue template easier to use (#7248)
Almost nobody used the problem/solution scheme we requested.
Users want to write their feature first before thinking about reasons.
2024-06-14 17:42:23 +02:00
dbbb21bd3b Switch Emulator CI to Ubuntu (#7140)
GitHub switched their MacOS runners to ARM, which makes the Android emulator fail to start. Since we introduced the CI workflow, GitHub upgraded the Ubuntu runners as well, now supporting hardware acceleration. This means we no longer need MacOS. The Ubuntu runner is also about 2 times faster.
2024-04-27 10:05:58 +02:00
e578f4ca93 CI tweaks (#7069)
- Run Checkstyle with gradle to make it easier for users
  - No longer needs different configuration for new code
  - Exclude current violations
  - Fix some violations that somehow couldn't be specified in the exclusion file
- Print SpotBugs/Lint/Checkstly violations in GitHub format
  - Then the CI run gets annotated on the web UI
2024-04-07 23:28:14 +02:00
6f582e4c52 Fix SpotBugs in CI 2024-03-06 02:32:13 -05:00
c06a3a6d27 Update AGP and Gradle (#6954) 2024-03-04 22:17:44 +01:00
33569e8992 Tweak issue labels and PR template 2024-02-28 22:48:08 +01:00
55c72097b0 Fix warnings about deprecated checks (#6935) 2024-02-24 15:05:15 +01:00
55f83eb9e1 Close unresponsive tickets earlier (#6830) 2023-12-29 00:07:53 +01:00
0bb4870820 Be more aggressive about telling users to also search closed issues (#6762) 2023-11-14 21:12:03 +01:00
b7491e5e71 Do not cache AVD (#6626)
This causes tons of hard-to-reproduce bugs on CI.
2023-09-08 21:09:07 +02:00
1baa8e688b Try to shoo away the F-Droid people who create new issues for every single release 2023-08-25 10:51:08 +02:00
d61745be86 Check Lint recursively from the :app module
instead of checking every module individually. This avoids having to
re-state all disabled Lint checks in all parent modules.
2022-11-06 11:55:23 +01:00
7042b8d616 Use atd emulator image (#6032) 2022-08-21 17:31:57 +02:00
0c8c860040 Print more logs in emulator tests 2022-08-20 21:05:10 +02:00
4d704eb777 Update Checkstyle, use Temurin distribution (#5956) 2022-07-20 22:29:58 +02:00
bda1ed509d Update action dependencies in workflows 2022-04-14 15:36:42 -04:00
70b6f5d017 Timeout CI after 45 minutes
Apparently, the Emulator job sometimes hangs and then uses CPU
resources for the default timeout of 6 hours.
This changes the timeout to 45 minutes.
2022-04-02 11:54:49 +02:00
bd20386537 Mention open and closed issues in issue template 2022-03-22 18:19:15 +01:00
b589ea877c Send message to stale issues/PRs 2022-02-07 21:58:36 +01:00
c09d671826 Close issues & PRs if no reply when requested (#5646) 2022-01-22 23:27:34 +01:00
e9e1fc14c3 Merge pull request #5667 from ByteHamster/test-ci
Actually run all tests on CI
2022-01-22 23:08:22 +01:00
147c996f60 Actually run all tests on GitHub Actions 2022-01-22 17:16:37 +01:00
114a2c192c Make checkstyle CI faster 2022-01-16 11:23:29 +01:00
876042038f Run tests on GitHub Actions instead of CircleCI 2022-01-15 21:05:23 +01:00
e9691cfd8e Merge pull request #5498 from ByteHamster/pending-indent-mutability
Declare intent mutability for Android 12 compatibility
2021-10-30 12:27:42 +02:00