From 541eaf336b7dccca433d917a40fb682b33c14c65 Mon Sep 17 00:00:00 2001
From: Sergey Ponomarev <stokito@gmail.com>
Date: Sat, 15 Nov 2025 13:48:12 +0200
Subject: [PATCH] SPARK-2378: ChatContainer: avoid allocation of ArrayList() on
 iteration

---
 .../main/java/org/jivesoftware/spark/ui/ChatContainer.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/core/src/main/java/org/jivesoftware/spark/ui/ChatContainer.java b/core/src/main/java/org/jivesoftware/spark/ui/ChatContainer.java
index 1d70d3d37..35ac43d09 100644
--- a/core/src/main/java/org/jivesoftware/spark/ui/ChatContainer.java
+++ b/core/src/main/java/org/jivesoftware/spark/ui/ChatContainer.java
@@ -537,7 +537,7 @@ public class ChatContainer extends SparkTabbedPane implements MessageListener, C
             return;
         }
 
-        for (ChatRoom chatRoom : new ArrayList<>(chatRoomList)) {
+        for (ChatRoom chatRoom : chatRoomList) {
             closeTab(chatRoom);
             chatRoom.closeChatRoom();
         }
@@ -1475,7 +1475,7 @@ public class ChatContainer extends SparkTabbedPane implements MessageListener, C
     }
 
     public void closeAllGroupChatRooms() {
-        for (ChatRoom chatRoom : new ArrayList<>(chatRoomList)) {
+        for (ChatRoom chatRoom : chatRoomList) {
             boolean isGroup = chatRoom.getChatType() == Message.Type.groupchat;
             if (isGroup) {
                 closeTab(chatRoom);
@@ -1485,7 +1485,7 @@ public class ChatContainer extends SparkTabbedPane implements MessageListener, C
     }
 
     public boolean hasGroupChatRooms() {
-        for (ChatRoom chatRoom : new ArrayList<>(chatRoomList)) {
+        for (ChatRoom chatRoom : chatRoomList) {
             boolean isGroup = chatRoom.getChatType() == Message.Type.groupchat;
             if (isGroup) {
                 return true;