4342 Commits

Author SHA1 Message Date
ilya khlevnoy
b51fca1a5b Merge branch 'master' into spark-2278 2022-08-31 22:08:35 +03:00
ilyaHlevnoy
a53902cf64
small redesign of the search bar (#714) 2022-08-31 15:04:30 +03:00
ilya khlevnoy
5fa8d4bcce Merge branch 'master' of https://github.com/igniterealtime/Spark 2022-08-31 14:57:13 +03:00
ilyaHlevnoy
033e34f1ab
Spark-2182 fix view logic (#713)
* SPARK-2182 Fix logic

In session i see correct Resource, but i think we should save resource in spark.properties

* SPARK 2182 Fix view logic
2022-08-30 21:35:32 +03:00
ilya khlevnoy
971393c257 Merge branch 'master' of https://github.com/igniterealtime/Spark 2022-08-30 21:08:28 +03:00
ilyaHlevnoy
036db715be
SPARK-2182 save resource in propetries (#712)
* SPARK-2182 Fix logic

In session i see correct Resource, but i think we should save resource in spark.properties

* SPARK-2182 Fix logic

In session i see correct Resource, but i think we should save resource in spark.properties
2022-08-30 19:51:34 +03:00
ilya khlevnoy
5a09d19de8 SPARK-2182 Fix logic
In session i see correct Resource, but i think we should save resource in spark.properties
2022-08-30 19:45:57 +03:00
ilyaHlevnoy
c53dbdd10a
Return select theme and add new flat look and feel (#711)
* SPARK-2214 return select Look and Feel and add new LaF

* Add only custom Laf, drop system Laf
2022-08-29 18:29:59 +03:00
ilyaHlevnoy
e215d9ea49
Remove deprecated JTattoo theme (#710) 2022-08-29 17:34:53 +03:00
ilyaHlevnoy
659ac7bf34
Use a red color icon when hovering the mouse over the icon (#709) 2022-08-29 12:13:09 +03:00
ilyaHlevnoy
1dec993f77
Vcard popup not showing when contact window is maximized (#708)
If width Spark Main Windows > width 0.9*screenSize we should put a window inside
2022-08-28 15:51:36 +03:00
ilyaHlevnoy
fbafbf1c9f
SPARK-2283 Configure room button not working after Smack update (#707)
* Fix "Configure room" button

* Fixed modification of values ​​and showing empty password field
2022-08-28 14:47:49 +03:00
ilyaHlevnoy
3971d7e1e9
SPARK-2281 Fix menu "View client version" and add notification window (#705) 2022-08-28 14:47:39 +03:00
ilyaHlevnoy
0d73b17fd0
SPARK-2282 add "Other Users" button for Login text field (#706)
I also think it is advisable to show it if the number of accounts is more than 1
2022-08-26 16:08:40 +03:00
ilyaHlevnoy
15dac5f8a2
Add clear button for Login text field and eye button to show password (#704) 2022-08-21 15:54:11 +03:00
ilyaHlevnoy
7749ad430a
SPARK-2214 Replace depricated method "install" (#703)
* SPARK-2214 Replace depricated method

Renamed Flat*Laf.install() methods to Flat*Laf.setup() to avoid confusion
with UIManager.installLookAndFeel(LookAndFeelInfo info). The old
Flat*Laf.install() methods are still there, but marked as deprecated. They
will be removed in a future version.
https://github.com/JFormDesigner/FlatLaf/releases/tag/1.2

* rename method

The method should also be called "setup"
2022-08-18 23:50:59 +03:00
ilya khlevnoy
4f39ec78f3 remove lines 2022-08-18 18:12:34 +03:00
ilya khlevnoy
b95a8ddb22 SPARK-2278 Spark should remove plugins in profile if they don't exist in installation folder
If you install Spark over old versions of Spark (2.6.3, 2.7.7, etc.), then old plugins remain in the user profile that are not in the new version. Because of this, errors appear in the logs. We have to do something with these obsolete plugins, for example, remove them.
2022-08-18 17:57:09 +03:00
ilyaHlevnoy
8cf20a0fe0
SPARK-2277 Add control over IBB file transfer via ClientControl (#698)
Since starting from Spark 3.0.0 IBB is disabled by default due to this bug https://igniterealtime.atlassian.net/browse/SPARK-2209  . But after updating the Smack library to version 4.4.X, I cannot reproduce this bug with the IBB setting. Perhaps some administrators may want to manage IBB settings via ClientControl plugin Openfire for their clients.
2022-08-12 20:03:06 +03:00
ilyaHlevnoy
6c4ddb200a
Rever SPARK-2216 (#701)
Since SPARK-2209 is fixed, I think IBB should be enabled by default because it transfers files better.
2022-08-12 18:10:22 +03:00
ilyaHlevnoy
4883b9c25b
add new icon "loading" for new Look and feel (#700) 2022-08-10 19:49:55 +03:00
ilyaHlevnoy
f8eff48247
SPARK-2076 Contact list font size setting should be applied to groups names (#699)
Currently "Contact List Font Size" setting affects only names of the contacts, but groups names stay the same, which can be too small for some users. This setting should be applied to names of the groups as well.
2022-08-10 18:59:59 +03:00
ilya khlevnoy
60251358a7 SPARK-2235 Stop requiring OCSP
1.OCSP should be disabled by default.
2.We have to handle the exception "Certificate does not specify OCSP responder"

I'm confused, maybe I should drop OCSP and remove it. How do you think?
2022-07-21 11:32:30 +02:00
ilya khlevnoy
2ece3cf2fd SPARK-2269 Incorrect handling of carbons
Alex Matthews provided a fix for this problem. I tested it on two different devices and now the message comes to the correct tab and not to everyone

https://discourse.igniterealtime.org/t/muc-private-messages-all-other-tabs-being-taken-over-when-signed-in-to-multiple-sessions/91623?u=ilyahlevnoy
2022-07-21 11:29:19 +02:00
ilya khlevnoy
eea569d0da SPARK-2273 SPARK-2274 Other actions should also work in the thread 2022-07-21 11:27:22 +02:00
ilyaHlevnoy
a610568cdd
Replace deprecated custom ulit class Base64 (#695)
Since Java 8 there is Base64 util class https://docs.oracle.com/javase/8/docs/api/java/util/Base64.html
I think we should use it.
2022-07-19 22:07:54 +03:00
ilyaHlevnoy
56a4b3da0e
SPARK-2208 fix NPE (#693) 2022-07-18 18:24:21 +03:00
ilyaHlevnoy
9876712e9e
Add password encryption and decryption test (#691) 2022-07-17 20:04:36 +03:00
ilyaHlevnoy
b8fcd44ddf
Merge pull request #690 from igniterealtime/spark-1992
SPARK-1992 Fix the View logs menu
2022-07-13 23:15:23 +03:00
ilya khlevnoy
96d0b961a7 SPARK-1992 Fix the View logs menu
Now the error log window is working
2022-07-13 23:06:09 +03:00
ilyaHlevnoy
d83423f958
SPARK-2256 Add control over idle settings (#674) 2022-07-12 22:18:00 +03:00
ilya khlevnoy
b07cafde4c SPARK-2272 SPARK-2270 Remove unused methods in URLFileSystem.class
These methods are not used and use reflection.
This raises a warning for Java 11-15.Due to the strong encapsulation introduced starting from jdk 16 some non-public classes, methods and fields of the java.* package are no longer available via reflection.
2022-07-10 20:02:00 +02:00
ilyaHlevnoy
4b3af9c188
Merge pull request #688 from igniterealtime/smack-4.4.6
SPARK-2271 Update Smack to 4.4.6
2022-07-03 22:58:50 +03:00
ilya khlevnoy
22c2a61d67 Update Smack to 4.4.6 2022-07-03 22:56:08 +03:00
Guus der Kinderen
1f103a80fc SPARK-2267: Update XStream to 1.4.19 2022-05-03 10:37:18 +02:00
Guus der Kinderen
8bceaba5ad SPARK-2265: Fix sorting MUC rooms by occupant
Instead of sorting alphabetically, the sort order of the 'occupant count' column should be numeric.
2022-05-03 10:33:48 +02:00
Guus der Kinderen
2c99a4d165 SPARK-2264: Use nickname in bookmark if set
Bookmarks can have an optional ‘nickname’ element. When joining a chat room from a bookmark, Spark should use the nickname, if it’s present.
2022-05-03 10:32:57 +02:00
Guus der Kinderen
51fda25477 SPARK-2263: Fallback to room JID if bookmark has no name
In the ‘Bookmarks’ drop down menu, all bookmarks are shown by their name.

Bookmarks set by some other clients (like Conversations) do not have a name. This causes the bookmark to show as an empty text.

If this happens, Spark should use another value, like the localpart of the room JID.
2022-05-03 10:32:57 +02:00
Guus der Kinderen
1833d7e299 Add debug logging for startup timing
This adds log lines that will help show how long particular bits of the initial startup take.

No functional changes are introduced by this commit.
2022-05-03 10:32:42 +02:00
Guus der Kinderen
85be64fabd SPARK-2257: Make execution on Event Dispatch Thread more explicit
Swing event handling code runs on a special thread known as the event dispatch thread. Most code that invokes Swing methods also runs on this thread. This is necessary because most Swing object methods are not "thread safe": invoking them from multiple threads risks thread interference or memory consistency errors. Some Swing component methods are labelled "thread safe" in the API specification; these can be safely invoked from any thread. All other Swing component methods must be invoked from the event dispatch thread. Programs that ignore this rule may function correctly most of the time, but are subject to unpredictable errors that are difficult to reproduce.

It's useful to think of the code running on the event dispatch thread as a series of short tasks. Most tasks are invocations of event-handling methods, such as ActionListener.actionPerformed. Other tasks can be scheduled by application code, using invokeLater or invokeAndWait. Tasks on the event dispatch thread must finish quickly; if they don't, unhandled events back up and the user interface becomes unresponsive.

Spark should make clear what code is, and what code is not supposed to be executed on the Event Dispatch thread. This will help reduce instances where the UI seems frozen for prolonged periods of time, or otherwise behaves in an unexpected manner.

This commit adds comments to various methods (particularly around the login sequence) that define if the method is to be executed on the Event Dispatch Thread. Also, when ran in debug mode, code-checks will fail-fast, if such methods are executed differently. This will help spot problems.
2022-05-03 10:31:50 +02:00
Guus der Kinderen
9f990c92b2 Refactor thread-safety on MainWindow.getInstance()
This removes an unneeded lock object, replacing it with a traditional synchronized keyword.

No functional changes should be introduced by this change.
2022-05-03 10:31:34 +02:00
ilyaHlevnoy
9301aefe79
Merge pull request #666 from Flowdalic/boolean-form-field-fixes
Boolean form field fixes
2022-03-03 10:27:36 +03:00
Plyha
9bab11e3d4 Remove this logic once Spark uses Smack 4.4.5 2022-03-03 10:23:15 +03:00
ilyaHlevnoy
d4b03799aa
Merge pull request #684 from Plyha/smack-4.4.5
SPARK-2247 Update Smack to 4.4.5
2022-03-03 10:17:05 +03:00
Plyha
a712dc0a15 SPARK-2247 Update Smack to 4.4.5 2022-03-03 10:16:09 +03:00
ilyaHlevnoy
c26602bf00
Merge pull request #683 from Plyha/xstream
SPARK-2259 XStream ForbiddenClassException in CustomStatusItem Class
2022-03-02 14:26:18 +03:00
Plyha
aad38d6826 SPARK-2259 XStream ForbiddenClassException in CustomStatusItem Class 2022-03-02 14:20:18 +03:00
ilyaHlevnoy
3821d04ec0
Merge pull request #679 from Plyha/tee
Change appearance layout
2022-01-30 16:35:18 +03:00
Plyha
5c0ebd3317 Update ThemePanel.java 2022-01-30 16:31:27 +03:00
ilyaHlevnoy
a731e33a45
Merge pull request #678 from Plyha/spark2182bb
SPARK-2182 Switches to using hostname as resource after a re-login
2022-01-30 14:54:55 +03:00