* SPARK-1646 - Not switching to Away mode when locking screen on Windows 10 and updated JNA and JNA Platform 4.2.2
* SPARK-1646 - Not switching to Away mode when locking screen on Windows 10 and updated JNA and JNA Platform 4.2.2
* SPARK-1646 - Not switching to Away mode when locking screen on Windows 10 and updated JNA and JNA Platform 4.2.2
* SPARK-1741: String.indexOf() -> String.contaiins()
String.indexOf() expressions can be replaced with a call to the String.contains() method available in Java 5 and newer.
* SPARK-1741: Type argument -> diamond type
New expressions with type arguments can be replaced with diamond type <>.
Such <> syntax is not supported under Java 1.6 or earlier JVMs.
* SPARK-1741: Anonymous classes -> lambda
Anonymous classes without statecan be replaced with lambda expressions
Lambda syntax is not supported under Java 1.7 or earlier JVMs.
* SPARK-1741: StringBuffer -> StringBuilder
Variables declared as java.lang.StringBuffer may be more efficiently declared as java.lang.StringBuilder.
java.lang.StringBuilder is a non-thread-safe replacement for java.lang.StringBuffer, available in Java 5 and newer.
* SPARK-1741: Fix String equality checks (BUGFIX)
Using == or != to test for String equality, rather than the equals() method can lead to bugs, as
the former check for reference equality (while most often, value equality is intended).
* SPARK-1741: Simplify pointless boolean expressions
Simplify pointless or pointlessly complicated boolean expressions. Such expressions include anding with true,
oring with false, equality comparison with a boolean literal, or negation of a boolean literal.
* SPARK-1741: Remove redundant initializer
Removes variable initializer where the value is always overwritten with another assignment before the next variable read.
* SPARK-1741: Redundant class fields to local variable.
If all local usages of a field are preceded by assignments to that field, the field can be removed and its usages replaced with local variables.
* SPARK-1741: Remove unnecessary return statements
Return statements at the end of constructors and methods returning void may be safely removed.
* SPARK-1741: StringBuilder -> String
Reports any variables declared as or uses of java.lang.StringBuffer and java.lang.StringBuilder which can be
replaced with a single java.lang.String concatenation. Using a String concatenation makes the code shorter and
simpler. This inspection only reports when the resulting concatenation is at least as efficient or more
efficient than the original StringBuffer or StringBuilder use.
* SPARK-1741: Remove redundant casts.
Remvoing unnecessary cast expressions.
* SPARK-1741: Replace deprecated PacketIDFilter.
* SPARK-1741: Remove unused arguments.
* SPARK-1741: Delete unused imports.
* SPARK-1741: Fix automatic rename error
The Intellij automatic refactoring caused duplicate names to be used.
* SPARK-1741: getPacketID -> getStanzaId
* SPARK-1741: Ensure that Travis uses Java 8.
* SPARK-1741: Do not compile with Java 7 compatibility.
* SMACK4: Prevent NPE in Roar plugin.
* SMACK4: Replaced Smack 3 libs with Smack 4.
* SMACK4: ProviderManager's methods are now static.
* SMACK4: Move MUCUser to org.jivesoftware.smackx.muc.packet.MUCUser
* SMACK4: Move PrivateDataManager to org.jivesoftware.smackx.iqprivate.PrivateDataManager
* SMACK4: Move ServiceDiscoveryManager to org.jivesoftware.smackx.disco.ServiceDiscoveryManager
* SMACK4: Move DiscoverInfo/Items to org.jivesoftware.smackx.disco.packet.DiscoverInfo/Items
* SMACK4: Renamed org.jivesoftware.smackx.bookmark package -> org.jivesoftware.smackx.bookmarks
* SMACK4: Move DelayInformation to org.jivesoftware.smackx.delay.packet.DelayInformation
* SMACK4: Move PrivateData(Provider) to org.jivesoftware.smackx.iqprivate.packet
* SMACK4: Move Roster* to org.jivesoftware.smack.Roster
* SMACK4: Move VCard to org.jivesoftware.smackx.vcardtemp.packet.VCard
* SMACK4: Move Form to org.jivesoftware.smackx.xdata.Form
* SMACK4: Move ChatState to org.jivesoftware.smackx.chatstates.ChatState
* SMACK4: Move Chat to org.jivesoftware.smack.chat.Chat
* SMACK4: Move RosterPacket to import org.jivesoftware.smack.roster.packet.RosterPacket;
* SMACK4: Move ReportedData to import org.jivesoftware.smackx.search.ReportedData
* SMACK4: Move Privacy* to org.jivesoftware.smackx.privacy
* SMACK4: Move Time to org.jivesoftware.smackx.time.packet.Time
* SMACK4: Move Version to org.jivesoftware.smackx.iqversion.packet.Version
* SMACK4: Renamed org.jivesoftware.smack.Connection to org.jivesoftware.smack.XMPPConnection
* SMACK-4: Packet -> Stanza
A rather large commit that refactors all 'Packet' implementations to the new
'Stanza' alternatives. As a side-effect, most filters and extension-related
classes are affected.
* SMACK4: Fixed the IQ.Type enum (all to lowercase)
* SMACK4: Fixed obtaining a Roster instance.
* SMACK4: Fixed service discovery element iteration (from iterator to collection).
* SMACK4: Replaced StingUtils with XMPPStringUtils
* SMACK4: Move LastActivity to org.jivesoftware.smackx.iqlast
* SMACK4: Move SharedGroups to org.jivesoftware.smackx.sharedgroups
* SMACK4: Fixed obtaining a Roster instance.
* SMACK4: Fixed dataform iteration (from iterator to collection).
* SMACK4: Changed the FormField type constants to enum values.
* SMACK4: Fixed dataform iteration (from iterator to collection).
* SMACK4: Replaced Smack 3 libs with Smack 4.
* SMACK4: Renamed org.jivesoftware.smackx.jingle to org.jivesoftware.smackx.jingleold
* SMACK4: Migrated the jive property extensions to stanzas.
* SMACK4: Fixed obtaining a ChatManager instance (Smack's, not Spark's).
* SMACK4: Move MessageEvent to org.jivesoftware.smackx.xevent
* SMACK4: Fixed obtaining a MultiUserChatManager instance.
* SMACK4: Added SmackException to catches for XMPPException.
* SMACK4: MUC Service refactoring.
* SMACK4: MessageEvent#setPacketID -> setStanzaId
* SMACK4: Refactored PacketExtensionProvider to ExtensionElementProvider
* SMACK4: Fixed changed interface of Version.
* SMACK4: Fixed for Privacy List
* SMACK4: Fixed for Scratchpad
* SMACK4: Fixed for Systray
* SMACK4: ConnectionListener fixes (and some various others)
* SMACK4: Fixed Translator plugin.
* SMACK4: Fixed TicTacToe plugin.
* SMACK4: Fixed Reversi plugin.
* SMACK4: Fixed OTR plugin.
* SMACK4: Fixed Jingle plugin.
* SMACK4: Fixed FasthPath plugin.
* SMACK4: Fixed Battleship plugin (although it had an error to begin with, and still has).
* SMACK4: Fixed SIP plugin.
* SMACK4: Fixes for MUC (mostly error handling).
* SMACK4: Various fixes.
* SMACK4: Fixes for iqVersion.
* SMACK4: Fixes for MUC.
* SMACK4: Fixes for Bookmark plugin.
* SMACK4: Fixes for PresenceChange plugin.
* SMACK4: Fixes for FileTransfer
* SMACK4: Fixes for Gateway plugin.
* SMACK4: Fixes for Privacy List.
* SMACK4: Fixes for VCardManager.
* SMACK4: Fixes for UserSearch.
* SMACK4: Fixes for connection logic.
* SMACK4: Fixes for MUC.
* SMACK4: Fixes for connection logic.
* SMACK4: Fixes PhonePlugin
This commit introduces a new asterisk-im-client library (which is Smack 4 based).
It also renames of other libraries to conform to standards.
* SMACK4: Do not confuse compiler with SingletonMap-hack.
* SMACK4: Fix the last few compiler errors.
* SMACK4: Settled Smack dependencies.
This commit re-organizes the libraries that ship with Spark, primarily
to fulfill Smack's dependencies.
On a side-note: Using this code, I was able to compile and start
Spark, joining a MUC and exchanging messages. There's plenty of things
going wrong, but hey, getting close. :)
* SMACK4: Fixing self-presence evaluation in MUC (prevents NPEs).
* SMACK4: Fixing VCards.
* SMACK4: Fixing FastPath plugin.
* SMACK4: Fixing SIP plugin.
* SMACK4: Fixing TransferGuard plugin.
* SMACK4: Fixing Buzz plugin.