Commit Graph

367 Commits

Author SHA1 Message Date
24dce9789b Denote Spark 2.9.3 Release 2020-10-24 06:40:29 -05:00
f8a4c0e3f9 SPARK-2064: Fix reconnection to group chat rooms 2020-10-24 02:02:14 +03:00
f7f29871e4 Move reconnection handling code and remove redundant method 2020-10-23 22:44:41 +03:00
1146b4da90 SPARK-2179: Fix escaping in the incoming buzz notification message. 2020-10-23 00:06:42 +03:00
45ad39d07c Reformat the BuzzPlugin.java code. 2020-10-22 23:14:45 +03:00
6b71674414 Bump junit from 4.8.2 to 4.13.1 in /core
Bumps [junit](https://github.com/junit-team/junit4) from 4.8.2 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md)
- [Commits](https://github.com/junit-team/junit4/compare/r4.8.2...r4.13.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-10-12 19:39:46 +00:00
48fabeee61 SPARK-2177: Add offline status text to the status panel. 2020-10-12 00:35:54 +03:00
13275a9bb4 SPARK-2177: Disable manual status change during reconnection. 2020-10-12 00:34:51 +03:00
c40aeb19ef SPARK-2177: Prevent automatic status change to away or offline during reconnection. 2020-10-12 00:32:27 +03:00
9ac4cfd92a Do not handle offline messages in ChatRoomImpl class.
Offline messages are handling by Workspace class only. So it's prevent offline messages duplicate.
2020-10-11 20:35:44 +03:00
88845242ba Don't handle offline messages if the corresponding chat room has already been created.
This eliminates duplicate messages in the transcript window when the user reconnects while the chat room is open.
2020-10-10 23:42:11 +03:00
015970e3d7 Fix chat room existence check and chat room creation.
Existence check should take into account the actual type of the parameter passed to the method.
There it is important to distinguish JID (EntityJid type) and bare JID (EntityBareJid type) since both are used:
bare JIDs - within one-on-one chats;
full JIDs - within private chats of group chat members.
2020-10-10 21:41:51 +03:00
a9f5edf03d SPARK-2174: Import the forgotten class. 2020-10-10 01:52:31 +03:00
4071638db2 SPARK-2174: Change tab icons of chat rooms to "unavailable" when disconnected. 2020-10-10 01:28:23 +03:00
3e70662ba7 SPARK-2143: Add reconnection event handling to one-on-one chat room.
This fixes the issue with roster always on top and disabled controls in chat room dialog after reconnection.
2020-10-10 01:28:22 +03:00
9288c9098c Fix behavior of contact list during reconnection. 2020-10-08 21:58:50 +03:00
0a101c05ee Add an overloaded getChatRoom () method that requires a parameter of type EntityBareJid.
This fixes the issue with duplicate dialog tabs.
2020-10-08 18:44:38 +03:00
31abf18ca4 Refactor: rename getRoomJid() to getBareJid() in ChatRoom class and its derived classes for more clarity. 2020-10-07 18:14:09 +03:00
0c11a9dd93 Prevent duplication of contacts after reconnect.
Add a method to recursively update the presence of contact list items (in groups, subgroups and so on).
Replace building of "Initial contact list" with it's updating after recconnect .
2020-10-05 22:53:19 +03:00
d499b2b205 Reformat code of ContactList.java 2020-10-05 21:45:51 +03:00
99a7a1994b Reformat code of ContactGroup.java 2020-10-05 01:48:08 +03:00
d01de10e41 Disable automatic activation of the new private chat room created when the first message arrived. 2020-10-04 00:52:47 +03:00
faaeb35864 Fix private messaging in group chat.
To address private rooms in a group chat, you need to use EntityJid instead of EntityBareJid.
[See section 7.5 of XEP-0045: Multi-User Chat](https://xmpp.org/extensions/xep-0045.html#privatemessage)
2020-10-02 02:21:11 +03:00
040beea9a8 Fix history issues for contacts with spaces in usernames 2020-09-29 00:23:09 +03:00
3d890fc3f5 Fix converting emote expressions to icons 2020-09-28 19:07:47 +03:00
d6d4d0d761 Optimize messages rendering in chat area.
Make it possible to correctly handle network addresses containing spaces when enclosed in quotes.
2020-09-28 00:46:30 +03:00
7444cd9d43 Clean up grammar and typos, refactor some unobvious property names and remove trailing whitespace. 2020-09-24 00:53:43 +03:00
d9f297a1cf Replace string literals with constants from Default class. 2020-09-24 00:24:45 +03:00
273fb77989 Add missed string constants (static final fields) for default properties to Default class.
- ADD_CONTACT_GROUP_DISABLED
- CHANGE_COLORS_DISABLED
- DISABLE_AVATAR_TAB
- DISABLE_BROADCAST_MENU_ITEM
- DISABLE_EDIT_PROFILE
- DISABLE_EXIT
- DISABLE_FILE_XFER
- DISABLE_MOVE_AND_COPY
- DISABLE_PLUGINS_MENU_ITEM
- DISABLE_PREFERENCES_MENU_ITEM
- DISABLE_PRESENCE_STATUS_CHANGE
- DISABLE_REMOVALS
- DISABLE_RENAMES
- DISABLE_VIEW_NOTES
- DISABLE_VIEW_TASK_LIST
- HELP_FORUM
- HELP_FORUM_DISABLED
- HELP_FORUM_TEXT
- HELP_USER_GUIDE_DISABLED
- PLUGIN_BLACKLIST
- PLUGIN_BLACKLIST_CLASS
- PLUGIN_REPOSITORY
- PLUGIN_REPOSITORY_USE_PROXY
- PROXY_PROTOCOL
2020-09-24 00:00:05 +03:00
6705a7b4c3 Fix misspelling and typos, reformat code. 2020-09-21 01:57:01 +03:00
16ea21113f Add file transfer events saving to chat history. 2020-09-21 01:34:28 +03:00
06ac959bc6 Replace some string literals with constants. 2020-09-18 22:21:59 +03:00
e1ff5555a0 Fix behavior of the login dialog related to handling the default property "HOST_NAME_CHANGE_DISABLED". 2020-09-18 21:42:36 +03:00
09a977d866 Reformat code and remove some whitespace. 2020-09-18 20:47:20 +03:00
5fc7707841 Fix typos and refactor duplicated property in i18n resources. 2020-09-11 02:52:26 +03:00
9e6526626e Fix typo 2020-09-09 20:58:12 +03:00
928a0ad85e march master branch toward 2.9.3-SNAPSHOT 2020-08-30 13:22:12 -05:00
53d9ed6df3 Denote Spark 2.9.2 Release 2020-08-30 19:46:45 +02:00
51519d2fcb Merge pull request #520 from guusdk/SPARK-2154_offline-messages
SPARK-2154: Do not parse nicknames using Jid implementation
2020-08-27 11:04:04 +03:00
0fd644abbd SPARK-2154: Do not parse nicknames using Jid implementation
Nicknames aren't necessarily components of a Jid (they are in context of MUC, but they're pretty much free form text on the roster). By attempting to use the Jid implementation to parse nicknames, exceptions occur. In this instance, such an exception prevents an offline message being displayed if it is sent by someone that is on the recipients roster using in nickname that contains a space.
2020-08-27 09:46:16 +02:00
8704b2a8c7 Merge pull request #519 from guusdk/SPARK-2159_fix-groupchat-participantlist-comparison
SPARK-2157: Prevent comparing JID with String for groupchat comparison
2020-08-26 21:38:02 +03:00
1a4c897862 Merge pull request #518 from guusdk/SPARK-2158_fix-compare-plugin-dep-version
SPARK-2158: fix comparison of plugin dependency version numbers.
2020-08-26 21:37:45 +03:00
4b4453e7a4 Merge pull request #516 from guusdk/SPARK-2156_invalid-jid-comparison
SPARK-2156: Prevent comparing JID with String for serverAddress
2020-08-26 21:37:06 +03:00
e1f57b732a Merge pull request #515 from guusdk/SPARK-2155_log-problems
SPARK-2155: Explicitly log problems with processing stanzas
2020-08-26 21:35:41 +03:00
ec51487c8f Reformat unformatted code 2020-08-26 20:18:26 +02:00
e621c2f612 SPARK-2157: Prevent comparing JID with String for groupchat comparison
fixes a error condition comparison too.
2020-08-26 20:17:27 +02:00
3c1957175c SPARK-2158: fix comparison of plugin dependency version numbers. 2020-08-26 20:07:28 +02:00
32ebc0d4ab SPARK-2156: Prevent comparing JID with String for serverAddress 2020-08-26 19:53:50 +02:00
85f5cfa51b SPARK-2155: Explicitly log problems with processing stanzas
This ensures that exceptions are logged.
2020-08-26 19:35:30 +02:00
2c48ffe1a8 march master branch toward 2.9.2-SNAPSHOT 2020-08-25 13:35:13 -05:00