Jan Kara a86a8247a7
quota: Fix race of dquot_scan_active() with quota deactivation ...
[ Upstream commit e93ab401da4b2e2c1b8ef2424de2f238d51c8b2d ]
dquot_scan_active() can race with quota deactivation in
quota_release_workfn() like:
CPU0 (quota_release_workfn) CPU1 (dquot_scan_active)
============================== ==============================
spin_lock(&dq_list_lock);
list_replace_init(
&releasing_dquots, &rls_head);
/* dquot X on rls_head,
dq_count == 0,
DQ_ACTIVE_B still set */
spin_unlock(&dq_list_lock);
synchronize_srcu(&dquot_srcu);
spin_lock(&dq_list_lock);
list_for_each_entry(dquot,
&inuse_list, dq_inuse) {
/* finds dquot X */
dquot_active(X) -> true
atomic_inc(&X->dq_count);
}
spin_unlock(&dq_list_lock);
spin_lock(&dq_list_lock);
dquot = list_first_entry(&rls_head);
WARN_ON_ONCE(atomic_read(&dquot->dq_count));
The problem is not only a cosmetic one as under memory pressure the
caller of dquot_scan_active() can end up working on freed dquot.
Fix the problem by making sure the dquot is removed from releasing list
when we acquire a reference to it.
Fixes: 869b6ea1609f ("quota: Fix slow quotaoff")
Reported-by: Sam Sun <samsun1006219@gmail.com >
Link: https://lore.kernel.org/all/CAEkJfYPTt3uP1vAYnQ5V2ZWn5O9PLhhGi5HbOcAzyP9vbXyjeg@mail.gmail.com
Signed-off-by: Jan Kara <jack@suse.cz >
Signed-off-by: Sasha Levin <sashal@kernel.org >
Signed-off-by: Ulrich Hecht <uli@kernel.org >
2026-06-29 10:46:03 +02:00
2023-01-18 11:29:59 +01:00
2025-11-17 10:36:39 +01:00
2026-04-09 14:44:43 +08:00
2025-07-17 10:07:57 +02:00
2022-03-16 13:20:26 +01:00
2026-04-09 14:44:46 +08:00
2022-06-14 16:59:39 +02:00
2026-05-07 10:55:23 +02:00
2022-09-05 10:26:29 +02:00
2026-01-26 16:51:56 +08:00
2023-05-30 12:42:14 +01:00
2025-05-08 11:55:42 +02:00
2024-02-23 08:12:39 +01:00
2024-07-18 11:39:39 +02:00
2026-01-29 12:09:36 +08:00
2026-06-29 10:45:21 +02:00
2022-03-23 09:10:43 +01:00
2025-12-22 04:34:10 +01:00
2025-09-22 10:17:52 +02:00
2021-08-08 08:54:29 +02:00
2025-06-11 10:19:25 +02:00
2024-09-04 13:12:59 +02:00
2023-06-09 10:23:56 +02:00
2022-11-10 17:46:56 +01:00
2022-04-15 14:14:41 +02:00
2024-12-05 10:59:42 +01:00
2021-09-22 11:47:59 +02:00
2024-02-23 08:12:46 +01:00
2022-09-15 12:17:02 +02:00
2021-09-26 13:39:48 +02:00
2022-07-21 21:09:26 +02:00
2022-12-14 11:28:27 +01:00
2024-11-08 16:19:18 +01:00
2024-07-18 11:39:31 +02:00
2026-01-26 16:51:55 +08:00
2026-01-26 16:51:55 +08:00
2021-10-06 15:31:17 +02:00
2021-11-26 11:36:02 +01:00
2026-04-12 13:56:45 +08:00
2023-08-08 19:49:17 +02:00
2023-12-13 17:42:15 +01:00
2024-09-04 13:12:59 +02:00
2023-04-05 11:15:42 +02:00
2023-12-20 15:38:01 +01:00
2023-05-17 11:13:06 +02:00
2024-02-23 08:12:40 +01:00
2025-09-16 13:55:07 +02:00
2024-02-23 08:12:53 +01:00
2026-06-29 10:46:01 +02:00
2022-10-26 13:19:31 +02:00
2025-02-07 03:34:24 +01:00
2022-11-10 17:46:55 +01:00
2021-10-27 09:53:13 +02:00
2024-05-17 11:42:37 +02:00
2023-09-23 10:47:59 +02:00
2024-09-04 13:13:08 +02:00
2021-12-08 08:50:13 +01:00
2025-12-22 04:34:05 +01:00
2024-04-13 12:50:14 +02:00
2021-09-22 11:47:56 +02:00
2021-09-22 11:47:56 +02:00
2024-07-18 11:39:35 +02:00
2023-04-20 12:04:39 +02:00
2026-01-29 12:09:34 +08:00
2024-04-13 12:50:12 +02:00
2025-07-17 10:08:05 +02:00
2024-03-26 18:22:37 -04:00
2024-02-23 08:12:55 +01:00
2021-07-11 12:49:27 +02:00
2023-02-22 12:47:20 +01:00
2022-06-25 11:49:07 +02:00
2024-08-19 05:31:56 +02:00
2025-02-07 03:34:27 +01:00
2023-09-23 10:48:11 +02:00
2023-10-10 21:44:57 +02:00
2025-09-16 13:55:16 +02:00
2023-03-11 16:31:51 +01:00
2023-10-25 11:16:17 +02:00
2021-08-26 08:36:39 -04:00
2025-05-08 11:55:41 +02:00
2022-10-26 13:19:35 +02:00
2021-12-08 08:50:11 +01:00
2023-06-28 10:15:27 +02:00
2021-08-26 08:36:40 -04:00
2024-11-08 16:19:06 +01:00
2024-12-05 10:59:31 +01:00
2025-04-03 10:09:44 +02:00
2023-03-11 16:31:35 +01:00
2023-02-06 07:49:46 +01:00
2022-07-02 16:27:39 +02:00
2022-08-25 11:15:23 +02:00
2023-03-11 16:31:51 +01:00
2026-06-29 10:45:21 +02:00
2025-02-07 03:34:23 +01:00
2023-10-10 21:45:00 +02:00
2021-09-22 11:47:57 +02:00
2024-02-23 08:12:58 +01:00
2022-06-14 16:59:25 +02:00
2023-01-18 11:30:49 +01:00
2023-10-25 11:16:31 +02:00
2021-10-09 14:11:03 +02:00
2021-09-22 11:48:12 +02:00
2025-12-22 04:34:09 +01:00
2022-12-08 11:18:34 +01:00
2022-04-15 14:15:07 +02:00
2022-11-23 07:53:44 +01:00
2024-06-16 13:23:35 +02:00
2021-08-26 08:36:41 -04:00
2023-09-23 10:47:59 +02:00
2021-06-30 08:48:18 -04:00
2022-05-18 09:42:47 +02:00
2026-01-29 12:09:38 +08:00
2023-06-21 15:39:57 +02:00
2023-06-21 15:39:57 +02:00
2025-05-05 15:34:17 +02:00
2026-01-29 12:09:30 +08:00
2025-06-11 10:19:26 +02:00
2023-09-23 10:47:58 +02:00
2023-08-11 11:45:06 +02:00
2022-06-14 16:59:38 +02:00
2023-02-25 11:51:51 +01:00
2024-07-05 09:00:32 +02:00
2021-12-08 08:50:11 +01:00
2022-11-01 19:05:40 +01:00
2025-04-03 10:09:42 +02:00
2021-08-08 08:54:30 +02:00
2021-07-11 12:49:30 +02:00
2025-04-04 11:11:27 +02:00
2023-09-23 10:48:11 +02:00
2025-09-16 13:55:19 +02:00
2023-12-13 17:42:19 +01:00
2023-02-22 12:47:17 +01:00
2023-11-08 11:22:18 +01:00
2023-08-11 11:45:40 +02:00
2025-03-11 08:34:59 +01:00
2023-06-09 10:23:54 +02:00
2025-09-16 13:55:10 +02:00
2022-06-25 11:49:11 +02:00
2023-11-20 10:29:18 +01:00
2023-05-17 11:13:28 +02:00
2023-01-18 11:30:11 +01:00
2021-06-30 08:48:19 -04:00
2022-06-14 16:59:13 +02:00
2023-11-28 16:46:33 +00:00
2024-03-26 18:22:40 -04:00
2023-10-25 11:16:20 +02:00
2026-06-29 10:46:03 +02:00
2023-08-30 16:31:56 +02:00
2023-02-25 11:51:50 +01:00
2022-07-02 16:27:31 +02:00
2026-01-26 16:51:55 +08:00
2023-06-28 10:15:28 +02:00
2024-09-12 11:02:55 +02:00
2022-09-05 10:26:34 +02:00
2023-11-08 11:22:19 +01:00
2021-12-14 10:18:04 +01:00
2022-07-12 16:29:03 +02:00
2026-05-28 15:32:29 +08:00
2024-02-23 08:12:58 +01:00
2023-08-11 11:45:22 +02:00
2024-05-02 16:17:14 +02:00
2023-03-22 13:27:11 +01:00
2022-06-25 11:49:11 +02:00
2025-09-16 13:55:16 +02:00
2021-06-30 08:48:18 -04:00
2026-06-29 10:46:01 +02:00
2023-05-30 12:42:13 +01:00
2024-05-25 16:16:19 +02:00
2026-05-07 10:55:27 +02:00
2024-07-05 09:00:35 +02:00
2023-02-06 07:49:44 +01:00
2023-08-11 11:45:27 +02:00
2022-01-05 12:34:57 +01:00
2026-02-20 13:22:28 +08:00
2023-05-17 11:13:22 +02:00
2024-04-13 12:50:03 +02:00
2023-01-18 11:30:05 +01:00
2022-06-25 11:49:10 +02:00
2022-03-23 09:10:41 +01:00
2025-02-07 03:34:27 +01:00
2023-03-22 13:27:11 +01:00
2022-07-29 17:10:37 +02:00
2023-05-17 11:13:27 +02:00
2025-07-17 10:07:54 +02:00
2024-02-23 08:12:39 +01:00
2026-05-07 10:55:16 +02:00
2025-02-07 03:34:21 +01:00
2026-01-26 16:51:56 +08:00
2023-08-30 16:31:49 +02:00
2022-03-16 13:20:27 +01:00
2023-05-17 11:13:15 +02:00
2021-12-14 10:18:06 +01:00
2026-04-09 14:44:46 +08:00
2023-08-11 11:45:17 +02:00
a86a8247a7