Tejun Heo
c3b85bda41
cgroup: Use css_tryget() instead of css_tryget_online() in task_get_css()
...
commit 18fa84a2db0e15b02baa5d94bdb5bd509175d2f6 upstream.
A PF_EXITING task can stay associated with an offline css. If such
task calls task_get_css(), it can get stuck indefinitely. This can be
triggered by BSD process accounting which writes to a file with
PF_EXITING set when racing against memcg disable as in the backtrace
at the end.
After this change, task_get_css() may return a css which was already
offline when the function was called. None of the existing users are
affected by this change.
INFO: rcu_sched self-detected stall on CPU
INFO: rcu_sched detected stalls on CPUs/tasks:
...
NMI backtrace for cpu 0
...
Call Trace:
<IRQ>
dump_stack+0x46/0x68
nmi_cpu_backtrace.cold.2+0x13/0x57
nmi_trigger_cpumask_backtrace+0xba/0xca
rcu_dump_cpu_stacks+0x9e/0xce
rcu_check_callbacks.cold.74+0x2af/0x433
update_process_times+0x28/0x60
tick_sched_timer+0x34/0x70
__hrtimer_run_queues+0xee/0x250
hrtimer_interrupt+0xf4/0x210
smp_apic_timer_interrupt+0x56/0x110
apic_timer_interrupt+0xf/0x20
</IRQ>
RIP: 0010:balance_dirty_pages_ratelimited+0x28f/0x3d0
...
btrfs_file_write_iter+0x31b/0x563
__vfs_write+0xfa/0x140
__kernel_write+0x4f/0x100
do_acct_process+0x495/0x580
acct_process+0xb9/0xdb
do_exit+0x748/0xa00
do_group_exit+0x3a/0xa0
get_signal+0x254/0x560
do_signal+0x23/0x5c0
exit_to_usermode_loop+0x5d/0xa0
prepare_exit_to_usermode+0x53/0x80
retint_user+0x8/0x8
Signed-off-by: Tejun Heo <tj@kernel.org >
Cc: stable@vger.kernel.org # v4.2+
Fixes: ec438699a9 ("cgroup, block: implement task_get_css() and use it in bio_associate_current()")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-06-19 08:18:00 +02:00
..
2019-01-22 21:40:33 +01:00
2018-12-01 09:37:29 +01:00
2019-03-27 14:14:39 +09:00
2018-08-18 15:55:59 -07:00
2018-09-30 08:49:55 -07:00
2019-02-12 19:46:57 +01:00
2019-05-31 06:46:24 -07:00
2019-03-13 14:02:35 -07:00
2019-05-22 07:37:41 +02:00
2019-04-17 08:38:42 +02:00
2019-02-20 10:25:46 +01:00
2018-11-27 16:13:05 +01:00
2019-04-17 08:38:46 +02:00
2018-10-12 15:25:17 +01:00
2019-05-08 07:21:54 +02:00
2019-02-27 10:08:52 +01:00
2018-09-03 16:10:40 +01:00
2019-05-04 09:20:22 +02:00
2018-08-23 13:44:43 -07:00
2018-09-28 18:04:06 -07:00
2019-02-15 08:10:13 +01:00
2019-01-26 09:32:34 +01:00
2018-08-22 08:08:27 -07:00
2018-08-30 14:18:03 +01:00
2019-04-20 09:16:05 +02:00
2019-03-05 17:58:50 +01:00
2018-08-22 10:52:46 -07:00
2019-05-31 06:46:00 -07:00
2018-08-17 16:20:27 -07:00
2019-06-09 09:17:11 +02:00
2019-04-17 08:38:51 +02:00
2018-08-31 14:48:56 -06:00
2018-09-11 10:59:53 -06:00
2019-01-31 08:14:41 +01:00
2019-05-25 18:23:48 +02:00
2019-05-31 06:46:19 -07:00
2019-06-19 08:18:00 +02:00
2019-04-05 22:33:03 +02:00
2018-08-17 16:20:32 -07:00
2018-11-13 11:08:25 -08:00
2019-06-09 09:17:23 +02:00
2019-02-27 10:08:53 +01:00
2019-06-09 09:17:23 +02:00
2019-02-27 10:08:53 +01:00
2019-06-04 08:02:34 +02:00
2019-06-11 12:20:52 +02:00
2019-03-10 07:17:15 +01:00
2018-08-23 13:44:43 -07:00
2018-08-22 10:52:46 -07:00
2018-08-22 10:52:48 -07:00
2019-05-25 18:23:26 +02:00
2019-03-23 20:10:09 +01:00
2019-04-03 06:26:30 +02:00
2018-08-17 16:20:32 -07:00
2019-06-04 08:02:34 +02:00
2019-05-16 19:41:22 +02:00
2019-05-16 19:41:17 +02:00
2018-08-25 13:40:38 -07:00
2019-04-05 22:32:59 +02:00
2019-05-31 06:46:12 -07:00
2019-05-08 07:21:51 +02:00
2018-12-17 09:24:38 +01:00
2018-12-01 09:37:31 +01:00
2018-12-05 19:32:10 +01:00
2019-05-31 06:46:18 -07:00
2019-02-12 19:47:14 +01:00
2018-08-23 18:48:43 -07:00
2019-03-23 20:10:08 +01:00
2018-11-13 11:08:54 -08:00
2019-02-12 19:47:24 +01:00
2018-12-05 19:32:13 +01:00
2019-05-31 06:46:28 -07:00
2019-01-13 09:51:04 +01:00
2019-05-22 07:37:40 +02:00
2019-05-22 07:37:40 +02:00
2019-01-31 08:14:36 +01:00
2019-05-08 07:21:43 +02:00
2018-11-21 09:19:20 +01:00
2018-08-26 11:48:42 -07:00
2019-03-05 17:58:51 +01:00
2018-08-15 10:25:26 -07:00
2018-08-22 10:52:47 -07:00
2018-08-22 10:52:52 -07:00
2019-03-05 17:58:45 +01:00
2019-04-05 22:33:09 +02:00
2019-05-22 07:37:44 +02:00
2018-08-16 19:36:55 +02:00
2019-06-04 08:02:34 +02:00
2019-06-04 08:02:34 +02:00
2018-08-17 16:20:30 -07:00
2019-04-20 09:15:59 +02:00
2019-05-10 17:54:08 +02:00
2019-03-23 20:09:48 +01:00
2018-08-18 11:44:53 -07:00
2019-04-27 09:36:37 +02:00
2019-05-16 19:41:22 +02:00
2018-08-24 13:20:33 -07:00
2019-06-09 09:17:19 +02:00
2018-08-15 10:25:26 -07:00
2018-12-29 13:37:59 +01:00
2019-04-17 08:38:51 +02:00
2018-08-22 10:52:45 -07:00
2019-01-13 09:51:04 +01:00
2018-09-13 15:18:04 -10:00
2018-09-13 15:18:04 -10:00
2019-05-04 09:20:11 +02:00
2018-08-22 10:52:44 -07:00
2018-10-09 08:30:51 +02:00
2018-09-05 14:36:53 +02:00
2019-06-09 09:17:23 +02:00
2019-05-31 06:46:05 -07:00
2019-01-09 17:38:42 +01:00
2018-12-05 19:31:59 +01:00
2019-02-23 09:07:25 +01:00
2019-04-27 09:36:30 +02:00
2019-06-04 08:02:34 +02:00
2019-06-04 08:02:34 +02:00
2018-09-23 21:55:24 -07:00
2018-08-23 16:03:58 -07:00
2018-11-21 09:19:20 +01:00
2018-08-17 16:20:29 -07:00
2018-08-22 10:52:45 -07:00
2018-11-13 11:08:24 -08:00
2019-06-09 09:17:24 +02:00
2018-08-23 18:48:44 -07:00
2019-05-31 06:46:30 -07:00
2018-08-17 16:20:28 -07:00
2018-08-23 18:48:43 -07:00
2018-09-03 19:05:13 -07:00
2019-05-25 18:23:38 +02:00
2018-08-22 10:52:45 -07:00
2019-04-05 22:33:11 +02:00
2018-12-01 09:37:34 +01:00
2019-05-04 09:20:11 +02:00
2018-08-22 10:52:46 -07:00
2019-03-23 20:10:04 +01:00
2019-06-11 12:20:52 +02:00
2019-01-09 17:38:33 +01:00
2018-12-05 19:32:03 +01:00
2019-06-15 11:54:10 +02:00
2018-08-22 18:17:29 +02:00
2019-06-11 12:20:50 +02:00
2019-04-05 22:32:56 +02:00
2019-04-05 22:32:56 +02:00
2019-04-05 22:33:12 +02:00
2018-08-15 10:25:26 -07:00
2018-10-02 14:38:02 -07:00
2018-08-20 09:22:45 -07:00
2018-08-22 10:52:43 -07:00
2018-11-13 11:08:45 -08:00
2019-06-04 08:02:30 +02:00
2019-05-25 18:23:20 +02:00
2019-04-03 06:26:28 +02:00
2019-05-31 06:46:16 -07:00
2018-08-16 12:14:42 -07:00
2019-03-13 14:02:35 -07:00
2019-04-17 08:38:45 +02:00
2018-10-12 12:35:02 +02:00
2019-04-20 09:16:05 +02:00
2018-08-23 18:48:44 -07:00
2018-08-18 11:44:53 -07:00
2018-12-29 13:37:55 +01:00
2018-11-13 11:08:51 -08:00
2019-06-17 19:51:56 +02:00
2018-08-22 15:11:35 +02:00
2019-05-31 06:46:29 -07:00
2018-09-03 13:26:44 +02:00
2018-10-17 15:35:29 -04:00
2018-12-08 12:59:07 +01:00
2018-12-13 09:16:15 +01:00
2018-09-12 14:58:47 -07:00
2019-05-08 07:21:44 +02:00
2018-08-23 18:48:44 -07:00
2018-08-16 09:57:20 -07:00
2018-09-13 17:58:30 +02:00
2019-02-27 10:09:01 +01:00
2019-04-17 08:38:52 +02:00
2018-09-13 15:18:04 -10:00
2018-09-13 15:18:04 -10:00
2018-11-13 11:08:42 -08:00