Eric Dumazet
7c11350616
fq_codel: reject silly quantum parameters
...
[ Upstream commit c7c5e6ff533fe1f9afef7d2fa46678987a1335a7 ]
syzbot found that forcing a big quantum attribute would crash hosts fast,
essentially using this:
tc qd replace dev eth0 root fq_codel quantum 4294967295
This is because fq_codel_dequeue() would have to loop
~2^31 times in :
if (flow->deficit <= 0) {
flow->deficit += q->quantum;
list_move_tail(&flow->flowchain, &q->old_flows);
goto begin;
}
SFQ max quantum is 2^19 (half a megabyte)
Lets adopt a max quantum of one megabyte for FQ_CODEL.
Fixes: 4b549a2ef4 ("fq_codel: Fair Queue Codel AQM")
Signed-off-by: Eric Dumazet <edumazet@google.com >
Reported-by: syzbot <syzkaller@googlegroups.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2021-09-22 11:48:14 +02:00
..
2018-07-30 16:21:49 -04:00
2018-07-23 19:18:10 +01:00
2019-09-19 09:09:29 +02:00
2020-06-07 13:17:54 +02:00
2021-05-22 10:59:43 +02:00
2020-06-25 15:33:10 +02:00
2018-07-19 23:26:01 -07:00
2021-03-24 11:07:35 +01:00
2018-08-06 10:24:33 +02:00
2018-08-15 22:54:12 -07:00
2018-08-22 10:52:49 -07:00
2018-08-11 15:46:41 -06:00
2018-07-09 09:07:52 -06:00
2021-06-10 13:24:08 +02:00
2020-01-27 14:51:14 +01:00
2018-07-27 10:40:16 +02:00
2019-12-31 16:34:57 +01:00
2019-12-17 20:34:59 +01:00
2019-08-06 19:06:52 +02:00
2021-01-06 14:44:59 +01:00
2020-04-13 10:45:03 +02:00
2018-07-29 12:53:54 -07:00
2018-07-12 17:37:13 -07:00
2018-07-19 13:58:44 -07:00
2018-07-04 22:30:28 +09:00
2021-07-20 16:16:01 +02:00
2018-07-15 14:03:06 +02:00
2018-07-15 13:55:47 +02:00
2018-11-13 11:08:46 -08:00
2019-05-25 18:23:40 +02:00
2020-12-30 11:25:48 +01:00
2018-07-29 12:57:26 -07:00
2021-06-30 08:48:21 -04:00
2019-02-27 10:08:58 +01:00
2020-07-29 10:16:52 +02:00
2020-01-14 20:07:01 +01:00
2018-07-29 12:37:06 -07:00
2018-07-26 17:04:37 -07:00
2021-01-06 14:44:59 +01:00
2018-07-07 17:41:38 +02:00
2019-09-16 08:21:47 +02:00
2018-11-21 09:19:23 +01:00
2018-08-06 17:59:22 +02:00
2020-09-23 12:10:59 +02:00
2018-08-03 10:03:57 -07:00
2021-01-06 14:44:59 +01:00
2018-08-02 06:04:57 -04:00
2018-07-27 07:52:39 -04:00
2018-10-05 16:32:04 -07:00
2018-07-24 14:41:08 -07:00
2018-10-05 16:32:04 -07:00
2021-01-06 14:44:59 +01:00
2018-07-13 14:21:16 -07:00
2020-05-27 17:37:39 +02:00
2019-01-09 17:38:36 +01:00
2018-07-29 12:37:06 -07:00
2018-11-27 16:13:01 +01:00
2021-01-06 14:44:59 +01:00
2020-11-05 11:08:51 +01:00
2019-07-21 09:03:02 +02:00
2019-08-16 10:12:45 +02:00
2018-07-08 11:13:25 +09:00
2018-08-15 14:59:06 -05:00
2018-07-19 11:46:57 +01:00
2020-10-30 10:38:26 +01:00
2018-08-07 12:22:15 -07:00
2021-09-22 11:48:14 +02:00
2018-07-31 19:56:42 +10:00
2018-08-11 12:13:49 -07:00
2018-12-05 19:32:04 +01:00
2018-09-02 16:14:44 -07:00
2018-07-10 22:18:52 +02:00
2018-07-23 20:44:12 -07:00
2018-11-23 08:17:06 +01:00
2021-09-22 11:48:04 +02:00
2020-04-02 15:28:16 +02:00
2018-10-05 16:32:04 -07:00
2018-10-07 21:06:28 -07:00
2019-06-17 19:51:56 +02:00
2020-05-02 17:25:48 +02:00
2021-01-06 14:44:59 +01:00
2018-08-01 09:56:10 -07:00
2019-06-04 08:02:33 +02:00
2021-05-22 10:59:31 +02:00
2018-10-08 15:45:18 +01:00
2018-07-27 06:39:57 -04:00
2018-07-04 09:32:22 -04:00
2018-07-24 17:39:28 -04:00
2020-07-22 09:32:09 +02:00
2018-09-03 21:23:24 -07:00
2020-11-05 11:08:40 +01:00
2020-12-02 08:48:07 +01:00
2020-06-03 08:19:46 +02:00