Alexander Kuznetsov
7e7ff4d058
cgroup1: don't allow '\n' in renaming
commit b7e24eb1caa5f8da20d405d262dba67943aedc42 upstream.
cgroup_mkdir() have restriction on newline usage in names:
$ mkdir $'/sys/fs/cgroup/cpu/test\ntest2'
mkdir: cannot create directory
'/sys/fs/cgroup/cpu/test\ntest2': Invalid argument
But in cgroup1_rename() such check is missed.
This allows us to make /proc/<pid>/cgroup unparsable:
$ mkdir /sys/fs/cgroup/cpu/test
$ mv /sys/fs/cgroup/cpu/test $'/sys/fs/cgroup/cpu/test\ntest2'
$ echo $$ > $'/sys/fs/cgroup/cpu/test\ntest2'
$ cat /proc/self/cgroup
11:pids:/
10:freezer:/
9:hugetlb:/
8:cpuset:/
7:blkio:/user.slice
6:memory:/user.slice
5:net_cls,net_prio:/
4:perf_event:/
3:devices:/user.slice
2:cpu,cpuacct:/test
test2
1:name=systemd:/
0::/
Signed-off-by: Alexander Kuznetsov <wwfq@yandex-team.ru>
Reported-by: Andrey Krasichkov <buglloc@yandex-team.ru>
Acked-by: Dmitry Yakunin <zeil@yandex-team.ru>
Cc: stable@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-16 11:54:59 +02:00
..
2021-06-10 13:24:08 +02:00
2021-06-16 11:54:59 +02:00
2021-03-04 09:39:31 +01:00
2020-11-18 19:18:51 +01:00
2021-06-16 11:54:56 +02:00
2020-09-17 13:45:31 +02:00
2021-05-22 10:59:14 +02:00
2019-10-07 18:57:10 +02:00
2021-05-26 11:48:32 +02:00
2021-02-03 23:23:24 +01:00
2021-03-04 09:39:57 +01:00
2020-02-11 04:33:55 -08:00
2021-06-10 13:24:09 +02:00
2021-05-22 10:59:21 +02:00
2021-05-22 10:59:22 +02:00
2019-05-31 06:46:05 -07:00
2019-12-13 08:51:11 +01:00
2020-10-01 13:14:33 +02:00
2020-06-22 09:05:13 +02:00
2020-06-22 09:05:13 +02:00
2020-06-22 09:05:13 +02:00
2019-12-01 09:17:17 +01:00
2020-01-23 08:21:29 +01:00
2020-06-22 09:04:58 +02:00
2020-06-22 09:05:28 +02:00
2020-12-30 11:25:45 +01:00
2020-01-09 10:19:00 +01:00
2021-01-30 13:32:11 +01:00
2020-11-24 13:27:23 +01:00
2021-01-30 13:32:11 +01:00
2021-05-22 10:59:21 +02:00
2019-04-20 09:16:02 +02:00
2019-05-31 06:46:19 -07:00
2021-03-04 09:39:30 +01:00
2020-07-16 08:17:26 +02:00
2019-02-12 19:47:20 +01:00
2021-02-03 23:23:23 +01:00
2021-05-22 10:59:44 +02:00
2020-04-17 10:48:52 +02:00
2021-02-13 13:51:13 +01:00
2021-02-07 14:48:38 +01:00
2021-02-10 09:21:06 +01:00
2020-01-29 16:43:27 +01:00
2021-05-22 10:59:23 +02:00
2020-03-25 08:06:13 +01:00
2020-05-27 17:37:36 +02:00
2019-12-01 09:17:10 +01:00
2019-07-26 09:14:01 +02:00
2019-01-13 09:51:06 +01:00
2021-05-26 11:48:32 +02:00
2020-11-18 19:18:52 +01:00
2020-08-26 10:30:59 +02:00
2019-09-16 08:22:20 +02:00
2021-03-04 09:39:54 +01:00
2020-11-10 12:35:53 +01:00
2021-05-22 10:59:39 +02:00
2021-02-07 14:48:38 +01:00
2020-10-01 13:14:29 +02:00
2021-02-07 14:48:37 +01:00
2020-01-09 10:18:59 +01:00
2021-03-04 09:39:46 +01:00
2020-10-14 10:31:21 +02:00
2021-05-22 10:59:39 +02:00
2018-11-13 11:09:00 -08:00
2020-02-24 08:34:49 +01:00
2021-06-16 11:54:57 +02:00