Kees Cook 6e75ebcd0b
net/mlx4_core: Avoid impossible mlx4_db_alloc() order value ...
[ Upstream commit 4a6f18f28627e121bd1f74b5fcc9f945d6dbeb1e ]
GCC can see that the value range for "order" is capped, but this leads
it to consider that it might be negative, leading to a false positive
warning (with GCC 15 with -Warray-bounds -fdiagnostics-details):
../drivers/net/ethernet/mellanox/mlx4/alloc.c:691:47: error: array subscript -1 is below array bounds of 'long unsigned int *[2]' [-Werror=array-bounds=]
691 | i = find_first_bit(pgdir->bits[o], MLX4_DB_PER_PAGE >> o);
| ~~~~~~~~~~~^~~
'mlx4_alloc_db_from_pgdir': events 1-2
691 | i = find_first_bit(pgdir->bits[o], MLX4_DB_PER_PAGE >> o); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| | | | | (2) out of array bounds here
| (1) when the condition is evaluated to true In file included from ../drivers/net/ethernet/mellanox/mlx4/mlx4.h:53,
from ../drivers/net/ethernet/mellanox/mlx4/alloc.c:42:
../include/linux/mlx4/device.h:664:33: note: while referencing 'bits'
664 | unsigned long *bits[2];
| ^~~~
Switch the argument to unsigned int, which removes the compiler needing
to consider negative values.
Signed-off-by: Kees Cook <kees@kernel.org >
Link: https://patch.msgid.link/20250210174504.work.075-kees@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
Signed-off-by: Sasha Levin <sashal@kernel.org >
Signed-off-by: Ulrich Hecht <uli@kernel.org >
2025-07-17 10:07:57 +02:00
2023-01-18 11:29:59 +01:00
2022-08-25 11:15:23 +02:00
2025-07-17 10:07:57 +02:00
2022-03-16 13:20:26 +01:00
2020-10-01 13:14:28 +02:00
2022-06-14 16:59:39 +02:00
2023-08-11 11:45:16 +02:00
2022-09-05 10:26:29 +02:00
2022-09-15 12:17:02 +02:00
2023-05-30 12:42:14 +01:00
2020-06-30 23:17:12 -04:00
2025-05-08 11:55:42 +02:00
2024-02-23 08:12:39 +01:00
2024-07-18 11:39:39 +02:00
2025-04-03 10:09:49 +02:00
2021-05-07 10:49:25 +02:00
2022-03-23 09:10:43 +01:00
2022-10-26 13:19:32 +02:00
2021-08-08 08:54:29 +02:00
2025-06-11 10:19:25 +02:00
2020-08-19 08:15:05 +02:00
2024-09-04 13:12:59 +02:00
2023-06-09 10:23:56 +02:00
2022-11-10 17:46:56 +01:00
2022-04-15 14:14:41 +02:00
2024-12-05 10:59:42 +01:00
2021-09-22 11:47:59 +02:00
2024-02-23 08:12:46 +01:00
2022-09-15 12:17:02 +02:00
2020-12-30 11:25:39 +01:00
2020-09-09 19:04:31 +02:00
2021-09-26 13:39:48 +02:00
2022-07-21 21:09:26 +02:00
2022-12-14 11:28:27 +01:00
2024-11-08 16:19:18 +01:00
2024-07-18 11:39:31 +02:00
2021-03-24 11:07:31 +01:00
2020-12-30 11:25:40 +01:00
2021-01-23 15:49:55 +01:00
2021-10-06 15:31:17 +02:00
2021-05-26 11:48:35 +02:00
2021-11-26 11:36:02 +01:00
2023-08-08 19:49:17 +02:00
2023-12-13 17:42:15 +01:00
2024-09-04 13:12:59 +02:00
2023-04-05 11:15:42 +02:00
2023-12-20 15:38:01 +01:00
2020-11-05 11:08:35 +01:00
2023-05-17 11:13:06 +02:00
2021-03-04 09:39:57 +01:00
2024-02-23 08:12:40 +01:00
2021-01-23 15:49:55 +01:00
2025-07-17 10:07:55 +02:00
2024-02-23 08:12:53 +01:00
2022-10-26 13:19:31 +02:00
2025-02-07 03:34:24 +01:00
2021-03-11 14:05:02 +01:00
2022-11-10 17:46:55 +01:00
2021-10-27 09:53:13 +02:00
2024-05-17 11:42:37 +02:00
2023-09-23 10:47:59 +02:00
2021-04-07 12:48:50 +02:00
2024-09-04 13:13:08 +02:00
2021-12-08 08:50:13 +01:00
2021-11-26 11:35:59 +01:00
2020-10-14 10:31:21 +02:00
2024-04-13 12:50:14 +02:00
2021-09-22 11:47:56 +02:00
2021-09-22 11:47:56 +02:00
2020-11-05 11:08:35 +01:00
2024-07-18 11:39:35 +02:00
2023-04-20 12:04:39 +02:00
2021-01-30 13:32:12 +01:00
2021-03-11 14:04:59 +01:00
2024-04-13 12:50:12 +02:00
2023-12-08 08:43:23 +01:00
2020-11-05 11:08:54 +01:00
2024-03-26 18:22:37 -04:00
2024-02-23 08:12:55 +01:00
2021-07-11 12:49:27 +02:00
2023-02-22 12:47:20 +01:00
2022-06-25 11:49:07 +02:00
2024-08-19 05:31:56 +02:00
2025-02-07 03:34:27 +01:00
2020-09-23 12:10:59 +02:00
2021-05-22 10:59:40 +02:00
2021-03-04 09:39:59 +01:00
2023-09-23 10:48:11 +02:00
2021-03-30 14:37:00 +02:00
2023-10-10 21:44:57 +02:00
2025-02-07 03:34:27 +01:00
2023-03-11 16:31:51 +01:00
2023-10-25 11:16:17 +02:00
2021-08-26 08:36:39 -04:00
2021-02-03 23:23:26 +01:00
2025-05-08 11:55:41 +02:00
2020-07-29 10:16:57 +02:00
2021-05-22 10:59:50 +02:00
2022-10-26 13:19:35 +02:00
2021-12-08 08:50:11 +01:00
2023-06-28 10:15:27 +02:00
2021-03-04 09:39:59 +01:00
2021-08-26 08:36:40 -04:00
2024-11-08 16:19:06 +01:00
2024-12-05 10:59:31 +01:00
2025-04-03 10:09:44 +02:00
2021-01-09 13:43:48 +01:00
2023-03-11 16:31:35 +01:00
2023-02-06 07:49:46 +01:00
2022-07-02 16:27:39 +02:00
2021-03-04 09:39:44 +01:00
2022-08-25 11:15:23 +02:00
2020-10-14 10:31:26 +02:00
2023-03-11 16:31:51 +01:00
2021-02-07 14:48:38 +01:00
2025-04-03 10:09:49 +02:00
2025-02-07 03:34:23 +01:00
2023-10-10 21:45:00 +02:00
2021-09-22 11:47:57 +02:00
2020-09-09 19:04:28 +02:00
2024-02-23 08:12:58 +01:00
2022-06-14 16:59:25 +02:00
2021-04-28 13:16:51 +02:00
2023-01-18 11:30:49 +01:00
2023-10-25 11:16:31 +02:00
2021-10-09 14:11:03 +02:00
2021-09-22 11:48:12 +02:00
2022-06-25 11:49:12 +02:00
2022-12-08 11:18:34 +01:00
2022-04-15 14:15:07 +02:00
2022-11-23 07:53:44 +01:00
2021-05-22 10:59:23 +02:00
2024-06-16 13:23:35 +02:00
2021-08-26 08:36:41 -04:00
2021-03-30 14:37:02 +02:00
2023-09-23 10:47:59 +02:00
2021-06-30 08:48:18 -04:00
2022-05-18 09:42:47 +02:00
2025-04-04 11:11:26 +02:00
2023-06-21 15:39:57 +02:00
2020-11-18 19:18:44 +01:00
2020-11-18 19:18:44 +01:00
2023-06-21 15:39:57 +02:00
2025-05-05 15:34:17 +02:00
2022-04-15 14:15:03 +02:00
2020-10-01 13:14:41 +02:00
2025-06-11 10:19:26 +02:00
2023-09-23 10:47:58 +02:00
2023-08-11 11:45:06 +02:00
2020-10-07 08:00:08 +02:00
2022-06-14 16:59:38 +02:00
2023-02-25 11:51:51 +01:00
2024-07-05 09:00:32 +02:00
2021-12-08 08:50:11 +01:00
2021-01-06 14:45:00 +01:00
2022-11-01 19:05:40 +01:00
2020-10-29 09:55:15 +01:00
2025-04-03 10:09:42 +02:00
2021-08-08 08:54:30 +02:00
2021-07-11 12:49:30 +02:00
2025-04-04 11:11:27 +02:00
2023-09-23 10:48:11 +02:00
2025-06-11 10:19:55 +02:00
2023-12-13 17:42:19 +01:00
2023-02-22 12:47:17 +01:00
2023-11-08 11:22:18 +01:00
2023-08-11 11:45:40 +02:00
2025-03-11 08:34:59 +01:00
2023-06-09 10:23:54 +02:00
2025-04-04 11:35:21 +02:00
2022-06-25 11:49:11 +02:00
2023-11-20 10:29:18 +01:00
2023-05-17 11:13:28 +02:00
2023-01-18 11:30:11 +01:00
2021-06-30 08:48:19 -04:00
2022-06-14 16:59:13 +02:00
2023-11-28 16:46:33 +00:00
2024-03-26 18:22:40 -04:00
2023-10-25 11:16:20 +02:00
2023-10-25 11:16:20 +02:00
2023-08-30 16:31:56 +02:00
2023-02-25 11:51:50 +01:00
2022-07-02 16:27:31 +02:00
2023-06-28 10:15:28 +02:00
2024-09-12 11:02:55 +02:00
2022-09-05 10:26:34 +02:00
2023-11-08 11:22:19 +01:00
2021-12-14 10:18:04 +01:00
2022-07-12 16:29:03 +02:00
2022-09-05 10:26:28 +02:00
2024-02-23 08:12:58 +01:00
2020-12-30 11:26:01 +01:00
2020-10-01 13:14:30 +02:00
2023-08-11 11:45:22 +02:00
2024-05-02 16:17:14 +02:00
2023-03-22 13:27:11 +01:00
2022-06-25 11:49:11 +02:00
2021-09-22 11:48:11 +02:00
2021-05-22 10:59:39 +02:00
2021-06-30 08:48:18 -04:00
2021-03-17 16:43:51 +01:00
2023-05-30 12:42:13 +01:00
2024-05-25 16:16:19 +02:00
2024-07-05 09:00:35 +02:00
2023-02-06 07:49:44 +01:00
2021-03-07 12:19:01 +01:00
2023-08-11 11:45:27 +02:00
2022-01-05 12:34:57 +01:00
2021-03-24 11:07:37 +01:00
2023-05-17 11:13:22 +02:00
2020-11-18 19:18:40 +01:00
2024-04-13 12:50:03 +02:00
2023-01-18 11:30:05 +01:00
2022-06-25 11:49:10 +02:00
2022-03-23 09:10:41 +01:00
2025-02-07 03:34:27 +01:00
2020-12-30 11:26:01 +01:00
2023-03-22 13:27:11 +01:00
2021-05-22 10:59:31 +02:00
2022-07-29 17:10:37 +02:00
2023-05-17 11:13:27 +02:00
2025-07-17 10:07:54 +02:00
2021-03-30 14:36:58 +02:00
2020-09-09 19:04:29 +02:00
2024-02-23 08:12:39 +01:00
2021-03-24 11:07:34 +01:00
2025-03-11 08:35:00 +01:00
2025-02-07 03:34:21 +01:00
2022-03-16 13:20:27 +01:00
2023-08-30 16:31:49 +02:00
2020-10-07 08:00:05 +02:00
2022-03-16 13:20:27 +01:00
2023-05-17 11:13:15 +02:00
2021-12-14 10:18:06 +01:00
2023-08-11 11:45:17 +02:00
2020-08-11 15:32:34 +02:00
2021-03-07 12:19:01 +01:00
6e75ebcd0b