Kuniyuki Iwashima
bd46333993
atm: atmtcp: Prevent arbitrary write in atmtcp_recv_control().
[ Upstream commit ec79003c5f9d2c7f9576fc69b8dbda80305cbe3a ]
syzbot reported the splat below. [0]
When atmtcp_v_open() or atmtcp_v_close() is called via connect()
or close(), atmtcp_send_control() is called to send an in-kernel
special message.
The message has ATMTCP_HDR_MAGIC in atmtcp_control.hdr.length.
Also, a pointer of struct atm_vcc is set to atmtcp_control.vcc.
The notable thing is struct atmtcp_control is uAPI but has a
space for an in-kernel pointer.
struct atmtcp_control {
struct atmtcp_hdr hdr; /* must be first */
...
atm_kptr_t vcc; /* both directions */
...
} __ATM_API_ALIGN;
typedef struct { unsigned char _[8]; } __ATM_API_ALIGN atm_kptr_t;
The special message is processed in atmtcp_recv_control() called
from atmtcp_c_send().
atmtcp_c_send() is vcc->dev->ops->send() and called from 2 paths:
1. .ndo_start_xmit() (vcc->send() == atm_send_aal0())
2. vcc_sendmsg()
The problem is sendmsg() does not validate the message length and
userspace can abuse atmtcp_recv_control() to overwrite any kptr
by atmtcp_control.
Let's add a new ->pre_send() hook to validate messages from sendmsg().
[0]:
Oops: general protection fault, probably for non-canonical address 0xdffffc00200000ab: 0000 [#1] SMP KASAN PTI
KASAN: probably user-memory-access in range [0x0000000100000558-0x000000010000055f]
CPU: 0 UID: 0 PID: 5865 Comm: syz-executor331 Not tainted 6.17.0-rc1-syzkaller-00215-gbab3ce404553 #0 PREEMPT(full)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
RIP: 0010:atmtcp_recv_control drivers/atm/atmtcp.c:93 [inline]
RIP: 0010:atmtcp_c_send+0x1da/0x950 drivers/atm/atmtcp.c:297
Code: 4d 8d 75 1a 4c 89 f0 48 c1 e8 03 42 0f b6 04 20 84 c0 0f 85 15 06 00 00 41 0f b7 1e 4d 8d b7 60 05 00 00 4c 89 f0 48 c1 e8 03 <42> 0f b6 04 20 84 c0 0f 85 13 06 00 00 66 41 89 1e 4d 8d 75 1c 4c
RSP: 0018:ffffc90003f5f810 EFLAGS: 00010203
RAX: 00000000200000ab RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff88802a510000 RSI: 00000000ffffffff RDI: ffff888030a6068c
RBP: ffff88802699fb40 R08: ffff888030a606eb R09: 1ffff1100614c0dd
R10: dffffc0000000000 R11: ffffffff8718fc40 R12: dffffc0000000000
R13: ffff888030a60680 R14: 000000010000055f R15: 00000000ffffffff
FS: 00007f8d7e9236c0(0000) GS:ffff888125c1c000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000045ad50 CR3: 0000000075bde000 CR4: 00000000003526f0
Call Trace:
<TASK>
vcc_sendmsg+0xa10/0xc60 net/atm/common.c:645
sock_sendmsg_nosec net/socket.c:714 [inline]
__sock_sendmsg+0x219/0x270 net/socket.c:729
____sys_sendmsg+0x505/0x830 net/socket.c:2614
___sys_sendmsg+0x21f/0x2a0 net/socket.c:2668
__sys_sendmsg net/socket.c:2700 [inline]
__do_sys_sendmsg net/socket.c:2705 [inline]
__se_sys_sendmsg net/socket.c:2703 [inline]
__x64_sys_sendmsg+0x19b/0x260 net/socket.c:2703
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f8d7e96a4a9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8d7e923198 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f8d7e9f4308 RCX: 00007f8d7e96a4a9
RDX: 0000000000000000 RSI: 0000200000000240 RDI: 0000000000000005
RBP: 00007f8d7e9f4300 R08: 65732f636f72702f R09: 65732f636f72702f
R10: 65732f636f72702f R11: 0000000000000246 R12: 00007f8d7e9c10ac
R13: 00007f8d7e9231a0 R14: 0000200000000200 R15: 0000200000000250
</TASK>
Modules linked in:
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Reported-by: syzbot+1741b56d54536f4ec349@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/68a6767c.050a0220.3d78fd.0011.GAE@google.com/
Tested-by: syzbot+1741b56d54536f4ec349@syzkaller.appspotmail.com
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20250821021901.2814721-1-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Ulrich Hecht <uli@kernel.org>
2025-09-22 10:17:52 +02:00
..
2019-12-13 08:51:18 +01:00
2023-01-18 11:29:59 +01:00
2020-04-02 15:28:16 +02:00
2019-12-05 09:20:15 +01:00
2020-04-29 16:31:24 +02:00
2020-01-27 14:50:42 +01:00
2022-08-25 11:15:23 +02:00
2025-07-17 10:07:57 +02:00
2022-03-16 13:20:26 +01:00
2020-10-01 13:14:28 +02:00
2022-06-14 16:59:39 +02:00
2023-08-11 11:45:16 +02:00
2022-09-05 10:26:29 +02:00
2022-09-15 12:17:02 +02:00
2023-05-30 12:42:14 +01:00
2020-06-30 23:17:12 -04:00
2020-01-23 08:21:39 +01:00
2025-05-08 11:55:42 +02:00
2024-02-23 08:12:39 +01:00
2024-07-18 11:39:39 +02:00
2025-09-16 13:55:20 +02:00
2021-05-07 10:49:25 +02:00
2020-01-09 10:19:01 +01:00
2022-03-23 09:10:43 +01:00
2022-10-26 13:19:32 +02:00
2019-12-13 08:52:59 +01:00
2025-09-22 10:17:52 +02:00
2021-08-08 08:54:29 +02:00
2025-06-11 10:19:25 +02:00
2019-05-31 06:46:00 -07:00
2020-08-19 08:15:05 +02:00
2024-09-04 13:12:59 +02:00
2023-06-09 10:23:56 +02:00
2022-11-10 17:46:56 +01:00
2022-04-15 14:14:41 +02:00
2019-10-05 13:10:03 +02:00
2024-12-05 10:59:42 +01:00
2020-04-29 16:31:17 +02:00
2021-09-22 11:47:59 +02:00
2019-07-03 13:14:48 +02:00
2024-02-23 08:12:46 +01:00
2022-09-15 12:17:02 +02:00
2019-10-05 13:09:54 +02:00
2020-12-30 11:25:39 +01:00
2020-09-09 19:04:31 +02:00
2021-09-26 13:39:48 +02:00
2019-08-16 10:12:38 +02:00
2022-07-21 21:09:26 +02:00
2022-12-14 11:28:27 +01:00
2024-11-08 16:19:18 +01:00
2019-08-06 19:06:52 +02:00
2019-08-06 19:06:52 +02:00
2024-07-18 11:39:31 +02:00
2021-03-24 11:07:31 +01:00
2020-12-30 11:25:40 +01:00
2021-01-23 15:49:55 +01:00
2021-10-06 15:31:17 +02:00
2021-05-26 11:48:35 +02:00
2021-11-26 11:36:02 +01:00
2023-08-08 19:49:17 +02:00
2019-11-20 18:47:11 +01:00
2019-12-31 16:36:22 +01:00
2023-12-13 17:42:15 +01:00
2019-11-24 08:20:07 +01:00
2024-09-04 13:12:59 +02:00
2023-04-05 11:15:42 +02:00
2023-12-20 15:38:01 +01:00
2020-11-05 11:08:35 +01:00
2023-05-17 11:13:06 +02:00
2020-04-17 10:48:45 +02:00
2021-03-04 09:39:57 +01:00
2024-02-23 08:12:40 +01:00
2021-01-23 15:49:55 +01:00
2025-09-16 13:55:07 +02:00
2024-02-23 08:12:53 +01:00
2022-10-26 13:19:31 +02:00
2019-11-20 18:47:40 +01:00
2025-02-07 03:34:24 +01:00
2021-03-11 14:05:02 +01:00
2022-11-10 17:46:55 +01:00
2019-05-16 19:41:17 +02:00
2021-10-27 09:53:13 +02:00
2020-06-25 15:33:02 +02:00
2024-05-17 11:42:37 +02:00
2023-09-23 10:47:59 +02:00
2021-04-07 12:48:50 +02:00
2019-11-24 08:19:14 +01:00
2024-09-04 13:13:08 +02:00
2021-12-08 08:50:13 +01:00
2021-11-26 11:35:59 +01:00
2020-10-14 10:31:21 +02:00
2024-04-13 12:50:14 +02:00
2021-09-22 11:47:56 +02:00
2021-09-22 11:47:56 +02:00
2020-11-05 11:08:35 +01:00
2019-11-20 18:45:55 +01:00
2024-07-18 11:39:35 +02:00
2023-04-20 12:04:39 +02:00
2021-01-30 13:32:12 +01:00
2019-12-05 09:21:03 +01:00
2021-03-11 14:04:59 +01:00
2024-04-13 12:50:12 +02:00
2019-09-10 10:33:44 +01:00
2025-07-17 10:08:05 +02:00
2020-11-05 11:08:54 +01:00
2024-03-26 18:22:37 -04:00
2024-02-23 08:12:55 +01:00
2021-07-11 12:49:27 +02:00
2023-02-22 12:47:20 +01:00
2022-06-25 11:49:07 +02:00
2024-08-19 05:31:56 +02:00
2019-10-17 13:45:42 -07:00
2025-02-07 03:34:27 +01:00
2020-09-23 12:10:59 +02:00
2021-05-22 10:59:40 +02:00
2021-03-04 09:39:59 +01:00
2019-12-05 09:19:39 +01:00
2020-05-10 10:30:12 +02:00
2023-09-23 10:48:11 +02:00
2020-01-12 12:17:25 +01:00
2021-03-30 14:37:00 +02:00
2019-08-09 17:52:34 +02:00
2023-10-10 21:44:57 +02:00
2025-09-16 13:55:16 +02:00
2023-03-11 16:31:51 +01:00
2023-10-25 11:16:17 +02:00
2020-03-18 07:14:11 +01:00
2021-08-26 08:36:39 -04:00
2021-02-03 23:23:26 +01:00
2020-02-28 16:38:59 +01:00
2025-05-08 11:55:41 +02:00
2020-07-29 10:16:57 +02:00
2020-05-10 10:30:11 +02:00
2020-04-17 10:48:41 +02:00
2021-05-22 10:59:50 +02:00
2022-10-26 13:19:35 +02:00
2021-12-08 08:50:11 +01:00
2023-06-28 10:15:27 +02:00
2021-03-04 09:39:59 +01:00
2021-08-26 08:36:40 -04:00
2020-02-28 16:38:50 +01:00
2024-11-08 16:19:06 +01:00
2024-12-05 10:59:31 +01:00
2019-06-04 08:02:34 +02:00
2019-06-04 08:02:34 +02:00
2025-04-03 10:09:44 +02:00
2021-01-09 13:43:48 +01:00
2023-03-11 16:31:35 +01:00
2023-02-06 07:49:46 +01:00
2019-12-13 08:52:43 +01:00
2022-07-02 16:27:39 +02:00
2020-04-23 10:30:24 +02:00
2021-03-04 09:39:44 +01:00
2022-08-25 11:15:23 +02:00
2020-06-22 09:05:15 +02:00
2020-10-14 10:31:26 +02:00
2023-03-11 16:31:51 +01:00
2021-02-07 14:48:38 +01:00
2025-04-03 10:09:49 +02:00
2020-04-29 16:31:19 +02:00
2025-02-07 03:34:23 +01:00
2023-10-10 21:45:00 +02:00
2020-01-04 19:13:15 +01:00
2019-06-09 09:17:19 +02:00
2020-02-24 08:34:46 +01:00
2021-09-22 11:47:57 +02:00
2020-09-09 19:04:28 +02:00
2019-09-06 10:22:19 +02:00
2024-02-23 08:12:58 +01:00
2022-06-14 16:59:25 +02:00
2021-04-28 13:16:51 +02:00
2023-01-18 11:30:49 +01:00
2023-10-25 11:16:31 +02:00
2021-10-09 14:11:03 +02:00
2020-02-11 04:34:18 -08:00
2021-09-22 11:48:12 +02:00
2020-01-29 16:43:27 +01:00
2019-12-31 16:35:38 +01:00
2019-11-12 19:20:36 +01:00
2022-06-25 11:49:12 +02:00
2022-12-08 11:18:34 +01:00
2022-04-15 14:15:07 +02:00
2022-11-23 07:53:44 +01:00
2021-05-22 10:59:23 +02:00
2024-06-16 13:23:35 +02:00
2019-05-31 06:46:05 -07:00
2021-08-26 08:36:41 -04:00
2021-03-30 14:37:02 +02:00
2023-09-23 10:47:59 +02:00
2021-06-30 08:48:18 -04:00
2022-05-18 09:42:47 +02:00
2025-04-04 11:11:26 +02:00
2023-06-21 15:39:57 +02:00
2019-06-04 08:02:34 +02:00
2020-11-18 19:18:44 +01:00
2020-11-18 19:18:44 +01:00
2023-06-21 15:39:57 +02:00
2025-05-05 15:34:17 +02:00
2025-09-22 10:17:51 +02:00
2020-10-01 13:14:41 +02:00
2019-09-06 10:22:23 +02:00
2025-06-11 10:19:26 +02:00
2023-09-23 10:47:58 +02:00
2023-08-11 11:45:06 +02:00
2020-10-07 08:00:08 +02:00
2022-06-14 16:59:38 +02:00
2023-02-25 11:51:51 +01:00
2020-04-13 10:45:06 +02:00
2020-04-17 10:48:45 +02:00
2024-07-05 09:00:32 +02:00
2021-12-08 08:50:11 +01:00
2021-01-06 14:45:00 +01:00
2022-11-01 19:05:40 +01:00
2020-10-29 09:55:15 +01:00
2025-04-03 10:09:42 +02:00
2021-08-08 08:54:30 +02:00
2020-03-25 08:06:13 +01:00
2021-07-11 12:49:30 +02:00
2025-04-04 11:11:27 +02:00
2023-09-23 10:48:11 +02:00
2020-04-17 10:48:46 +02:00
2025-09-16 13:55:19 +02:00
2020-04-23 10:30:20 +02:00
2020-02-11 04:34:11 -08:00
2023-12-13 17:42:19 +01:00
2023-02-22 12:47:17 +01:00
2019-05-04 09:20:11 +02:00
2023-11-08 11:22:18 +01:00
2020-01-27 14:50:26 +01:00
2023-08-11 11:45:40 +02:00
2020-05-20 08:18:45 +02:00
2025-03-11 08:34:59 +01:00
2020-01-04 19:13:35 +01:00
2023-06-09 10:23:54 +02:00
2025-09-16 13:55:10 +02:00
2022-06-25 11:49:11 +02:00
2023-11-20 10:29:18 +01:00
2023-05-17 11:13:28 +02:00
2023-01-18 11:30:11 +01:00
2019-06-11 12:20:52 +02:00
2021-06-30 08:48:19 -04:00
2022-06-14 16:59:13 +02:00
2023-11-28 16:46:33 +00:00
2024-03-26 18:22:40 -04:00
2023-10-25 11:16:20 +02:00
2023-10-25 11:16:20 +02:00
2023-08-30 16:31:56 +02:00
2023-02-25 11:51:50 +01:00
2022-07-02 16:27:31 +02:00
2020-02-24 08:34:46 +01:00
2023-06-28 10:15:28 +02:00
2019-12-05 09:19:38 +01:00
2024-09-12 11:02:55 +02:00
2022-09-05 10:26:34 +02:00
2023-11-08 11:22:19 +01:00
2020-01-27 14:50:37 +01:00
2021-12-14 10:18:04 +01:00
2022-07-12 16:29:03 +02:00
2022-09-05 10:26:28 +02:00
2024-02-23 08:12:58 +01:00
2020-04-02 15:28:22 +02:00
2020-12-30 11:26:01 +01:00
2020-10-01 13:14:30 +02:00
2023-08-11 11:45:22 +02:00
2024-05-02 16:17:14 +02:00
2020-06-22 09:05:03 +02:00
2023-03-22 13:27:11 +01:00
2020-01-27 14:51:05 +01:00
2022-06-25 11:49:11 +02:00
2025-09-16 13:55:16 +02:00
2021-05-22 10:59:39 +02:00
2019-05-31 06:46:16 -07:00
2021-06-30 08:48:18 -04:00
2021-03-17 16:43:51 +01:00
2023-05-30 12:42:13 +01:00
2024-05-25 16:16:19 +02:00
2020-04-17 10:48:43 +02:00
2019-12-05 09:20:57 +01:00
2020-04-23 10:30:19 +02:00
2020-01-27 14:50:22 +01:00
2024-07-05 09:00:35 +02:00
2023-02-06 07:49:44 +01:00
2021-03-07 12:19:01 +01:00
2023-08-11 11:45:27 +02:00
2022-01-05 12:34:57 +01:00
2021-03-24 11:07:37 +01:00
2023-05-17 11:13:22 +02:00
2020-11-18 19:18:40 +01:00
2019-12-21 10:57:17 +01:00
2019-11-20 18:45:24 +01:00
2024-04-13 12:50:03 +02:00
2023-01-18 11:30:05 +01:00
2022-06-25 11:49:10 +02:00
2020-01-23 08:21:32 +01:00
2022-03-23 09:10:41 +01:00
2025-02-07 03:34:27 +01:00
2020-12-30 11:26:01 +01:00
2023-03-22 13:27:11 +01:00
2021-05-22 10:59:31 +02:00
2022-07-29 17:10:37 +02:00
2023-05-17 11:13:27 +02:00
2025-07-17 10:07:54 +02:00
2021-03-30 14:36:58 +02:00
2020-09-09 19:04:29 +02:00
2024-02-23 08:12:39 +01:00
2021-03-24 11:07:34 +01:00
2025-03-11 08:35:00 +01:00
2025-02-07 03:34:21 +01:00
2022-03-16 13:20:27 +01:00
2023-08-30 16:31:49 +02:00
2020-10-07 08:00:05 +02:00
2022-03-16 13:20:27 +01:00
2020-04-29 16:31:27 +02:00
2019-07-14 08:11:21 +02:00
2023-05-17 11:13:15 +02:00
2020-04-02 15:28:23 +02:00
2021-12-14 10:18:06 +01:00
2023-08-11 11:45:17 +02:00
2020-08-11 15:32:34 +02:00
2021-03-07 12:19:01 +01:00