Kuniyuki Iwashima
bd46333993
atm: atmtcp: Prevent arbitrary write in atmtcp_recv_control().
[ Upstream commit ec79003c5f9d2c7f9576fc69b8dbda80305cbe3a ]
syzbot reported the splat below. [0]
When atmtcp_v_open() or atmtcp_v_close() is called via connect()
or close(), atmtcp_send_control() is called to send an in-kernel
special message.
The message has ATMTCP_HDR_MAGIC in atmtcp_control.hdr.length.
Also, a pointer of struct atm_vcc is set to atmtcp_control.vcc.
The notable thing is struct atmtcp_control is uAPI but has a
space for an in-kernel pointer.
struct atmtcp_control {
struct atmtcp_hdr hdr; /* must be first */
...
atm_kptr_t vcc; /* both directions */
...
} __ATM_API_ALIGN;
typedef struct { unsigned char _[8]; } __ATM_API_ALIGN atm_kptr_t;
The special message is processed in atmtcp_recv_control() called
from atmtcp_c_send().
atmtcp_c_send() is vcc->dev->ops->send() and called from 2 paths:
1. .ndo_start_xmit() (vcc->send() == atm_send_aal0())
2. vcc_sendmsg()
The problem is sendmsg() does not validate the message length and
userspace can abuse atmtcp_recv_control() to overwrite any kptr
by atmtcp_control.
Let's add a new ->pre_send() hook to validate messages from sendmsg().
[0]:
Oops: general protection fault, probably for non-canonical address 0xdffffc00200000ab: 0000 [#1] SMP KASAN PTI
KASAN: probably user-memory-access in range [0x0000000100000558-0x000000010000055f]
CPU: 0 UID: 0 PID: 5865 Comm: syz-executor331 Not tainted 6.17.0-rc1-syzkaller-00215-gbab3ce404553 #0 PREEMPT(full)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
RIP: 0010:atmtcp_recv_control drivers/atm/atmtcp.c:93 [inline]
RIP: 0010:atmtcp_c_send+0x1da/0x950 drivers/atm/atmtcp.c:297
Code: 4d 8d 75 1a 4c 89 f0 48 c1 e8 03 42 0f b6 04 20 84 c0 0f 85 15 06 00 00 41 0f b7 1e 4d 8d b7 60 05 00 00 4c 89 f0 48 c1 e8 03 <42> 0f b6 04 20 84 c0 0f 85 13 06 00 00 66 41 89 1e 4d 8d 75 1c 4c
RSP: 0018:ffffc90003f5f810 EFLAGS: 00010203
RAX: 00000000200000ab RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff88802a510000 RSI: 00000000ffffffff RDI: ffff888030a6068c
RBP: ffff88802699fb40 R08: ffff888030a606eb R09: 1ffff1100614c0dd
R10: dffffc0000000000 R11: ffffffff8718fc40 R12: dffffc0000000000
R13: ffff888030a60680 R14: 000000010000055f R15: 00000000ffffffff
FS: 00007f8d7e9236c0(0000) GS:ffff888125c1c000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000045ad50 CR3: 0000000075bde000 CR4: 00000000003526f0
Call Trace:
<TASK>
vcc_sendmsg+0xa10/0xc60 net/atm/common.c:645
sock_sendmsg_nosec net/socket.c:714 [inline]
__sock_sendmsg+0x219/0x270 net/socket.c:729
____sys_sendmsg+0x505/0x830 net/socket.c:2614
___sys_sendmsg+0x21f/0x2a0 net/socket.c:2668
__sys_sendmsg net/socket.c:2700 [inline]
__do_sys_sendmsg net/socket.c:2705 [inline]
__se_sys_sendmsg net/socket.c:2703 [inline]
__x64_sys_sendmsg+0x19b/0x260 net/socket.c:2703
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f8d7e96a4a9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8d7e923198 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f8d7e9f4308 RCX: 00007f8d7e96a4a9
RDX: 0000000000000000 RSI: 0000200000000240 RDI: 0000000000000005
RBP: 00007f8d7e9f4300 R08: 65732f636f72702f R09: 65732f636f72702f
R10: 65732f636f72702f R11: 0000000000000246 R12: 00007f8d7e9c10ac
R13: 00007f8d7e9231a0 R14: 0000200000000200 R15: 0000200000000250
</TASK>
Modules linked in:
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Reported-by: syzbot+1741b56d54536f4ec349@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/68a6767c.050a0220.3d78fd.0011.GAE@google.com/
Tested-by: syzbot+1741b56d54536f4ec349@syzkaller.appspotmail.com
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20250821021901.2814721-1-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Ulrich Hecht <uli@kernel.org>
2025-09-22 10:17:52 +02:00
..
2019-01-22 21:40:33 +01:00
2020-04-02 15:28:16 +02:00
2022-08-25 11:15:23 +02:00
2022-09-15 12:17:02 +02:00
2025-09-16 13:55:20 +02:00
2018-06-15 18:10:01 -03:00
2018-06-15 18:10:01 -03:00
2013-03-12 13:59:14 -07:00
2025-09-22 10:17:52 +02:00
2012-03-16 10:38:24 -04:00
2017-11-07 10:32:44 +01:00
2025-06-11 10:19:25 +02:00
2024-09-04 13:12:59 +02:00
2023-06-09 10:23:56 +02:00
2022-11-10 17:46:56 +01:00
2024-12-05 10:59:42 +01:00
2018-05-29 13:00:25 -06:00
2022-09-15 12:17:02 +02:00
2019-10-05 13:09:54 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-04 15:13:29 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-08 17:30:45 +01:00
2017-11-02 11:10:55 +01:00
2021-05-26 11:48:35 +02:00
2021-11-26 11:36:02 +01:00
2017-11-02 11:10:55 +01:00
2018-04-11 10:28:38 -07:00
2013-12-29 15:25:48 +01:00
2017-11-02 11:10:55 +01:00
2013-09-13 15:09:52 +02:00
2023-08-08 19:49:17 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2023-05-17 11:13:06 +02:00
2017-11-02 11:10:55 +01:00
2017-10-26 17:08:40 +09:00
2018-05-08 13:02:42 +02:00
2025-09-16 13:55:07 +02:00
2024-02-23 08:12:53 +01:00
2018-03-16 19:58:27 +01:00
2017-11-02 11:10:55 +01:00
2022-10-26 13:19:31 +02:00
2017-11-15 11:56:19 -08:00
2020-06-25 15:33:02 +02:00
2015-12-11 11:05:57 -08:00
2017-11-02 11:10:55 +01:00
2018-01-12 17:33:38 -08:00
2017-11-02 11:10:55 +01:00
2018-01-01 12:40:27 -07:00
2024-05-17 11:42:37 +02:00
2018-08-25 13:40:38 -07:00
2017-11-02 11:10:55 +01:00
2018-01-30 21:54:32 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-13 01:41:20 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-12-05 09:21:03 +01:00
2018-02-06 18:32:46 -08:00
2017-11-02 11:10:55 +01:00
2019-02-12 19:47:24 +01:00
2025-07-17 10:08:05 +02:00
2024-02-23 08:12:55 +01:00
2025-02-07 03:34:27 +01:00
2018-03-08 12:30:37 +01:00
2012-10-13 10:46:48 +01:00
2019-08-09 17:52:34 +02:00
2025-09-16 13:55:16 +02:00
2023-03-11 16:31:51 +01:00
2021-08-26 08:36:39 -04:00
2018-07-21 10:43:12 -05:00
2018-08-22 10:52:47 -07:00
2014-05-14 16:40:04 -07:00
2017-10-19 16:54:49 -07:00
2012-12-09 00:20:28 -05:00
2017-11-02 11:10:55 +01:00
2023-03-11 16:31:35 +01:00
2017-11-02 11:10:55 +01:00
2023-02-06 07:49:46 +01:00
2017-11-02 11:10:55 +01:00
2012-07-21 10:34:00 -07:00
2017-11-02 11:10:55 +01:00
2018-08-18 11:44:53 -07:00
2021-02-07 14:48:38 +01:00
2017-12-11 13:17:22 -05:00
2018-04-17 13:42:48 +02:00
2022-06-14 16:59:25 +02:00
2018-12-29 13:37:59 +01:00
2023-01-18 11:30:49 +01:00
2017-01-04 13:22:38 -07:00
2021-09-22 11:48:12 +02:00
2020-01-29 16:43:27 +01:00
2019-12-31 16:35:38 +01:00
2018-02-13 16:25:06 +01:00
2022-12-08 11:18:34 +01:00
2022-11-23 07:53:44 +01:00
2021-05-22 10:59:23 +02:00
2017-11-02 11:10:55 +01:00
2024-06-16 13:23:35 +02:00
2017-11-02 11:10:55 +01:00
2018-03-24 11:25:35 -05:00
2022-05-18 09:42:47 +02:00
2025-09-22 10:17:51 +02:00
2020-10-07 08:00:08 +02:00
2015-09-07 15:17:08 -04:00
2018-07-10 17:22:35 +02:00
2018-05-14 18:09:40 +01:00
2018-07-08 11:13:25 +09:00
2021-08-08 08:54:30 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-09 10:23:28 +01:00
2018-07-23 17:04:13 -05:00
2025-04-04 11:11:27 +02:00
2025-09-16 13:55:19 +02:00
2020-02-11 04:34:11 -08:00
2018-08-22 10:52:45 -07:00
2020-01-27 14:50:26 +01:00
2025-09-16 13:55:10 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-06-30 08:48:19 -04:00
2017-11-02 11:10:55 +01:00
2023-08-30 16:31:56 +02:00
2023-02-25 11:51:50 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-06-08 18:52:26 -07:00
2019-12-05 09:19:38 +01:00
2017-11-27 09:16:40 +01:00
2018-06-15 13:37:07 +02:00
2024-09-12 11:02:55 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2024-02-23 08:12:58 +01:00
2020-12-30 11:26:01 +01:00
2018-04-11 10:28:36 -07:00
2020-10-01 13:14:30 +02:00
2018-02-01 09:46:00 -08:00
2020-06-22 09:05:03 +02:00
2018-05-17 12:46:54 -04:00
2025-09-16 13:55:16 +02:00
2021-06-30 08:48:18 -04:00
2017-01-12 09:33:39 +01:00
2018-07-26 10:50:16 -04:00
2018-05-30 10:11:34 +02:00
2016-03-25 16:37:42 -07:00
2018-06-14 12:21:18 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2023-05-30 12:42:13 +01:00
2024-05-25 16:16:19 +02:00
2018-04-28 15:01:14 -07:00
2009-04-10 15:48:52 +02:00
2020-01-27 14:50:22 +01:00
2017-11-02 11:10:55 +01:00
2023-02-06 07:49:44 +01:00
2017-08-17 16:29:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2024-04-13 12:50:03 +02:00
2017-11-02 11:10:55 +01:00
2023-01-18 11:30:05 +01:00
2017-11-02 11:10:55 +01:00
2025-02-07 03:34:27 +01:00
2018-07-09 09:07:54 -06:00
2017-11-04 11:48:02 +01:00
2019-04-17 08:38:52 +02:00
2020-04-29 16:31:27 +02:00
2023-05-17 11:13:15 +02:00
2021-12-14 10:18:06 +01:00
2023-08-11 11:45:17 +02:00
2017-11-21 15:46:44 -08:00
2018-04-11 10:28:39 -07:00
2021-03-07 12:19:01 +01:00