mirror of
https://github.com/i3/i3.git
synced 2026-08-18 02:52:38 +00:00
This PR is a pure linting and code cleanup effort with no functional
changes, focusing on improving code quality and consistency.
The bulk of the changes involve:
* Code Formatting: The entire codebase was reformatted after updating
our `clang-format` version.
* Compiler Warnings: Addressed `-Wsuggest-attribute` warnings from GCC
by applying `pure`, `const`, and `format` attributes where appropriate.
This helps the compiler with optimizations and bug detection.
* Code Modernization:
* Variable declarations were moved closer to their first use or into
tighter scopes.
* `memset` calls were replaced with C99 zero-initializers (`= {0}`).
* Redundant `struct` keywords, unnecessary type casts, and some
superfluous `return` statements were removed.
* CI Adjustments: The GitHub Actions workflow was updated to correctly
apply compiler flags for both GCC and Clang.
208 lines
6.6 KiB
C
208 lines
6.6 KiB
C
/*
|
||
* vim:ts=4:sw=4:expandtab
|
||
*
|
||
* i3 - an improved tiling window manager
|
||
* © 2009 Michael Stapelberg and contributors (see also: LICENSE)
|
||
*
|
||
* display_version.c: displays the running i3 version, runs as part of
|
||
* i3 --moreversion.
|
||
*
|
||
*/
|
||
#include "all.h"
|
||
|
||
#include <fcntl.h>
|
||
#include <time.h>
|
||
#include <unistd.h>
|
||
|
||
static bool human_readable_key;
|
||
static bool loaded_config_file_name_key;
|
||
static bool included_config_file_names;
|
||
|
||
static char *human_readable_version;
|
||
static char *loaded_config_file_name;
|
||
|
||
static int version_string(void *ctx, const unsigned char *val, size_t len) {
|
||
if (human_readable_key) {
|
||
sasprintf(&human_readable_version, "%.*s", (int)len, val);
|
||
}
|
||
if (loaded_config_file_name_key) {
|
||
sasprintf(&loaded_config_file_name, "%.*s", (int)len, val);
|
||
}
|
||
if (included_config_file_names) {
|
||
IncludedFile *file = scalloc(1, sizeof(IncludedFile));
|
||
sasprintf(&(file->path), "%.*s", (int)len, val);
|
||
TAILQ_INSERT_TAIL(&included_files, file, files);
|
||
}
|
||
return 1;
|
||
}
|
||
|
||
static int version_map_key(void *ctx, const unsigned char *stringval, size_t stringlen) {
|
||
#define KEY_MATCHES(x) (stringlen == strlen(x) && strncmp((const char *)stringval, x, strlen(x)) == 0)
|
||
human_readable_key = KEY_MATCHES("human_readable");
|
||
loaded_config_file_name_key = KEY_MATCHES("loaded_config_file_name");
|
||
included_config_file_names = KEY_MATCHES("included_config_file_names");
|
||
#undef KEY_MATCHES
|
||
return 1;
|
||
}
|
||
|
||
static yajl_callbacks version_callbacks = {
|
||
.yajl_string = version_string,
|
||
.yajl_map_key = version_map_key,
|
||
};
|
||
|
||
static void print_config_path(const char *path, const char *role) {
|
||
struct stat sb;
|
||
time_t now;
|
||
char mtime[64];
|
||
|
||
printf(" %s (%s)", path, role);
|
||
if (stat(path, &sb) == -1) {
|
||
printf("\n");
|
||
ELOG("Cannot stat config file \"%s\"\n", path);
|
||
} else {
|
||
strftime(mtime, sizeof(mtime), "%c", localtime(&(sb.st_mtime)));
|
||
time(&now);
|
||
printf(" (last modified: %s, %.f seconds ago)\n", mtime, difftime(now, sb.st_mtime));
|
||
}
|
||
}
|
||
|
||
/*
|
||
* Connects to i3 to find out the currently running version. Useful since it
|
||
* might be different from the version compiled into this binary (maybe the
|
||
* user didn’t correctly install i3 or forgot to restart it).
|
||
*
|
||
* The output looks like this:
|
||
* Running i3 version: 4.2-202-gb8e782c (2012-08-12, branch "next") (pid 14804)
|
||
*
|
||
* The i3 binary you just called: /home/michael/i3/i3
|
||
* The i3 binary you are running: /home/michael/i3/i3
|
||
*
|
||
*/
|
||
void display_running_version(void) {
|
||
if (getenv("DISPLAY") == NULL) {
|
||
fprintf(stderr, "\nYour DISPLAY environment variable is not set.\n");
|
||
fprintf(stderr, "Are you running i3 via SSH or on a virtual console?\n");
|
||
fprintf(stderr, "Try DISPLAY=:0 i3 --moreversion\n");
|
||
exit(EXIT_FAILURE);
|
||
}
|
||
|
||
char *pid_from_atom = root_atom_contents("I3_PID", conn, conn_screen);
|
||
if (pid_from_atom == NULL) {
|
||
/* If I3_PID is not set, the running version is older than 4.2-200. */
|
||
printf("\nRunning version: < 4.2-200\n");
|
||
exit(EXIT_SUCCESS);
|
||
}
|
||
|
||
/* Inform the user of what we are doing. While a single IPC request is
|
||
* really fast normally, in case i3 hangs, this will not terminate. */
|
||
printf("(Getting version from running i3, press ctrl-c to abort…)");
|
||
fflush(stdout);
|
||
|
||
int sockfd = ipc_connect(NULL);
|
||
if (ipc_send_message(sockfd, 0, I3_IPC_MESSAGE_TYPE_GET_VERSION,
|
||
(uint8_t *)"") == -1) {
|
||
err(EXIT_FAILURE, "IPC: write()");
|
||
}
|
||
|
||
uint32_t reply_length;
|
||
uint32_t reply_type;
|
||
uint8_t *reply;
|
||
int ret;
|
||
if ((ret = ipc_recv_message(sockfd, &reply_type, &reply_length, &reply)) != 0) {
|
||
if (ret == -1) {
|
||
err(EXIT_FAILURE, "IPC: read()");
|
||
}
|
||
exit(EXIT_FAILURE);
|
||
}
|
||
|
||
if (reply_type != I3_IPC_MESSAGE_TYPE_GET_VERSION) {
|
||
errx(EXIT_FAILURE, "Got reply type %d, but expected %d (GET_VERSION)", reply_type, I3_IPC_MESSAGE_TYPE_GET_VERSION);
|
||
}
|
||
|
||
yajl_handle handle = yajl_alloc(&version_callbacks, NULL, NULL);
|
||
|
||
yajl_status state = yajl_parse(handle, reply, (int)reply_length);
|
||
if (state != yajl_status_ok) {
|
||
errx(EXIT_FAILURE, "Could not parse my own reply. That's weird. reply is %.*s", (int)reply_length, reply);
|
||
}
|
||
|
||
printf("\r\x1b[K");
|
||
printf("Running i3 version: %s (pid %s)\n", human_readable_version, pid_from_atom);
|
||
|
||
if (loaded_config_file_name) {
|
||
printf("Loaded i3 config:\n");
|
||
print_config_path(loaded_config_file_name, "main");
|
||
IncludedFile *file;
|
||
TAILQ_FOREACH (file, &included_files, files) {
|
||
print_config_path(file->path, "included");
|
||
}
|
||
}
|
||
|
||
#ifdef __linux__
|
||
size_t destpath_size = 1024;
|
||
ssize_t linksize;
|
||
char *exepath;
|
||
char *destpath = smalloc(destpath_size);
|
||
|
||
sasprintf(&exepath, "/proc/%d/exe", getpid());
|
||
|
||
while ((linksize = readlink(exepath, destpath, destpath_size)) == (ssize_t)destpath_size) {
|
||
destpath_size = destpath_size * 2;
|
||
destpath = srealloc(destpath, destpath_size);
|
||
}
|
||
if (linksize == -1) {
|
||
err(EXIT_FAILURE, "readlink(%s)", exepath);
|
||
}
|
||
|
||
/* readlink() does not NULL-terminate strings, so we have to. */
|
||
destpath[linksize] = '\0';
|
||
|
||
printf("\n");
|
||
printf("The i3 binary you just called: %s\n", destpath);
|
||
|
||
free(exepath);
|
||
sasprintf(&exepath, "/proc/%s/exe", pid_from_atom);
|
||
|
||
while ((linksize = readlink(exepath, destpath, destpath_size)) == (ssize_t)destpath_size) {
|
||
destpath_size = destpath_size * 2;
|
||
destpath = srealloc(destpath, destpath_size);
|
||
}
|
||
if (linksize == -1) {
|
||
err(EXIT_FAILURE, "readlink(%s)", exepath);
|
||
}
|
||
|
||
/* readlink() does not NULL-terminate strings, so we have to. */
|
||
destpath[linksize] = '\0';
|
||
|
||
/* Check if "(deleted)" is the readlink result. If so, the running version
|
||
* does not match the file on disk. */
|
||
if (strstr(destpath, "(deleted)") != NULL) {
|
||
printf("RUNNING BINARY DIFFERENT FROM BINARY ON DISK!\n");
|
||
}
|
||
|
||
/* Since readlink() might put a "(deleted)" somewhere in the buffer and
|
||
* stripping that out seems hackish and ugly, we read the process’s argv[0]
|
||
* instead. */
|
||
free(exepath);
|
||
sasprintf(&exepath, "/proc/%s/cmdline", pid_from_atom);
|
||
|
||
int fd;
|
||
if ((fd = open(exepath, O_RDONLY)) == -1) {
|
||
err(EXIT_FAILURE, "open(%s)", exepath);
|
||
}
|
||
if (read(fd, destpath, sizeof(destpath)) == -1) {
|
||
err(EXIT_FAILURE, "read(%s)", exepath);
|
||
}
|
||
close(fd);
|
||
|
||
printf("The i3 binary you are running: %s\n", destpath);
|
||
|
||
free(exepath);
|
||
free(destpath);
|
||
#endif
|
||
|
||
yajl_free(handle);
|
||
free(reply);
|
||
free(pid_from_atom);
|
||
}
|