mirror/littlefs
3
0
Fork 0
mirror of https://github.com/littlefs-project/littlefs.git synced 2025-12-01 12:20:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed race condition killing test processes in test/bench.py

Browse Source 
Note sure why we weren't hitting this earlier, but I've been hitting
this race condition a bunch recently and it's annoying.

Now every failed process kills the other test processes unconditionally.

It's not clear if this actually _fixes_ the race condition or just makes
it less likely, but it's good enough to keep the test script user
friendly.
This commit is contained in:
Christopher Haster
2023-12-16 14:57:13 -06:00
parent efb1ea0472
commit 161cd9e6da
2 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
scripts/bench.py
View File

@ -1134,14 +1134,13 @@ def run_stage(name, runner, bench_ids, stdout_, trace_, output_, **args):
except BenchFailure as failure: except BenchFailure as failure:
# race condition for multiple failures? # race condition for multiple failures?
if failures and not args.get('keep_going'): if not failures or args.get('keep_going'):
break
# keep track of how many failed # keep track of how many failed
failed_perms += 1 failed_perms += 1
# do not store more failures than we need to, otherwise we # do not store more failures than we need to, otherwise
# quickly explode RAM when a common bug fails a bunch of cases # we quickly explode RAM when a common bug fails a bunch
# of cases
if len(failures) < args.get('failures', 3): if len(failures) < args.get('failures', 3):
failures.append(failure) failures.append(failure)

9
scripts/test.py
View File

@ -1113,14 +1113,13 @@ def run_stage(name, runner, test_ids, stdout_, trace_, output_, **args):
**defines}) **defines})
# race condition for multiple failures? # race condition for multiple failures?
if failures and not args.get('keep_going'): if not failures or args.get('keep_going'):
break
# keep track of how many failed # keep track of how many failed
failed_perms += 1 failed_perms += 1
# do not store more failures than we need to, otherwise we # do not store more failures than we need to, otherwise
# quickly explode RAM when a common bug fails a bunch of cases # we quickly explode RAM when a common bug fails a bunch
# of cases
if len(failures) < args.get('failures', 3): if len(failures) < args.get('failures', 3):
failures.append(failure) failures.append(failure)