mirror/mcMMO
3
0
Fork 0
mirror of https://github.com/mcMMO-Dev/mcMMO.git synced 2026-08-18 11:26:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Impale damage formula: use rank * multiplier instead of (rank - 1) * multiplier

Browse Source
This commit is contained in:
nossr50
2026-05-25 10:14:42 -07:00
parent c838a69e7e
commit 71868d9d2e
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/com/gmail/nossr50/skills/tridents/TridentsManager.java
View File

@ -17,8 +17,7 @@ public class TridentsManager extends SkillManager {
if (rank > 0) {
return mcMMO.p.getAdvancedConfig().getImpaleBaseDamage()
+ ((rank - 1)
* mcMMO.p.getAdvancedConfig().getImpaleRankDamageMultiplier());
+ (rank * mcMMO.p.getAdvancedConfig().getImpaleRankDamageMultiplier());
}
return 0.0D;

3
src/test/java/com/gmail/nossr50/skills/tridents/TridentsTest.java
View File

@ -73,6 +73,7 @@ class TridentsTest extends MMOTestEnvironment {
Mockito.when(RankUtils.getRank(any(Player.class),
Mockito.eq(SubSkillType.TRIDENTS_IMPALE))).thenReturn(4);
assertEquals(2.5D, tridentsManager.impaleDamageBonus());
// base + rank * multiplier: 1.0 + 4 * 0.5 = 3.0
assertEquals(3.0D, tridentsManager.impaleDamageBonus());
}
}