mirror/polybar
3
0
Fork 0
mirror of https://github.com/polybar/polybar.git synced 2026-02-13 08:55:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

script: Fix concurrency issues (#2518)

Browse Source 
Fixes #1978

* Move tail and non-tail handler to method

Defining them in the constructor is ugly.

* script: Iterate over defined actions instead of fixed list

* Separate running logic and lock m_output

* Include POLYBAR_FLAGS in linker flags

* Stop using m_prev in script_runner

* Join module threads in stop function

Joining in the destructor may lead to UB because the subclass is already
deconstructed but the threads may still require it to be around (e.g.
for calling any functions on the instance)

* Cleanup script module

* Update changelog

* Remove AfterReturn class

* Remove m_stopping from script module

* Fix polybar not reading the entire line from child process.

For every `readline` call we created a new fd_streambuf. This means once
`readline` returns, the streambuf is destructed and and pending data in
its temporary buffer discarded and we never actually read it.

* Remove unused includes
This commit is contained in:
Patrick Ziegler
2021-10-03 01:27:11 +02:00
committed by GitHub
parent 4f8f076714
commit 444120e664
16 changed files with 316 additions and 289 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit_tests/utils/command.cpp
View File

@ -1,8 +1,9 @@
#include "utils/command.hpp"
#include "common/test.hpp"
#include <unistd.h>
#include "common/test.hpp"
using namespace polybar;
TEST(Command, status) {
@ -44,14 +45,3 @@ TEST(Command, output) {
EXPECT_EQ(str, "polybar");
}
TEST(Command, readline) {
auto cmd = command_util::make_command<output_policy::REDIRECTED>("read text;echo $text");
string str;
cmd->exec(false);
cmd->writeline("polybar");
cmd->tail([&str](string&& string) { str = string; });
EXPECT_EQ(str, "polybar");
}