diff --git a/app/Helpers/Helper.php b/app/Helpers/Helper.php index bd4b137590..44db9b2035 100644 --- a/app/Helpers/Helper.php +++ b/app/Helpers/Helper.php @@ -281,9 +281,9 @@ class Helper */ public static function checkLowInventory() { - $consumables = Consumable::withCount('consumableAssignments')->whereNotNull('min_amt')->get(); - $accessories = Accessory::withCount('users')->whereNotNull('min_amt')->get(); - $components = Component::withCount('assets')->whereNotNull('min_amt')->get(); + $consumables = Consumable::withCount('consumableAssignments as consumableAssignments_count')->whereNotNull('min_amt')->get(); + $accessories = Accessory::withCount('users as users_count')->whereNotNull('min_amt')->get(); + $components = Component::withCount('assets as assets_count')->whereNotNull('min_amt')->get(); $avail_consumables = 0; $items_array = array(); diff --git a/app/Http/Controllers/Api/AssetModelsController.php b/app/Http/Controllers/Api/AssetModelsController.php index 964695061d..de68cd8a9b 100644 --- a/app/Http/Controllers/Api/AssetModelsController.php +++ b/app/Http/Controllers/Api/AssetModelsController.php @@ -48,7 +48,7 @@ class AssetModelsController extends Controller 'models.updated_at', ]) ->with('category','depreciation', 'manufacturer','fieldset') - ->withCount('assets'); + ->withCount('assets as assets_count'); @@ -114,7 +114,7 @@ class AssetModelsController extends Controller public function show($id) { $this->authorize('view', AssetModel::class); - $assetmodel = AssetModel::withCount('assets')->findOrFail($id); + $assetmodel = AssetModel::withCount('assets as assets_count')->findOrFail($id); return (new AssetModelsTransformer)->transformAssetModel($assetmodel); } diff --git a/app/Http/Controllers/Api/AssetsController.php b/app/Http/Controllers/Api/AssetsController.php index 8bb9b900e1..7e5212c754 100644 --- a/app/Http/Controllers/Api/AssetsController.php +++ b/app/Http/Controllers/Api/AssetsController.php @@ -341,7 +341,7 @@ class AssetsController extends Controller */ public function show($id) { - if ($asset = Asset::with('assetstatus')->with('assignedTo')->withTrashed()->withCount('checkins', 'checkouts', 'userRequests')->findOrFail($id)) { + if ($asset = Asset::with('assetstatus')->with('assignedTo')->withTrashed()->withCount('checkins as checkins_count', 'checkouts as checkouts_count', 'userRequests as userRequests_count')->findOrFail($id)) { $this->authorize('view', $asset); return (new AssetsTransformer)->transformAsset($asset); } diff --git a/app/Http/Controllers/Api/CategoriesController.php b/app/Http/Controllers/Api/CategoriesController.php index c42dc7ebf0..c210c4b942 100644 --- a/app/Http/Controllers/Api/CategoriesController.php +++ b/app/Http/Controllers/Api/CategoriesController.php @@ -24,7 +24,7 @@ class CategoriesController extends Controller $allowed_columns = ['id', 'name','category_type', 'category_type','use_default_eula','eula_text', 'require_acceptance','checkin_email', 'assets_count', 'accessories_count', 'consumables_count', 'components_count','licenses_count', 'image']; $categories = Category::select(['id', 'created_at', 'updated_at', 'name','category_type','use_default_eula','eula_text', 'require_acceptance','checkin_email','image']) - ->withCount('assets', 'accessories', 'consumables', 'components','licenses'); + ->withCount('assets as assets_count', 'accessories as accessories_count', 'consumables as consumables_count', 'components as components_count','licenses as licenses_count'); if ($request->has('search')) { $categories = $categories->TextSearch($request->input('search')); diff --git a/app/Http/Controllers/Api/CompaniesController.php b/app/Http/Controllers/Api/CompaniesController.php index e5264d8e6b..40735fd093 100644 --- a/app/Http/Controllers/Api/CompaniesController.php +++ b/app/Http/Controllers/Api/CompaniesController.php @@ -35,7 +35,7 @@ class CompaniesController extends Controller 'components_count', ]; - $companies = Company::withCount('assets','licenses','accessories','consumables','components','users'); + $companies = Company::withCount('assets as assets_count','licenses as licenses_count','accessories as accessories_count','consumables as consumables_count','components as components_count','users as users_count'); if ($request->has('search')) { $companies->TextSearch($request->input('search')); diff --git a/app/Http/Controllers/Api/CustomFieldsetsController.php b/app/Http/Controllers/Api/CustomFieldsetsController.php index 3946be433c..f5cfafdf93 100644 --- a/app/Http/Controllers/Api/CustomFieldsetsController.php +++ b/app/Http/Controllers/Api/CustomFieldsetsController.php @@ -43,7 +43,7 @@ class CustomFieldsetsController extends Controller public function index() { $this->authorize('index', CustomFieldset::class); - $fieldsets = CustomFieldset::withCount(['fields', 'models'])->get(); + $fieldsets = CustomFieldset::withCount('fields as fields_count', 'models as models_count')->get(); return (new CustomFieldsetsTransformer)->transformCustomFieldsets($fieldsets, $fieldsets->count()); } diff --git a/app/Http/Controllers/Api/DepartmentsController.php b/app/Http/Controllers/Api/DepartmentsController.php index a6fa3155aa..44d0273ef0 100644 --- a/app/Http/Controllers/Api/DepartmentsController.php +++ b/app/Http/Controllers/Api/DepartmentsController.php @@ -33,7 +33,7 @@ class DepartmentsController extends Controller 'departments.created_at', 'departments.updated_at', 'departments.image' - ])->with('users')->with('location')->with('manager')->with('company')->withCount('users'); + ])->with('users')->with('location')->with('manager')->with('company')->withCount('users as users_count'); if ($request->has('search')) { $departments = $departments->TextSearch($request->input('search')); diff --git a/app/Http/Controllers/Api/GroupsController.php b/app/Http/Controllers/Api/GroupsController.php index a213c0173f..439dde4a61 100644 --- a/app/Http/Controllers/Api/GroupsController.php +++ b/app/Http/Controllers/Api/GroupsController.php @@ -22,7 +22,7 @@ class GroupsController extends Controller $this->authorize('view', Group::class); $allowed_columns = ['id','name','created_at', 'users_count']; - $groups = Group::select('id','name','permissions','created_at','updated_at')->withCount('users'); + $groups = Group::select('id','name','permissions','created_at','updated_at')->withCount('users as users_count'); if ($request->has('search')) { $groups = $groups->TextSearch($request->input('search')); diff --git a/app/Http/Controllers/Api/LicensesController.php b/app/Http/Controllers/Api/LicensesController.php index 337e8e8691..95760e6e89 100644 --- a/app/Http/Controllers/Api/LicensesController.php +++ b/app/Http/Controllers/Api/LicensesController.php @@ -25,7 +25,7 @@ class LicensesController extends Controller public function index(Request $request) { $this->authorize('view', License::class); - $licenses = Company::scopeCompanyables(License::with('company', 'manufacturer', 'freeSeats', 'supplier','category')->withCount('freeSeats')); + $licenses = Company::scopeCompanyables(License::with('company', 'manufacturer', 'freeSeats', 'supplier','category')->withCount('freeSeats as freeSeats_count')); if ($request->has('company_id')) { diff --git a/app/Http/Controllers/Api/LocationsController.php b/app/Http/Controllers/Api/LocationsController.php index f448dd1678..4b54068228 100644 --- a/app/Http/Controllers/Api/LocationsController.php +++ b/app/Http/Controllers/Api/LocationsController.php @@ -41,9 +41,9 @@ class LocationsController extends Controller 'locations.updated_at', 'locations.image', 'locations.currency' - ])->withCount('assignedAssets') - ->withCount('assets') - ->withCount('users'); + ])->withCount('assignedAssets as assignedAssets_count') + ->withCount('assets as assets_count') + ->withCount('users as users_count'); if ($request->has('search')) { $locations = $locations->TextSearch($request->input('search')); @@ -123,9 +123,9 @@ class LocationsController extends Controller 'locations.image', 'locations.currency' ]) - ->withCount('assignedAssets') - ->withCount('assets') - ->withCount('users')->findOrFail($id); + ->withCount('assignedAssets as assignedAssets_count') + ->withCount('assets as assets_count') + ->withCount('users as users_count')->findOrFail($id); return (new LocationsTransformer)->transformLocation($location); } diff --git a/app/Http/Controllers/Api/ManufacturersController.php b/app/Http/Controllers/Api/ManufacturersController.php index 64f288e49c..d7535d3bb1 100644 --- a/app/Http/Controllers/Api/ManufacturersController.php +++ b/app/Http/Controllers/Api/ManufacturersController.php @@ -26,7 +26,7 @@ class ManufacturersController extends Controller $manufacturers = Manufacturer::select( array('id','name','url','support_url','support_email','support_phone','created_at','updated_at','image', 'deleted_at') - )->withCount('assets')->withCount('licenses')->withCount('consumables')->withCount('accessories'); + )->withCount('assets as assets_count')->withCount('licenses as licenses_count')->withCount('consumables as consumables_count')->withCount('accessories as accessories_count'); if ($request->input('deleted')=='true') { $manufacturers->onlyTrashed(); @@ -83,7 +83,7 @@ class ManufacturersController extends Controller public function show($id) { $this->authorize('view', Manufacturer::class); - $manufacturer = Manufacturer::withCount('assets')->withCount('licenses')->withCount('consumables')->withCount('accessories')->findOrFail($id); + $manufacturer = Manufacturer::withCount('assets as assets_count')->withCount('licenses as licenses_count')->withCount('consumables_count')->withCount('accessories as accessories_count')->findOrFail($id); return (new ManufacturersTransformer)->transformManufacturer($manufacturer); } diff --git a/app/Http/Controllers/Api/StatuslabelsController.php b/app/Http/Controllers/Api/StatuslabelsController.php index 6238b5889a..0ba0d82c63 100644 --- a/app/Http/Controllers/Api/StatuslabelsController.php +++ b/app/Http/Controllers/Api/StatuslabelsController.php @@ -24,7 +24,7 @@ class StatuslabelsController extends Controller $this->authorize('view', Statuslabel::class); $allowed_columns = ['id','name','created_at', 'assets_count','color','default_label']; - $statuslabels = Statuslabel::withCount('assets'); + $statuslabels = Statuslabel::withCount('assets as assets_count'); if ($request->has('search')) { $statuslabels = $statuslabels->TextSearch($request->input('search')); @@ -162,7 +162,7 @@ class StatuslabelsController extends Controller { $this->authorize('view', Statuslabel::class); - $statuslabels = Statuslabel::with('assets')->groupBy('id')->withCount('assets')->get(); + $statuslabels = Statuslabel::with('assets')->groupBy('id')->withCount('assets as assets_count')->get(); $labels=[]; $points=[]; diff --git a/app/Http/Controllers/Api/SuppliersController.php b/app/Http/Controllers/Api/SuppliersController.php index 08d43517e3..b725c7d443 100644 --- a/app/Http/Controllers/Api/SuppliersController.php +++ b/app/Http/Controllers/Api/SuppliersController.php @@ -26,7 +26,7 @@ class SuppliersController extends Controller $suppliers = Supplier::select( array('id','name','address','address2','city','state','country','fax', 'phone','email','contact','created_at','updated_at','deleted_at','image','notes') - )->withCount('assets')->withCount('licenses')->withCount('accessories'); + )->withCount('assets as assets_count')->withCount('licenses as licenses_count')->withCount('accessories as accessories_count'); if ($request->has('search')) { @@ -115,7 +115,7 @@ class SuppliersController extends Controller public function destroy($id) { $this->authorize('delete', Supplier::class); - $supplier = Supplier::with('asset_maintenances', 'assets', 'licenses')->withCount('asset_maintenances','assets', 'licenses')->findOrFail($id); + $supplier = Supplier::with('asset_maintenances', 'assets', 'licenses')->withCount('asset_maintenances as asset_maintenances_count','assets as assets_count', 'licenses as licenses_count')->findOrFail($id); $this->authorize('delete', $supplier); diff --git a/app/Http/Controllers/Api/UsersController.php b/app/Http/Controllers/Api/UsersController.php index b562ea7e4a..2b1196b093 100644 --- a/app/Http/Controllers/Api/UsersController.php +++ b/app/Http/Controllers/Api/UsersController.php @@ -58,7 +58,7 @@ class UsersController extends Controller 'users.zip', ])->with('manager', 'groups', 'userloc', 'company', 'department','assets','licenses','accessories','consumables') - ->withCount('assets','licenses','accessories','consumables'); + ->withCount('assets as assets_count','licenses as licenses_count','accessories as accessories_count','consumables as consumables_count'); $users = Company::scopeCompanyables($users); diff --git a/app/Http/Controllers/AssetModelsController.php b/app/Http/Controllers/AssetModelsController.php index 169808897f..0999327474 100755 --- a/app/Http/Controllers/AssetModelsController.php +++ b/app/Http/Controllers/AssetModelsController.php @@ -373,7 +373,7 @@ class AssetModelsController extends Controller if ((is_array($models_raw_array)) && (count($models_raw_array) > 0)) { - $models = AssetModel::whereIn('id', $models_raw_array)->withCount('assets')->orderBy('assets_count', 'ASC')->get(); + $models = AssetModel::whereIn('id', $models_raw_array)->withCount('assets as assets_count')->orderBy('assets_count', 'ASC')->get(); // If deleting.... if ($request->input('bulk_actions')=='delete') { @@ -461,7 +461,7 @@ class AssetModelsController extends Controller if ((is_array($models_raw_array)) && (count($models_raw_array) > 0)) { - $models = AssetModel::whereIn('id', $models_raw_array)->withCount('assets')->get(); + $models = AssetModel::whereIn('id', $models_raw_array)->withCount('assets as assets_count')->get(); $del_error_count = 0; $del_count = 0; diff --git a/app/Http/Controllers/Auth/LoginController.php b/app/Http/Controllers/Auth/LoginController.php index 7175e6064c..e13376c9f1 100644 --- a/app/Http/Controllers/Auth/LoginController.php +++ b/app/Http/Controllers/Auth/LoginController.php @@ -193,7 +193,6 @@ class LoginController extends Controller if ($user = Auth::user()) { $user->last_login = \Carbon::now(); - \Log::debug('Last login:'.$user->last_login); $user->save(); } // Redirect to the users page @@ -314,7 +313,7 @@ class LoginController extends Controller return redirect()->away($customLogoutUrl); } - return redirect()->route('login')->with('success', trans('auth/general.logout.success')); + return redirect()->route('login')->with('success', trans('auth/message.logout.success')); } diff --git a/app/Http/Controllers/SuppliersController.php b/app/Http/Controllers/SuppliersController.php index ab3c499bef..df89709f29 100755 --- a/app/Http/Controllers/SuppliersController.php +++ b/app/Http/Controllers/SuppliersController.php @@ -196,7 +196,7 @@ class SuppliersController extends Controller public function destroy($supplierId) { $this->authorize('delete', Supplier::class); - if (is_null($supplier = Supplier::with('asset_maintenances', 'assets', 'licenses')->withCount('asset_maintenances','assets','licenses')->find($supplierId))) { + if (is_null($supplier = Supplier::with('asset_maintenances', 'assets', 'licenses')->withCount('asset_maintenances as asset_maintenances_count','assets as assets_count','licenses as licenses_count')->find($supplierId))) { return redirect()->route('suppliers.index')->with('error', trans('admin/suppliers/message.not_found')); }