From 4fccf4ddc4ae06853ce8feb08618e3c1e0167fd4 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 10 May 2022 12:27:42 -0700 Subject: [PATCH] Few more log lines Signed-off-by: snipe --- app/Http/Controllers/Auth/LoginController.php | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/Auth/LoginController.php b/app/Http/Controllers/Auth/LoginController.php index 44e887f6d6..ee7551c6b1 100644 --- a/app/Http/Controllers/Auth/LoginController.php +++ b/app/Http/Controllers/Auth/LoginController.php @@ -120,7 +120,8 @@ class LoginController extends Controller try { Log::debug("Attempting to log user in by SAML authentication."); $user = $saml->samlLogin($samlData); - if(!is_null($user)) { + + if (!is_null($user)) { Auth::login($user); } else { $username = $saml->getUsername(); @@ -133,11 +134,26 @@ class LoginController extends Controller $user->last_login = \Carbon::now(); $user->save(); } + } catch (\Exception $e) { \Log::warning("There was an error authenticating the SAML user: " . $e->getMessage()); throw new \Exception($e->getMessage()); } + + // Fallthrough with better logging + } else { + + // Better logging + if (!$saml->isEnabled()) { + \Log::warning("SAML page requested, but SAML does not seem to enabled."); + } else { + \Log::warning("SAML page requested, but samlData seems empty."); + } } + + \Log::warning("Something else went wrong while trying to login as SAML user"); + + } /**