diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 85e74f864a..fcd91dfe41 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -84,6 +84,24 @@ parameters: count: 1 path: app/Actions/Manufacturers/DestroyManufacturerAction.php + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$accessories_count\.$#' + identifier: property.notFound + count: 1 + path: app/Actions/Suppliers/DestroySupplierAction.php + + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$components_count\.$#' + identifier: property.notFound + count: 1 + path: app/Actions/Suppliers/DestroySupplierAction.php + + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$consumables_count\.$#' + identifier: property.notFound + count: 1 + path: app/Actions/Suppliers/DestroySupplierAction.php + - message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$asset_tag\.$#' identifier: property.notFound @@ -972,12 +990,36 @@ parameters: count: 1 path: app/Http/Controllers/Accessories/AccessoriesController.php + - + message: '#^Access to an undefined property App\\Models\\Accessory\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Accessories/AccessoriesController.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Accessories/AccessoriesController.php + - message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:getErrors\(\)\.$#' identifier: method.notFound count: 2 path: app/Http/Controllers/Accessories/AccessoriesController.php + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Accessories/AccessoriesController.php + + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:orderItems\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Accessories/AccessoriesController.php + - message: '#^PHPDoc tag @param references unknown parameter\: \$accessoryID$#' identifier: parameter.notFound @@ -1110,6 +1152,12 @@ parameters: count: 1 path: app/Http/Controllers/Api/AccessoriesController.php + - + message: '#^Access to an undefined property App\\Models\\Accessory\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/Api/AccessoriesController.php + - message: '#^Access to an undefined property App\\Models\\AccessoryCheckout\:\:\$created_by\.$#' identifier: property.notFound @@ -1134,6 +1182,18 @@ parameters: count: 1 path: app/Http/Controllers/Api/AccessoriesController.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Api/AccessoriesController.php + + - + message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/AccessoriesController.php + - message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:companies\(\)\.$#' identifier: method.notFound @@ -1146,6 +1206,18 @@ parameters: count: 2 path: app/Http/Controllers/Api/AccessoriesController.php + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/AccessoriesController.php + + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:orderItems\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/AccessoriesController.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:TextSearch\(\)\.$#' identifier: method.notFound @@ -1482,12 +1554,42 @@ parameters: count: 1 path: app/Http/Controllers/Api/ComponentsController.php + - + message: '#^Access to an undefined property App\\Models\\Component\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/Api/ComponentsController.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Api/ComponentsController.php + + - + message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/ComponentsController.php + - message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:getErrors\(\)\.$#' identifier: method.notFound count: 2 path: app/Http/Controllers/Api/ComponentsController.php + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/ComponentsController.php + + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:orderItems\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/ComponentsController.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:attach\(\)\.$#' identifier: method.notFound @@ -1542,12 +1644,42 @@ parameters: count: 1 path: app/Http/Controllers/Api/ConsumablesController.php + - + message: '#^Access to an undefined property App\\Models\\Consumable\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/Api/ConsumablesController.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Api/ConsumablesController.php + + - + message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/ConsumablesController.php + - message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:getErrors\(\)\.$#' identifier: method.notFound count: 2 path: app/Http/Controllers/Api/ConsumablesController.php + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/ConsumablesController.php + + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:orderItems\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Api/ConsumablesController.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:attach\(\)\.$#' identifier: method.notFound @@ -2010,12 +2142,30 @@ parameters: count: 2 path: app/Http/Controllers/Api/StatuslabelsController.php + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$accessories_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/Api/SuppliersController.php + - message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$asset_maintenances_count\.$#' identifier: property.notFound count: 1 path: app/Http/Controllers/Api/SuppliersController.php + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$components_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/Api/SuppliersController.php + + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$consumables_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/Api/SuppliersController.php + - message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$use_image\.$#' identifier: property.notFound @@ -2358,12 +2508,6 @@ parameters: count: 1 path: app/Http/Controllers/Assets/AssetCheckoutController.php - - - message: '#^Access to an undefined property App\\Models\\Asset\:\:\$accessories\.$#' - identifier: property.notFound - count: 1 - path: app/Http/Controllers/Assets/AssetsController.php - - message: '#^Access to an undefined property App\\Models\\Asset\:\:\$asset_eol_date\.$#' identifier: property.notFound @@ -2844,12 +2988,30 @@ parameters: count: 1 path: app/Http/Controllers/BulkStatuslabelsController.php + - + message: '#^Access to an undefined property App\\Models\\Supplier\|Illuminate\\Database\\Eloquent\\Collection\\:\:\$accessories_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/BulkSuppliersController.php + - message: '#^Access to an undefined property App\\Models\\Supplier\|Illuminate\\Database\\Eloquent\\Collection\\:\:\$asset_maintenances_count\.$#' identifier: property.notFound count: 1 path: app/Http/Controllers/BulkSuppliersController.php + - + message: '#^Access to an undefined property App\\Models\\Supplier\|Illuminate\\Database\\Eloquent\\Collection\\:\:\$components_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/BulkSuppliersController.php + + - + message: '#^Access to an undefined property App\\Models\\Supplier\|Illuminate\\Database\\Eloquent\\Collection\\:\:\$consumables_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/BulkSuppliersController.php + - message: '#^Dead catch \- Exception is never thrown in the try block\.$#' identifier: catch.neverThrown @@ -2970,12 +3132,36 @@ parameters: count: 1 path: app/Http/Controllers/Components/ComponentsController.php + - + message: '#^Access to an undefined property App\\Models\\Component\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Components/ComponentsController.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Components/ComponentsController.php + - message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:getErrors\(\)\.$#' identifier: method.notFound count: 2 path: app/Http/Controllers/Components/ComponentsController.php + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Components/ComponentsController.php + + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:orderItems\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Components/ComponentsController.php + - message: '#^PHPDoc tag @param references unknown parameter\: \$componentId$#' identifier: parameter.notFound @@ -3018,12 +3204,36 @@ parameters: count: 2 path: app/Http/Controllers/Consumables/ConsumablesController.php + - + message: '#^Access to an undefined property App\\Models\\Consumable\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Consumables/ConsumablesController.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$id\.$#' + identifier: property.notFound + count: 2 + path: app/Http/Controllers/Consumables/ConsumablesController.php + - message: '#^Call to an undefined method App\\Models\\SnipeModel\:\:getErrors\(\)\.$#' identifier: method.notFound count: 2 path: app/Http/Controllers/Consumables/ConsumablesController.php + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:adjustQuantity\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Consumables/ConsumablesController.php + + - + message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:orderItems\(\)\.$#' + identifier: method.notFound + count: 1 + path: app/Http/Controllers/Consumables/ConsumablesController.php + - message: '#^PHPDoc tag @param for parameter \$request with type App\\Http\\Requests\\ImageUploadRequest is not subtype of native type App\\Http\\Requests\\StoreConsumableRequest\.$#' identifier: parameter.phpDocType @@ -3042,12 +3252,6 @@ parameters: count: 1 path: app/Http/Controllers/Consumables/ConsumablesController.php - - - message: '#^Property App\\Models\\Consumable\:\:\$qty \(int\) does not accept string\.$#' - identifier: assign.propertyType - count: 1 - path: app/Http/Controllers/Consumables/ConsumablesController.php - - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:detach\(\)\.$#' identifier: method.notFound @@ -3954,12 +4158,30 @@ parameters: count: 2 path: app/Http/Controllers/StatuslabelsController.php + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$accessories_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/SuppliersController.php + - message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$asset_maintenances_count\.$#' identifier: property.notFound count: 1 path: app/Http/Controllers/SuppliersController.php + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$components_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/SuppliersController.php + + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$consumables_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Controllers/SuppliersController.php + - message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$created_by\.$#' identifier: property.notFound @@ -4302,6 +4524,12 @@ parameters: count: 1 path: app/Http/Requests/SettingsLdapRequest.php + - + message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$orderItem\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/ActionlogsTransformer.php + - message: '#^Call to function is_array\(\) with array will always evaluate to true\.$#' identifier: function.alreadyNarrowedType @@ -4650,6 +4878,66 @@ parameters: count: 1 path: app/Http/Transformers/ManufacturersTransformer.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$admin\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$currency\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$filename\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$id\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$item_id\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$item_type\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$notes\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$order_number\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$purchase_date\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$supplier\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/OrderItemsTransformer.php + - message: '#^Access to an undefined property App\\Models\\SnipeModel\:\:\$name\.$#' identifier: property.notFound @@ -4662,6 +4950,24 @@ parameters: count: 3 path: app/Http/Transformers/PredefinedKitsTransformer.php + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$accessories_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/SuppliersTransformer.php + + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$components_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/SuppliersTransformer.php + + - + message: '#^Access to an undefined property App\\Models\\Supplier\:\:\$consumables_count\.$#' + identifier: property.notFound + count: 1 + path: app/Http/Transformers/SuppliersTransformer.php + - message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#' identifier: function.alreadyNarrowedType @@ -6048,6 +6354,24 @@ parameters: count: 2 path: app/Mail/UnacceptedAssetReminderMail.php + - + message: '#^Access to an undefined property App\\Models\\Accessory\:\:\$created_by\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Accessory.php + + - + message: '#^Access to an undefined property App\\Models\\Accessory\:\:\$default_purchase_cost\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Accessory.php + + - + message: '#^Access to an undefined property App\\Models\\Accessory\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 2 + path: app/Models/Accessory.php + - message: '#^Access to an undefined property App\\Models\\Accessory\:\:\$license\.$#' identifier: property.notFound @@ -6066,16 +6390,10 @@ parameters: count: 1 path: app/Models/Accessory.php - - - message: '#^Access to an undefined property App\\Models\\Accessory\:\:\$requests\.$#' - identifier: property.notFound - count: 1 - path: app/Models/Accessory.php - - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound - count: 4 + count: 6 path: app/Models/Accessory.php - @@ -6084,12 +6402,42 @@ parameters: count: 2 path: app/Models/Accessory.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$currency\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Accessory.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$order\.$#' + identifier: property.notFound + count: 6 + path: app/Models/Accessory.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$price\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Accessory.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$supplier_id\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Accessory.php + - message: '#^Call to function is_array\(\) with string will always evaluate to false\.$#' identifier: function.impossibleType count: 1 path: app/Models/Accessory.php + - + message: '#^Cannot access property \$id on class\-string\|object\.$#' + identifier: property.nonObject + count: 1 + path: app/Models/Accessory.php + - message: '#^If condition is always false\.$#' identifier: if.alwaysFalse @@ -6186,6 +6534,12 @@ parameters: count: 4 path: app/Models/Accessory.php + - + message: '#^Unsafe usage of new static\(\)\.$#' + identifier: new.static + count: 4 + path: app/Models/Accessory.php + - message: '#^Using nullsafe method call on non\-nullable type Psr\\Http\\Message\\ResponseInterface\. Use \-\> instead\.$#' identifier: nullsafe.neverNull @@ -6198,6 +6552,18 @@ parameters: count: 1 path: app/Models/Accessory.php + - + message: '#^Using nullsafe property access "\?\-\>currency" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' + identifier: nullsafe.neverNull + count: 1 + path: app/Models/Accessory.php + + - + message: '#^Using nullsafe property access "\?\-\>default_currency" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' + identifier: nullsafe.neverNull + count: 1 + path: app/Models/Accessory.php + - message: '#^Call to function is_array\(\) with string will always evaluate to false\.$#' identifier: function.impossibleType @@ -6291,7 +6657,7 @@ parameters: - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound - count: 4 + count: 5 path: app/Models/Asset.php - @@ -6303,6 +6669,24 @@ parameters: - message: '#^Access to an undefined property App\\Models\\Asset\:\:\$company_id\.$#' identifier: property.notFound + count: 3 + path: app/Models/Asset.php + + - + message: '#^Access to an undefined property App\\Models\\Asset\:\:\$created_by\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Asset.php + + - + message: '#^Access to an undefined property App\\Models\\Asset\:\:\$default_purchase_cost\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Asset.php + + - + message: '#^Access to an undefined property App\\Models\\Asset\:\:\$default_supplier_id\.$#' + identifier: property.notFound count: 2 path: app/Models/Asset.php @@ -6348,12 +6732,6 @@ parameters: count: 2 path: app/Models/Asset.php - - - message: '#^Access to an undefined property App\\Models\\Asset\:\:\$requests\.$#' - identifier: property.notFound - count: 1 - path: app/Models/Asset.php - - message: '#^Access to an undefined property App\\Models\\Asset\:\:\$warrantyExpires\.$#' identifier: property.notFound @@ -6372,6 +6750,30 @@ parameters: count: 2 path: app/Models/Asset.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$currency\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Asset.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$order\.$#' + identifier: property.notFound + count: 6 + path: app/Models/Asset.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$price\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Asset.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$supplier_id\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Asset.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:associate\(\)\.$#' identifier: method.notFound @@ -6414,6 +6816,12 @@ parameters: count: 1 path: app/Models/Asset.php + - + message: '#^Cannot access property \$id on class\-string\|object\.$#' + identifier: property.nonObject + count: 1 + path: app/Models/Asset.php + - message: '#^Expression on left side of \?\? is not nullable\.$#' identifier: nullCoalesce.expr @@ -6636,6 +7044,12 @@ parameters: count: 4 path: app/Models/Asset.php + - + message: '#^Unsafe usage of new static\(\)\.$#' + identifier: new.static + count: 4 + path: app/Models/Asset.php + - message: '#^Using nullsafe method call on non\-nullable type Psr\\Http\\Message\\ResponseInterface\. Use \-\> instead\.$#' identifier: nullsafe.neverNull @@ -6648,6 +7062,18 @@ parameters: count: 1 path: app/Models/Asset.php + - + message: '#^Using nullsafe property access "\?\-\>currency" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' + identifier: nullsafe.neverNull + count: 1 + path: app/Models/Asset.php + + - + message: '#^Using nullsafe property access "\?\-\>default_currency" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' + identifier: nullsafe.neverNull + count: 1 + path: app/Models/Asset.php + - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound @@ -6672,12 +7098,6 @@ parameters: count: 1 path: app/Models/AssetModel.php - - - message: '#^Access to an undefined property App\\Models\\AssetModel\:\:\$requests\.$#' - identifier: property.notFound - count: 1 - path: app/Models/AssetModel.php - - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:fields\(\)\.$#' identifier: method.notFound @@ -7185,7 +7605,25 @@ parameters: - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound - count: 4 + count: 6 + path: app/Models/Component.php + + - + message: '#^Access to an undefined property App\\Models\\Component\:\:\$created_by\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Component.php + + - + message: '#^Access to an undefined property App\\Models\\Component\:\:\$default_purchase_cost\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Component.php + + - + message: '#^Access to an undefined property App\\Models\\Component\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 2 path: app/Models/Component.php - @@ -7224,6 +7662,30 @@ parameters: count: 2 path: app/Models/Component.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$currency\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Component.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$order\.$#' + identifier: property.notFound + count: 6 + path: app/Models/Component.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$price\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Component.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$supplier_id\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Component.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:withTrashed\(\)\.$#' identifier: method.notFound @@ -7236,6 +7698,12 @@ parameters: count: 1 path: app/Models/Component.php + - + message: '#^Cannot access property \$id on class\-string\|object\.$#' + identifier: property.nonObject + count: 1 + path: app/Models/Component.php + - message: '#^Expression on left side of \?\? is not nullable\.$#' identifier: nullCoalesce.expr @@ -7296,6 +7764,12 @@ parameters: count: 4 path: app/Models/Component.php + - + message: '#^Unsafe usage of new static\(\)\.$#' + identifier: new.static + count: 4 + path: app/Models/Component.php + - message: '#^Using nullsafe method call on non\-nullable type Psr\\Http\\Message\\ResponseInterface\. Use \-\> instead\.$#' identifier: nullsafe.neverNull @@ -7308,6 +7782,18 @@ parameters: count: 1 path: app/Models/Component.php + - + message: '#^Using nullsafe property access "\?\-\>currency" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' + identifier: nullsafe.neverNull + count: 1 + path: app/Models/Component.php + + - + message: '#^Using nullsafe property access "\?\-\>default_currency" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' + identifier: nullsafe.neverNull + count: 1 + path: app/Models/Component.php + - message: '#^Using nullsafe property access "\?\-\>require_acceptance" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' identifier: nullsafe.neverNull @@ -7335,7 +7821,7 @@ parameters: - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound - count: 4 + count: 6 path: app/Models/Consumable.php - @@ -7344,6 +7830,24 @@ parameters: count: 1 path: app/Models/Consumable.php + - + message: '#^Access to an undefined property App\\Models\\Consumable\:\:\$created_by\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Consumable.php + + - + message: '#^Access to an undefined property App\\Models\\Consumable\:\:\$default_purchase_cost\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Consumable.php + + - + message: '#^Access to an undefined property App\\Models\\Consumable\:\:\$default_supplier_id\.$#' + identifier: property.notFound + count: 2 + path: app/Models/Consumable.php + - message: '#^Access to an undefined property App\\Models\\Consumable\:\:\$license\.$#' identifier: property.notFound @@ -7368,6 +7872,30 @@ parameters: count: 2 path: app/Models/Consumable.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$currency\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Consumable.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$order\.$#' + identifier: property.notFound + count: 6 + path: app/Models/Consumable.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$price\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Consumable.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$supplier_id\.$#' + identifier: property.notFound + count: 1 + path: app/Models/Consumable.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:withTrashed\(\)\.$#' identifier: method.notFound @@ -7380,6 +7908,12 @@ parameters: count: 1 path: app/Models/Consumable.php + - + message: '#^Cannot access property \$id on class\-string\|object\.$#' + identifier: property.nonObject + count: 1 + path: app/Models/Consumable.php + - message: '#^Loose comparison using \=\= between int and '''' will always evaluate to false\.$#' identifier: equal.alwaysFalse @@ -7428,12 +7962,6 @@ parameters: count: 1 path: app/Models/Consumable.php - - - message: '#^Property App\\Models\\Consumable\:\:\$casts \(array\\) does not accept default value of type array\\.$#' - identifier: property.defaultValue - count: 1 - path: app/Models/Consumable.php - - message: '#^Property App\\Models\\Consumable\:\:\$searchableAttributes \(array\) on left side of \?\? is not nullable\.$#' identifier: nullCoalesce.property @@ -7458,6 +7986,12 @@ parameters: count: 4 path: app/Models/Consumable.php + - + message: '#^Unsafe usage of new static\(\)\.$#' + identifier: new.static + count: 4 + path: app/Models/Consumable.php + - message: '#^Using nullsafe method call on non\-nullable type Psr\\Http\\Message\\ResponseInterface\. Use \-\> instead\.$#' identifier: nullsafe.neverNull @@ -7470,6 +8004,18 @@ parameters: count: 1 path: app/Models/Consumable.php + - + message: '#^Using nullsafe property access "\?\-\>currency" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' + identifier: nullsafe.neverNull + count: 1 + path: app/Models/Consumable.php + + - + message: '#^Using nullsafe property access "\?\-\>default_currency" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' + identifier: nullsafe.neverNull + count: 1 + path: app/Models/Consumable.php + - message: '#^Using nullsafe property access "\?\-\>require_acceptance" on left side of \?\? is unnecessary\. Use \-\> instead\.$#' identifier: nullsafe.neverNull @@ -8046,30 +8592,6 @@ parameters: count: 2 path: app/Models/Ldap.php - - - message: '#^Method App\\Models\\Ldap\:\:connectToLdap\(\) has invalid return type App\\Models\\connection\.$#' - identifier: class.notFound - count: 1 - path: app/Models/Ldap.php - - - - message: '#^Method App\\Models\\Ldap\:\:connectToLdap\(\) should return App\\Models\\connection but returns LDAP\\Connection\.$#' - identifier: return.type - count: 1 - path: app/Models/Ldap.php - - - - message: '#^Method App\\Models\\Ldap\:\:findAndBindUserLdap\(\) should return bool but returns array\.$#' - identifier: return.type - count: 1 - path: app/Models/Ldap.php - - - - message: '#^Method App\\Models\\Ldap\:\:findAndBindUserLdap\(\) should return bool but returns array\\.$#' - identifier: return.type - count: 1 - path: app/Models/Ldap.php - - message: '#^Method App\\Models\\Ldap\:\:findLdapUsers\(\) should return array\|bool but returns Illuminate\\Http\\RedirectResponse\.$#' identifier: return.type @@ -8079,7 +8601,7 @@ parameters: - message: '#^PHPDoc tag @param references unknown parameter\: \$user$#' identifier: parameter.notFound - count: 2 + count: 1 path: app/Models/Ldap.php - @@ -8709,7 +9231,7 @@ parameters: - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:companies\(\)\.$#' identifier: method.notFound - count: 2 + count: 4 path: app/Models/SnipeSCIMConfig.php - @@ -8916,6 +9438,12 @@ parameters: count: 2 path: app/Models/User.php + - + message: '#^Access to an undefined property App\\Models\\User\:\:\$consumable_cost\.$#' + identifier: property.notFound + count: 1 + path: app/Models/User.php + - message: '#^Access to an undefined property App\\Models\\User\:\:\$license\.$#' identifier: property.notFound @@ -10281,7 +10809,7 @@ parameters: - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound - count: 3 + count: 2 path: app/Observers/AccessoryObserver.php - @@ -10290,6 +10818,12 @@ parameters: count: 4 path: app/Observers/AssetModelObserver.php + - + message: '#^Access to an undefined property App\\Models\\AssetModel\:\:\$created_by\.$#' + identifier: property.notFound + count: 1 + path: app/Observers/AssetModelObserver.php + - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound @@ -10302,6 +10836,18 @@ parameters: count: 4 path: app/Observers/AssetObserver.php + - + message: '#^Access to an undefined property App\\Models\\Asset\:\:\$company_id\.$#' + identifier: property.notFound + count: 2 + path: app/Observers/AssetObserver.php + + - + message: '#^Access to an undefined property App\\Models\\Asset\:\:\$created_by\.$#' + identifier: property.notFound + count: 1 + path: app/Observers/AssetObserver.php + - message: '#^Using nullsafe property access on non\-nullable type mixed\. Use \-\> instead\.$#' identifier: nullsafe.neverNull @@ -10311,13 +10857,13 @@ parameters: - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound - count: 3 + count: 2 path: app/Observers/ComponentObserver.php - message: '#^Access to an undefined property App\\Models\\Actionlog\:\:\$created_by\.$#' identifier: property.notFound - count: 3 + count: 2 path: app/Observers/ConsumableObserver.php - @@ -10539,7 +11085,13 @@ parameters: - message: '#^Access to an undefined property App\\Presenters\\ActionlogPresenter\:\:\$action_type\.$#' identifier: property.notFound - count: 22 + count: 25 + path: app/Presenters/ActionlogPresenter.php + + - + message: '#^Access to an undefined property App\\Presenters\\ActionlogPresenter\:\:\$quantity\.$#' + identifier: property.notFound + count: 2 path: app/Presenters/ActionlogPresenter.php - @@ -11484,6 +12036,18 @@ parameters: count: 3 path: database/factories/AccessoryFactory.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$order\.$#' + identifier: property.notFound + count: 1 + path: database/factories/AccessoryFactory.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$price\.$#' + identifier: property.notFound + count: 1 + path: database/factories/AccessoryFactory.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Model\:\:checkouts\(\)\.$#' identifier: method.notFound @@ -11580,6 +12144,18 @@ parameters: count: 5 path: database/factories/ComponentFactory.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$order\.$#' + identifier: property.notFound + count: 1 + path: database/factories/ComponentFactory.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$price\.$#' + identifier: property.notFound + count: 1 + path: database/factories/ComponentFactory.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:attach\(\)\.$#' identifier: method.notFound @@ -11592,6 +12168,18 @@ parameters: count: 1 path: database/factories/ComponentFactory.php + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$order\.$#' + identifier: property.notFound + count: 1 + path: database/factories/ConsumableFactory.php + + - + message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$price\.$#' + identifier: property.notFound + count: 1 + path: database/factories/ConsumableFactory.php + - message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\Relation\:\:attach\(\)\.$#' identifier: method.notFound @@ -11985,7 +12573,7 @@ parameters: - message: '#^Called ''pluck'' on Laravel collection, but could have been retrieved as a query\.$#' identifier: larastan.noUnnecessaryCollectionCall - count: 2 + count: 3 path: database/seeders/ComponentSeeder.php - @@ -11994,6 +12582,12 @@ parameters: count: 1 path: database/seeders/ConsumableSeeder.php + - + message: '#^Called ''pluck'' on Laravel collection, but could have been retrieved as a query\.$#' + identifier: larastan.noUnnecessaryCollectionCall + count: 1 + path: database/seeders/ConsumableSeeder.php + - message: '#^Using nullsafe method call on non\-nullable type Illuminate\\Console\\Command\. Use \-\> instead\.$#' identifier: nullsafe.neverNull @@ -12042,12 +12636,6 @@ parameters: count: 1 path: database/seeders/SettingsSeeder.php - - - message: '#^Property App\\Models\\Setting\:\:\$ldap_enabled \(string\|null\) does not accept int\.$#' - identifier: assign.propertyType - count: 1 - path: database/seeders/SettingsSeeder.php - - message: '#^Property App\\Models\\Setting\:\:\$pwd_secure_min \(int\) does not accept string\.$#' identifier: assign.propertyType