From 96911b9e5771dbec53b1598c33834a08a9e31f25 Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Sat, 23 Apr 2016 03:34:49 -0700
Subject: [PATCH] Fixes #1944 - add manufacturer to model list

---
 app/Helpers/Helper.php    | 14 ++++++++------
 app/Models/AssetModel.php |  9 +++++++++
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/app/Helpers/Helper.php b/app/Helpers/Helper.php
index 7a6acd9e4f..86cd791128 100644
--- a/app/Helpers/Helper.php
+++ b/app/Helpers/Helper.php
@@ -4,6 +4,7 @@ namespace App\Helpers;
 use DB;
 use App\Models\Statuslabel;
 use App\Models\Location;
+use App\Models\AssetModel;
 use App\Models\Company;
 use App\Models\User;
 use App\Models\Manufacturer;
@@ -38,6 +39,7 @@ class Helper
         return trim($value);
     }
 
+
     public static function ParseFloat($floatString)
     {
         // use comma for thousands until local info is property used
@@ -50,12 +52,12 @@ class Helper
 
     public static function modelList()
     {
-        $model_list = array('' => trans('general.select_model')) + DB::table('models')
-        ->select(DB::raw('IF (modelno="" OR modelno IS NULL,name,concat(name, " / ",modelno)) as name, id'))
-        ->orderBy('name', 'asc')
-        ->whereNull('deleted_at')
-        ->pluck('name', 'id');
-        return $model_list;
+        $models = AssetModel::with('manufacturer')->get();
+        $model_array[''] = trans('general.select_model');
+        foreach ($models as $model) {
+            $model_array[$model->id] = $model->displayModelName();
+        }
+        return $model_array;
     }
 
     public static function companyList()
diff --git a/app/Models/AssetModel.php b/app/Models/AssetModel.php
index 6aa1c24dfe..3e8becdf4b 100755
--- a/app/Models/AssetModel.php
+++ b/app/Models/AssetModel.php
@@ -87,6 +87,15 @@ class AssetModel extends Model
 
     }
 
+    public function displayModelName()
+    {
+        $name = $this->manufacturer->name.' '.$this->name;
+        if ($this->modelno) {
+            $name .=" / ".$this->modelno;
+        }
+        return $name;
+    }
+
     /**
     * -----------------------------------------------
     * BEGIN QUERY SCOPES