diff --git a/app/Http/Controllers/Api/UsersController.php b/app/Http/Controllers/Api/UsersController.php index 52fe7184da..e2c74db3d1 100644 --- a/app/Http/Controllers/Api/UsersController.php +++ b/app/Http/Controllers/Api/UsersController.php @@ -476,7 +476,7 @@ class UsersController extends Controller return response()->json(Helper::formatStandardApiResponse('error', null, 'You cannot be your own manager')); } - if (Gate::allows('editCurrentUser', $user)) { + if (Gate::allows('canEditSensitiveFieldsForCurrentUser', $user)) { if ($request->filled('password')) { $user->password = bcrypt($request->input('password')); diff --git a/app/Http/Controllers/Users/UsersController.php b/app/Http/Controllers/Users/UsersController.php index 3adc9fee77..ef28f6a497 100755 --- a/app/Http/Controllers/Users/UsersController.php +++ b/app/Http/Controllers/Users/UsersController.php @@ -275,7 +275,7 @@ class UsersController extends Controller // check for permissions related fields and pull them out if the current user cannot edit them - if (Gate::allows('editCurrentUser', $user)) { + if (Gate::allows('canEditSensitiveFieldsForCurrentUser', $user)) { \Log::debug('Current user can edit these fields'); $user->username = trim($request->input('username')); diff --git a/app/Importer/UserImporter.php b/app/Importer/UserImporter.php index 21f7b44086..6a021d2b51 100644 --- a/app/Importer/UserImporter.php +++ b/app/Importer/UserImporter.php @@ -101,7 +101,7 @@ class UserImporter extends ItemImporter $this->log('Updating User'); // Todo - check that this works -// if (!Gate::allows('editCurrentUser', $user)) { +// if (!Gate::allows('canEditSensitiveFieldsForCurrentUser', $user)) { // $user->except(['password', 'username', 'email', 'activated']); // } diff --git a/app/Providers/AuthServiceProvider.php b/app/Providers/AuthServiceProvider.php index cf2f97e974..5288a892d0 100644 --- a/app/Providers/AuthServiceProvider.php +++ b/app/Providers/AuthServiceProvider.php @@ -117,7 +117,7 @@ class AuthServiceProvider extends ServiceProvider * use in our controllers to determine if a user has access to a certain area. */ - Gate::define('editCurrentUser', function ($user, $item) { + Gate::define('canEditSensitiveFieldsForCurrentUser', function ($user, $item) { if ($item instanceof User) { if ($item) { diff --git a/resources/views/users/edit.blade.php b/resources/views/users/edit.blade.php index c52615a312..0d34bfbd8a 100755 --- a/resources/views/users/edit.blade.php +++ b/resources/views/users/edit.blade.php @@ -102,7 +102,7 @@
- @can('editCurrentUser', $user) + @can('canEditSensitiveFieldsForCurrentUser', $user) @if ($user->ldap_import!='1' || str_contains(Route::currentRouteName(), 'clone')) id)) ? ' disabled' : '' }}"> @@ -151,7 +151,7 @@
- @can('editCurrentUser', $user) + @can('canEditSensitiveFieldsForCurrentUser', $user) @if ($user->ldap_import!='1' || str_contains(Route::currentRouteName(), 'clone') ) id)) ? ' required' : '' }}{{ (!Gate::allows('editableOnDemo') && ($user->id)) ? ' disabled' : '' }}> @@ -171,13 +171,13 @@
- @if (Gate::allows('editCurrentUser', $user) && ($user->ldap_import!='1')) + @if (Gate::allows('canEditSensitiveFieldsForCurrentUser', $user) && ($user->ldap_import!='1')) {{ trans('general.generate') }} @endif
- @if ((Gate::allows('editCurrentUser', $user) && ($user->ldap_import!='1')) || str_contains(Route::currentRouteName(), 'clone')) + @if ((Gate::allows('canEditSensitiveFieldsForCurrentUser', $user) && ($user->ldap_import!='1')) || str_contains(Route::currentRouteName(), 'clone'))