3
0
mirror of https://github.com/snipe/snipe-it.git synced 2026-08-18 19:22:48 +00:00
Commit Graph

4 Commits

Author SHA1 Message Date
16bc195767 Fixed route parameter $next, updated language, added tests 2026-06-24 14:08:21 +01:00
7e617bbfa3 Switch to stripos(...) === 0
Updated the pattern check to use `stripos(...) === 0` (prefix match) instead of !== false (substring match), so scripted clients identify themselves at position 0, and prefix matching prevents a pattern from accidentally matching an unrelated UA that mentions it later. This makes surwe a UA like MyWrapper/1.0 (uses curl/8.5.0 internally) passes, and a plain curl/8.5.0 is blocked.
2026-06-24 12:18:39 +01:00
9e6c5f1b1b Updated blockedPatterns order
Get setting + UA.
  2. If UA is blank, block if blank-blocking is on, otherwise pass.
  3. Past this point UA is known non-blank.
  4. If pattern master is off, pass.
  5. Iterate patterns, reject on first match.
  6. Pass.

Side benefit: the if ($patterns === [] || $userAgent === '') short-circuit is gone — both conditions are unreachable by this point (UA is non blank by step 2; an empty pattern list just makes the foreach a no-op).
2026-06-24 12:15:23 +01:00
7714179de8 API/Settings: Added optional requirement for non-generic user agent
alternative to #19217
2026-06-23 22:59:03 +01:00