3
0
mirror of https://github.com/snipe/snipe-it.git synced 2026-08-18 11:15:42 +00:00
Files
snipe-it/tests/Feature/Checkouts/Ui/AssetCheckoutTest.php
2026-07-14 16:17:00 +01:00

561 lines
21 KiB
PHP

<?php
namespace Tests\Feature\Checkouts\Ui;
use App\Events\CheckoutableCheckedOut;
use App\Models\Actionlog;
use App\Models\Asset;
use App\Models\CheckoutAcceptance;
use App\Models\Company;
use App\Models\LicenseSeat;
use App\Models\Location;
use App\Models\Statuslabel;
use App\Models\User;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Event;
use PHPUnit\Framework\Attributes\DataProvider;
use Tests\TestCase;
class AssetCheckoutTest extends TestCase
{
protected function setUp(): void
{
parent::setUp();
Event::fake([CheckoutableCheckedOut::class]);
}
public function test_checking_out_asset_requires_correct_permission()
{
$this->actingAs(User::factory()->create())
->post(route('hardware.checkout.store', Asset::factory()->create()), [
'checkout_to_type' => 'user',
'assigned_user' => User::factory()->create()->id,
])
->assertForbidden();
}
public function test_non_existent_asset_cannot_be_checked_out()
{
$this->actingAs(User::factory()->checkoutAssets()->create())
->post(route('hardware.checkout.store', 1000), [
'checkout_to_type' => 'user',
'assigned_user' => User::factory()->create()->id,
'name' => 'Changed Name',
])
->assertSessionHas('error')
->assertRedirect(route('hardware.index'));
Event::assertNotDispatched(CheckoutableCheckedOut::class);
}
public function test_asset_not_available_for_checkout_cannot_be_checked_out()
{
$assetAlreadyCheckedOut = Asset::factory()->assignedToUser()->create();
$this->actingAs(User::factory()->checkoutAssets()->create())
->post(route('hardware.checkout.store', $assetAlreadyCheckedOut), [
'checkout_to_type' => 'user',
'assigned_user' => User::factory()->create()->id,
])
->assertSessionHas('error')
->assertRedirect(route('hardware.index'));
Event::assertNotDispatched(CheckoutableCheckedOut::class);
}
public function test_asset_cannot_be_checked_out_to_itself()
{
$asset = Asset::factory()->create();
$this->actingAs(User::factory()->checkoutAssets()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'asset',
'assigned_asset' => $asset->id,
])
->assertSessionHas('error');
Event::assertNotDispatched(CheckoutableCheckedOut::class);
}
public function test_validation_when_checking_out_asset()
{
$this->actingAs(User::factory()->create())
->post(route('hardware.checkout.store', Asset::factory()->create()), [
'status_id' => 'does-not-exist',
'checkout_at' => 'invalid-date',
'expected_checkin' => 'invalid-date',
])
->assertSessionHasErrors([
'assigned_user',
'assigned_asset',
'assigned_location',
'status_id',
'checkout_to_type',
'checkout_at',
'expected_checkin',
]);
Event::assertNotDispatched(CheckoutableCheckedOut::class);
}
public function test_cannot_checkout_across_companies_when_full_company_support_enabled()
{
$this->settings->enableMultipleFullCompanySupport();
$assetCompany = Company::factory()->create();
$userCompany = Company::factory()->create();
$user = User::factory()->forCompany($userCompany)->create();
$asset = Asset::factory()->for($assetCompany)->create();
$this->actingAs(User::factory()->superuser()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => $user->id,
])
->assertRedirect(route('hardware.checkout.store', $asset));
Event::assertNotDispatched(CheckoutableCheckedOut::class);
}
public function test_can_checkout_to_user_with_multiple_companies_via_pivot_when_fmcs_enabled()
{
$this->settings->enableMultipleFullCompanySupport();
$companyA = Company::factory()->create();
$companyB = Company::factory()->create();
// User's primary company is A but is also assigned to B via pivot
$user = User::factory()->forCompany($companyA)->create();
$user->companies()->sync([$companyA->id, $companyB->id]);
// Asset belongs to company B
$asset = Asset::factory()->for($companyB)->create();
$this->actingAs(User::factory()->superuser()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => $user->id,
])
->assertRedirect();
Event::assertDispatched(CheckoutableCheckedOut::class);
}
public function test_can_checkout_to_uncompanied_location_when_fmcs_enabled_without_location_scoping()
{
$this->settings->enableMultipleFullCompanySupport();
$company = Company::factory()->create();
$location = Location::factory()->create(['company_id' => null]);
$asset = Asset::factory()->for($company)->create();
$this->actingAs(User::factory()->superuser()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'location',
'assigned_location' => $location->id,
'redirect_option' => 'index',
])
->assertSessionMissing('error')
->assertRedirect();
Event::assertDispatched(CheckoutableCheckedOut::class);
}
public function test_can_checkout_to_child_location_whose_parent_has_matching_company_when_location_scoping_enabled()
{
$this->settings->enableScopedLocationsWithFullMultipleCompanySupport();
$company = Company::factory()->create();
$parentLocation = Location::factory()->for($company)->create();
$childLocation = Location::factory()->create(['parent_id' => $parentLocation->id, 'company_id' => null]);
$asset = Asset::factory()->for($company)->create(['rtd_location_id' => $parentLocation->id]);
$this->actingAs(User::factory()->superuser()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'location',
'assigned_location' => $childLocation->id,
'redirect_option' => 'index',
])
->assertSessionMissing('error')
->assertRedirect();
Event::assertDispatched(CheckoutableCheckedOut::class);
}
public function test_cannot_checkout_to_child_location_whose_parent_has_different_company_when_location_scoping_enabled()
{
$this->settings->enableScopedLocationsWithFullMultipleCompanySupport();
$assetCompany = Company::factory()->create();
$otherCompany = Company::factory()->create();
$parentLocation = Location::factory()->for($otherCompany)->create();
$childLocation = Location::factory()->create(['parent_id' => $parentLocation->id, 'company_id' => null]);
$asset = Asset::factory()->for($assetCompany)->create(['rtd_location_id' => null]);
$this->actingAs(User::factory()->superuser()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'location',
'assigned_location' => $childLocation->id,
])
->assertSessionHas('error');
Event::assertNotDispatched(CheckoutableCheckedOut::class);
}
public function test_page_renders()
{
$this->actingAs(User::factory()->superuser()->create())
->get(route('hardware.checkout.create', Asset::factory()->create()))
->assertOk();
}
/**
* This data provider contains checkout targets along with the
* asset's expected location after the checkout process.
*/
public static function checkoutTargets(): array
{
return [
'User' => [function () {
$userLocation = Location::factory()->create();
$user = User::factory()->for($userLocation)->create();
return [
'checkout_type' => 'user',
'target' => $user,
'expected_location' => $userLocation,
];
}],
'Asset without location set' => [function () {
$rtdLocation = Location::factory()->create();
$asset = Asset::factory()->for($rtdLocation, 'defaultLoc')->create(['location_id' => null]);
return [
'checkout_type' => 'asset',
'target' => $asset,
'expected_location' => $rtdLocation,
];
}],
'Asset with location set' => [function () {
$rtdLocation = Location::factory()->create();
$location = Location::factory()->create();
$asset = Asset::factory()->for($location)->for($rtdLocation, 'defaultLoc')->create();
return [
'checkout_type' => 'asset',
'target' => $asset,
'expected_location' => $location,
];
}],
'Location' => [function () {
$location = Location::factory()->create();
return [
'checkout_type' => 'location',
'target' => $location,
'expected_location' => $location,
];
}],
];
}
#[DataProvider('checkoutTargets')]
public function test_asset_can_be_checked_out($data)
{
['checkout_type' => $type, 'target' => $target, 'expected_location' => $expectedLocation] = $data();
$newStatus = Statuslabel::factory()->readyToDeploy()->create();
$asset = Asset::factory()->create();
$admin = User::factory()->checkoutAssets()->create();
$defaultFieldsAlwaysIncludedInUIFormSubmission = [
'assigned_user' => null,
'assigned_asset' => null,
'assigned_location' => null,
];
$this->actingAs($admin)
->post(route('hardware.checkout.store', $asset), array_merge($defaultFieldsAlwaysIncludedInUIFormSubmission, [
'checkout_to_type' => $type,
// overwrite the value from the default fields set above
'assigned_'.$type => (string) $target->id,
'name' => 'Changed Name',
'status_id' => (string) $newStatus->id,
'checkout_at' => '2024-03-18',
'expected_checkin' => '2024-03-28',
'note' => 'An awesome note',
]));
$asset->refresh();
$this->assertTrue($asset->assignedTo()->is($target));
$this->assertTrue($asset->location->is($expectedLocation));
$this->assertEquals('Changed Name', $asset->name);
$this->assertTrue($asset->status->is($newStatus));
$this->assertEquals('2024-03-18 00:00:00', $asset->last_checkout);
$this->assertEquals('2024-03-28 00:00:00', (string) $asset->expected_checkin);
Event::assertDispatched(CheckoutableCheckedOut::class, 1);
Event::assertDispatched(function (CheckoutableCheckedOut $event) use ($admin, $asset, $target) {
$this->assertTrue($event->checkoutable->is($asset));
$this->assertTrue($event->checkedOutTo->is($target));
$this->assertTrue($event->checkedOutBy->is($admin));
$this->assertEquals('An awesome note', $event->note);
return true;
});
$this->assertHasTheseActionLogs($asset, ['create'/* , 'checkout' */]); // TODO - only getting one?
}
public function test_license_seats_are_assigned_to_user_upon_checkout()
{
$asset = Asset::factory()->create();
$seat = LicenseSeat::factory()->assignedToAsset($asset)->create();
$user = User::factory()->create();
$this->assertFalse($user->licenses->contains($seat->license));
$this->actingAs(User::factory()->checkoutAssets()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => $user->id,
]);
$this->assertTrue($user->fresh()->licenses->contains($seat->license));
}
public function test_checkout_can_set_asset_to_not_requestable()
{
Event::fakeExcept([CheckoutableCheckedOut::class]);
$asset = Asset::factory()->create(['requestable' => 1]);
$targetUser = User::factory()->create();
$this->actingAs(User::factory()->checkoutAssets()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => $targetUser->id,
// Unchecked checkbox on the form → key absent → boolean()
// returns false → asset flipped to not-requestable.
]);
$this->assertFalse((bool) $asset->fresh()->requestable);
$log = Actionlog::query()
->where('item_type', Asset::class)
->where('item_id', $asset->id)
->where('action_type', 'checkout')
->latest('id')
->first();
$this->assertNotNull($log);
$this->assertNotNull($log->log_meta);
$logMeta = json_decode($log->log_meta, true);
$this->assertArrayHasKey('requestable', $logMeta);
$this->assertEquals(1, (int) $logMeta['requestable']['old']);
$this->assertEquals(0, (int) $logMeta['requestable']['new']);
}
public function test_last_checkout_uses_current_date_if_not_provided()
{
$asset = Asset::factory()->create(['last_checkout' => now()->subMonth()]);
$this->actingAs(User::factory()->checkoutAssets()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => User::factory()->create()->id,
]);
$asset->refresh();
$this->assertTrue((int) Carbon::parse($asset->last_checkout)->diffInSeconds(now(), true) < 2);
}
public function test_asset_checkout_page_is_redirected_if_model_is_invalid()
{
$asset = Asset::factory()->create();
$asset->model_id = 0;
$asset->forceSave();
$this->actingAs(User::factory()->admin()->create())
->get(route('hardware.checkout.create', $asset))
->assertStatus(302)
->assertSessionHas('error')
->assertRedirect(route('hardware.show', $asset));
}
public function test_asset_checkout_page_post_is_redirected_if_redirect_selection_is_index()
{
$asset = Asset::factory()->create();
$this->actingAs(User::factory()->admin()->create())
->from(route('hardware.checkout.create', $asset))
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => User::factory()->create()->id,
'redirect_option' => 'index',
])
->assertStatus(302)
->assertRedirect(route('hardware.index'));
}
public function test_asset_checkout_page_post_is_redirected_if_redirect_selection_is_item()
{
$asset = Asset::factory()->create();
$this->actingAs(User::factory()->admin()->create())
->from(route('hardware.checkout.create', $asset))
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => User::factory()->create()->id,
'redirect_option' => 'item',
])
->assertStatus(302)
->assertSessionHasNoErrors()
->assertRedirect(route('hardware.show', $asset));
}
public function test_asset_checkout_page_post_is_redirected_if_redirect_selection_is_user_target()
{
$user = User::factory()->create();
$asset = Asset::factory()->create();
$this->actingAs(User::factory()->admin()->create())
->from(route('hardware.checkout.create', $asset))
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => $user->id,
'redirect_option' => 'target',
'assigned_qty' => 1,
])
->assertStatus(302)
->assertRedirect(route('users.show', ['user' => $user]));
}
public function test_asset_checkout_page_post_is_redirected_if_redirect_selection_is_asset_target()
{
$target = Asset::factory()->create();
$asset = Asset::factory()->create();
$this->actingAs(User::factory()->admin()->create())
->from(route('hardware.checkout.create', $asset))
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'asset',
'assigned_asset' => $target->id,
'redirect_option' => 'target',
'assigned_qty' => 1,
])
->assertStatus(302)
->assertRedirect(route('hardware.show', $target));
}
public function test_asset_checkout_page_post_is_redirected_if_redirect_selection_is_location_target()
{
$target = Location::factory()->create();
$asset = Asset::factory()->create();
$this->actingAs(User::factory()->admin()->create())
->from(route('hardware.checkout.create', $asset))
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'location',
'assigned_location' => $target->id,
'redirect_option' => 'target',
'assigned_qty' => 1,
])
->assertStatus(302)
->assertRedirect(route('locations.show', ['location' => $target]));
}
public function test_asset_checkout_page_post_redirects_to_signature_page_when_sign_in_place_is_checked()
{
$targetUser = User::factory()->create();
$asset = Asset::factory()->create();
$response = $this->actingAs(User::factory()->admin()->create())
->from(route('hardware.checkout.create', $asset))
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => $targetUser->id,
'redirect_option' => 'index',
'sign_in_place' => 1,
]);
$acceptance = CheckoutAcceptance::query()
->where('checkoutable_type', Asset::class)
->where('checkoutable_id', $asset->id)
->where('assigned_to_id', $targetUser->id)
->pending()
->latest()
->first();
$this->assertNotNull($acceptance);
$this->assertNull($acceptance->qty);
$this->assertDatabaseCount('checkout_acceptances', 1);
$response->assertStatus(302)
->assertRedirect(route('account.accept.item', $acceptance));
}
public function test_asset_checkout_stores_sign_in_place_preference_in_session()
{
$targetUser = User::factory()->create();
$asset = Asset::factory()->create();
$response = $this->actingAs(User::factory()->admin()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => 'user',
'assigned_user' => $targetUser->id,
'redirect_option' => 'index',
'sign_in_place' => 1,
]);
$response->assertSessionHas('sign_in_place', true);
}
/**
* Regression: AssetCheckoutController::store used to call
* session()->put(['checkout_to_type' => $target]);
* with $target being the resolved Eloquent model (User/Asset/Location),
* not the string 'user'/'asset'/'location'. Every subsequent read of
* session('checkout_to_type') then compared an Eloquent instance to a
* string literal in the checkout-selector partial, which silently
* failed — no radio was rendered `checked`, no target select got
* `required`, and jQuery Validate had nothing to block on.
*
* @see \App\Http\Controllers\Assets\AssetCheckoutController::store
*/
#[DataProvider('checkoutTargetTypesProvider')]
public function test_asset_checkout_stores_target_type_as_string_in_session(string $type)
{
[$field, $target] = match ($type) {
'user' => ['assigned_user', User::factory()->create()->id],
'asset' => ['assigned_asset', Asset::factory()->create()->id],
'location' => ['assigned_location', Location::factory()->create()->id],
};
$asset = Asset::factory()->create();
$this->actingAs(User::factory()->admin()->create())
->post(route('hardware.checkout.store', $asset), [
'checkout_to_type' => $type,
$field => $target,
])
->assertSessionHasNoErrors();
$stored = session('checkout_to_type');
$this->assertIsString($stored, 'checkout_to_type must be a string, not an Eloquent model');
$this->assertSame($type, $stored);
}
public static function checkoutTargetTypesProvider(): array
{
return [
'user target' => ['user'],
'asset target' => ['asset'],
'location target' => ['location'],
];
}
}