mirror/tinyusb
3
0
Fork 0
mirror of https://github.com/hathach/tinyusb.git synced 2026-08-18 11:02:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

usbtmc: document why the trigger re-arm result is ignored

Browse Source 
A false return from tud_usbtmc_start_bus_read() here does not mean arming
failed: it means the endpoint is already armed, either because the
application re-armed it from its trigger callback or because a transfer is
still queued (usbd_edpt_xfer() reports failure when the endpoint is busy).
Both cases end in STATE_IDLE, so the state cannot disambiguate them either,
and stalling on the result would halt a healthy endpoint.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
ice458
2026-08-14 16:23:38 +09:00
parent 282d46e68d
commit af81f9ef42
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/class/usbtmc/usbtmc_device.c
View File

@ -511,6 +511,9 @@ bool usbtmcd_xfer_cb(uint8_t rhport, uint8_t ep_addr, xfer_result_t result, uint
usbd_edpt_stall(rhport, usbtmc_state.ep_bulk_out); usbd_edpt_stall(rhport, usbtmc_state.ep_bulk_out);
return false; return false;
} }
// Result deliberately ignored: false here means the endpoint is already armed - either the
// application re-armed it from its callback, or a transfer is still queued - not that arming
// failed. Stalling on it would halt a healthy endpoint.
tud_usbtmc_start_bus_read(); tud_usbtmc_start_bus_read();
break; break;