mirror of
https://github.com/mborgerson/xemu.git
synced 2025-10-29 22:51:05 +00:00
ea0a906707
Interprets the value written to the `NV_PVIDEO_STOP` register in a manner more consistent with hardware. Specifically, if the low bit of the value is not set, the PVIDEO overlay should remain active. Fixes #1049 [Test](https://github.com/abaire/nxdk_pgraph_tests/blob/main/src/tests/pvideo_tests.cpp) Note that, as this is testing video behavior, this test is interactive and the value passed to the final SetPvideoStop call needs to be mutated and the behavior observed.
78 lines
2.3 KiB
C
78 lines
2.3 KiB
C
/*
|
|
* QEMU Geforce NV2A implementation
|
|
*
|
|
* Copyright (c) 2012 espes
|
|
* Copyright (c) 2015 Jannik Vogel
|
|
* Copyright (c) 2018-2021 Matt Borgerson
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "nv2a_int.h"
|
|
|
|
static void pvideo_vga_invalidate(NV2AState *d)
|
|
{
|
|
int y1 = GET_MASK(d->pvideo.regs[NV_PVIDEO_POINT_OUT],
|
|
NV_PVIDEO_POINT_OUT_Y);
|
|
int y2 = y1 + GET_MASK(d->pvideo.regs[NV_PVIDEO_SIZE_OUT],
|
|
NV_PVIDEO_SIZE_OUT_HEIGHT);
|
|
NV2A_DPRINTF("pvideo_vga_invalidate %d %d\n", y1, y2);
|
|
vga_invalidate_scanlines(&d->vga, y1, y2);
|
|
}
|
|
|
|
uint64_t pvideo_read(void *opaque, hwaddr addr, unsigned int size)
|
|
{
|
|
NV2AState *d = opaque;
|
|
|
|
uint64_t r = 0;
|
|
switch (addr) {
|
|
case NV_PVIDEO_STOP:
|
|
r = 0;
|
|
break;
|
|
default:
|
|
r = d->pvideo.regs[addr];
|
|
break;
|
|
}
|
|
|
|
nv2a_reg_log_read(NV_PVIDEO, addr, size, r);
|
|
return r;
|
|
}
|
|
|
|
void pvideo_write(void *opaque, hwaddr addr, uint64_t val, unsigned int size)
|
|
{
|
|
NV2AState *d = opaque;
|
|
|
|
nv2a_reg_log_write(NV_PVIDEO, addr, size, val);
|
|
|
|
switch (addr) {
|
|
case NV_PVIDEO_BUFFER:
|
|
d->pvideo.regs[addr] = val;
|
|
// d->vga.enable_overlay = true;
|
|
pvideo_vga_invalidate(d);
|
|
break;
|
|
case NV_PVIDEO_STOP:
|
|
// PVIDEO_STOP may be set many times during the course of video playback
|
|
// but the overlay is only torn down if the 0th bit is 1.
|
|
if (val & 0x01) {
|
|
d->pvideo.regs[NV_PVIDEO_BUFFER] = 0;
|
|
}
|
|
// d->vga.enable_overlay = false;
|
|
pvideo_vga_invalidate(d);
|
|
break;
|
|
default:
|
|
d->pvideo.regs[addr] = val;
|
|
break;
|
|
}
|
|
}
|