mirror/AntennaPod
3
0
Fork 0
mirror of https://github.com/AntennaPod/AntennaPod.git synced 2025-12-01 12:31:45 +00:00
Code Issues Projects Releases Wiki Activity

Fix crash when tapping on chapter (#8113)

Browse Source
This commit is contained in:
schwarzspecht
2025-11-30 18:08:36 +01:00
committed by GitHub
parent 9b78c586df
commit 84b596bffd
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/src/main/java/de/danoeh/antennapod/ui/screen/chapter/ChaptersListAdapter.java
View File

@ -52,6 +52,10 @@ public class ChaptersListAdapter extends RecyclerView.Adapter<ChaptersListAdapte
@Override
public void onBindViewHolder(@NonNull ChapterHolder holder, int position) {
if (position < 0 || position >= getItemCount()) {
holder.title.setText("Error");
return;
}
Chapter sc = getItem(position);
if (sc == null) {
holder.title.setText("Error");
@ -167,12 +171,21 @@ public class ChaptersListAdapter extends RecyclerView.Adapter<ChaptersListAdapte
}
public void notifyChapterChanged(int newChapterIndex) {
if (newChapterIndex < 0 || newChapterIndex >= getItemCount()) {
return;
}
currentChapterIndex = newChapterIndex;
currentChapterPosition = getItem(newChapterIndex).getStart();
Chapter chapter = getItem(newChapterIndex);
if (chapter != null) {
currentChapterPosition = chapter.getStart();
}
notifyDataSetChanged();
}
public void notifyTimeChanged(long timeMs) {
if (currentChapterIndex < 0 || currentChapterIndex >= getItemCount()) {
return;
}
currentChapterPosition = timeMs;
// Passing an argument prevents flickering.
// See EpisodeItemListAdapter.notifyItemChangedCompat.
@ -180,6 +193,9 @@ public class ChaptersListAdapter extends RecyclerView.Adapter<ChaptersListAdapte
}
public Chapter getItem(int position) {
if (media == null || media.getChapters() == null || position < 0 || position >= media.getChapters().size()) {
return null;
}
return media.getChapters().get(position);
}

2
ui/chapters/src/main/java/de/danoeh/antennapod/ui/chapters/ChapterUtils.java
View File

@ -170,7 +170,7 @@ public class ChapterUtils {
} catch (InterruptedIOException e) {
throw e;
} catch (IOException e) {
e.printStackTrace();
Log.d(TAG, "Failed to load chapters from URL: " + url, e);
} finally {
if (response != null) {
response.close();