mirror/Infinity-For-Reddit
3
0
Fork 0
mirror of https://github.com/Docile-Alligator/Infinity-For-Reddit.git synced 2026-03-01 21:36:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Executor instead of AsyncTask in FetchUserFlairs.

Browse Source
This commit is contained in:
Docile-Alligator
2025-04-13 11:29:18 -04:00
parent 7eadb9c779
commit c2ff41be22
3 changed files with 38 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/ml/docilealligator/infinityforreddit/activities/SelectUserFlairActivity.java
View File

@ -95,7 +95,7 @@ public class SelectUserFlairActivity extends BaseActivity implements ActivityToo
private void bindView() {
if (mUserFlairs == null) {
FetchUserFlairs.fetchUserFlairsInSubreddit(mOauthRetrofit, accessToken, mSubredditName,
FetchUserFlairs.fetchUserFlairsInSubreddit(mExecutor, mHandler, mOauthRetrofit, accessToken, mSubredditName,
new FetchUserFlairs.FetchUserFlairsInSubredditListener() {
@Override
public void fetchSuccessful(ArrayList<UserFlair> userFlairs) {

3
app/src/main/java/ml/docilealligator/infinityforreddit/adapters/UserFlairRecyclerViewAdapter.java
View File

@ -22,7 +22,8 @@ public class UserFlairRecyclerViewAdapter extends RecyclerView.Adapter<RecyclerV
private final ArrayList<UserFlair> userFlairs;
private final ItemClickListener itemClickListener;
public UserFlairRecyclerViewAdapter(BaseActivity activity, CustomThemeWrapper customThemeWrapper, ArrayList<UserFlair> userFlairs,
public UserFlairRecyclerViewAdapter(BaseActivity activity, CustomThemeWrapper customThemeWrapper,
ArrayList<UserFlair> userFlairs,
ItemClickListener itemClickListener) {
this.activity = activity;
this.customThemeWrapper = customThemeWrapper;

101
app/src/main/java/ml/docilealligator/infinityforreddit/user/FetchUserFlairs.java
View File

@ -1,80 +1,56 @@
package ml.docilealligator.infinityforreddit.user;
import android.os.AsyncTask;
import android.os.Handler;
import android.text.Html;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;
import java.io.IOException;
import java.util.ArrayList;
import java.util.concurrent.Executor;
import ml.docilealligator.infinityforreddit.apis.RedditAPI;
import ml.docilealligator.infinityforreddit.utils.APIUtils;
import ml.docilealligator.infinityforreddit.utils.JSONUtils;
import retrofit2.Call;
import retrofit2.Callback;
import retrofit2.Response;
import retrofit2.Retrofit;
public class FetchUserFlairs {
public static void fetchUserFlairsInSubreddit(Retrofit oauthRetrofit, String accessToken, String subredditName, FetchUserFlairsInSubredditListener fetchUserFlairsInSubredditListener) {
RedditAPI api = oauthRetrofit.create(RedditAPI.class);
public static void fetchUserFlairsInSubreddit(Executor executor, Handler handler, Retrofit oauthRetrofit, String accessToken, String subredditName, FetchUserFlairsInSubredditListener fetchUserFlairsInSubredditListener) {
executor.execute(() -> {
RedditAPI api = oauthRetrofit.create(RedditAPI.class);
Call<String> flairsCall = api.getUserFlairs(APIUtils.getOAuthHeader(accessToken), subredditName);
flairsCall.enqueue(new Callback<String>() {
@Override
public void onResponse(@NonNull Call<String> call, @NonNull Response<String> response) {
try {
Response<String> response = api.getUserFlairs(APIUtils.getOAuthHeader(accessToken), subredditName).execute();
if (response.isSuccessful()) {
new ParseUserFlairsAsyncTask(response.body(), new ParseUserFlairsAsyncTask.ParseUserFlairsAsyncTaskListener() {
@Override
public void parseSuccessful(ArrayList<UserFlair> userFlairs) {
fetchUserFlairsInSubredditListener.fetchSuccessful(userFlairs);
}
@Override
public void parseFailed() {
fetchUserFlairsInSubredditListener.fetchFailed();
}
}).execute();
ArrayList<UserFlair> userFlairs = parseUserFlairs(response.body());
if (userFlairs == null) {
handler.post(fetchUserFlairsInSubredditListener::fetchFailed);
} else {
handler.post(() -> fetchUserFlairsInSubredditListener.fetchSuccessful(userFlairs));
}
} else if (response.code() == 403) {
//No flairs
fetchUserFlairsInSubredditListener.fetchSuccessful(null);
handler.post(() -> fetchUserFlairsInSubredditListener.fetchSuccessful(null));
} else {
fetchUserFlairsInSubredditListener.fetchFailed();
handler.post(fetchUserFlairsInSubredditListener::fetchFailed);
}
}
@Override
public void onFailure(@NonNull Call<String> call, @NonNull Throwable t) {
fetchUserFlairsInSubredditListener.fetchFailed();
} catch (IOException e) {
handler.post(fetchUserFlairsInSubredditListener::fetchFailed);
}
});
}
public interface FetchUserFlairsInSubredditListener {
void fetchSuccessful(ArrayList<UserFlair> userFlairs);
void fetchFailed();
}
private static class ParseUserFlairsAsyncTask extends AsyncTask<Void, ArrayList<UserFlair>, ArrayList<UserFlair>> {
private final String response;
private final ParseUserFlairsAsyncTaskListener parseFlairsAsyncTaskListener;
ParseUserFlairsAsyncTask(String response, ParseUserFlairsAsyncTaskListener parseFlairsAsyncTaskListener) {
this.response = response;
this.parseFlairsAsyncTaskListener = parseFlairsAsyncTaskListener;
}
@Override
protected ArrayList<UserFlair> doInBackground(Void... voids) {
try {
JSONArray jsonArray = new JSONArray(response);
ArrayList<UserFlair> userFlairs = new ArrayList<>();
for (int i = 0; i < jsonArray.length(); i++) {
private static ArrayList<UserFlair> parseUserFlairs(String response) {
try {
JSONArray jsonArray = new JSONArray(response);
ArrayList<UserFlair> userFlairs = new ArrayList<>();
for (int i = 0; i < jsonArray.length(); i++) {
try {
JSONObject userFlairObject = jsonArray.getJSONObject(i);
String id = userFlairObject.getString(JSONUtils.ID_KEY);
String text = userFlairObject.getString(JSONUtils.TEXT_KEY);
@ -96,27 +72,20 @@ public class FetchUserFlairs {
}
userFlairs.add(new UserFlair(id, text, authorFlairHTMLBuilder.toString(), editable, maxEmojis));
} catch (JSONException e) {
e.printStackTrace();
}
return userFlairs;
} catch (JSONException e) {
e.printStackTrace();
}
return null;
return userFlairs;
} catch (JSONException e) {
e.printStackTrace();
}
return null;
}
@Override
protected void onPostExecute(ArrayList<UserFlair> userFlairs) {
if (userFlairs != null) {
parseFlairsAsyncTaskListener.parseSuccessful(userFlairs);
} else {
parseFlairsAsyncTaskListener.parseFailed();
}
}
public interface FetchUserFlairsInSubredditListener {
void fetchSuccessful(@Nullable ArrayList<UserFlair> userFlairs);
interface ParseUserFlairsAsyncTaskListener {
void parseSuccessful(ArrayList<UserFlair> userFlairs);
void parseFailed();
}
void fetchFailed();
}
}