mirror/Spark
3
0
Fork 0
mirror of https://github.com/igniterealtime/Spark.git synced 2025-12-01 12:27:58 +00:00
Code Issues Projects Releases Wiki Activity

Spark 1805 exceptions to log (#222)

Browse Source 
* SPARK-1804: Can't use iterator#remove() with CopyOnWrite.

* SPARK-1805: Stack traces should be logged.
This commit is contained in:
Guus der Kinderen
2016-09-12 11:12:23 +02:00
committed by wroot
parent b448e18ec1
commit 29961f8916
2 changed files with 12 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/java/org/jivesoftware/spark/ui/ChatRoom.java
View File

@ -54,7 +54,6 @@ import java.awt.event.*;
import java.io.File;
import java.util.*;
import java.util.List;
import java.util.concurrent.CopyOnWriteArrayList;
/**
* The base implementation of all ChatRoom conversations. You would implement this class to have most types of Chat.
@ -81,7 +80,7 @@ public abstract class ChatRoom extends BackgroundPanel implements ActionListener
private boolean mousePressed;
private List<ChatRoomClosingListener> closingListeners = new CopyOnWriteArrayList<>();
private List<ChatRoomClosingListener> closingListeners = new ArrayList<>();
private ChatRoomTransferHandler transferHandler;

33
src/java/org/jivesoftware/sparkimpl/plugin/privacy/PrivacyManager.java
View File

@ -129,8 +129,7 @@ public class PrivacyManager {
_privacyLists.add(sparkList);
}
} catch (XMPPException | SmackException e) {
Log.error("Could not load PrivacyLists");
e.printStackTrace();
Log.error("Could not load PrivacyLists", e);
}
if(hasDefaultList())
@ -147,8 +146,7 @@ public class PrivacyManager {
_privacyLists.remove(getPrivacyList(listName));
} catch (XMPPException | SmackException e) {
Log.warning("Could not remove PrivacyList " + listName);
e.printStackTrace();
Log.warning("Could not remove PrivacyList " + listName, e);
}
}
@ -245,8 +243,7 @@ public class PrivacyManager {
_privacyLists.add(sparklist);
sparklist.addSparkPrivacyListener(_presenceHandler);
} catch (XMPPException | SmackException e) {
Log.warning("Could not create PrivacyList "+listName);
e.printStackTrace();
Log.warning("Could not create PrivacyList "+listName, e);
}
return sparklist;
@ -288,8 +285,7 @@ public class PrivacyManager {
_presenceHandler.setIconsForList(getActiveList());
} catch (XMPPException | SmackException e) {
Log.warning("Could not activate PrivacyList " + listname);
e.printStackTrace();
Log.warning("Could not activate PrivacyList " + listname, e);
}
}
@ -304,8 +300,7 @@ public class PrivacyManager {
plist.setListIsDefault(false);
}
} catch (XMPPException | SmackException e) {
Log.warning("Could not set PrivacyList " + listname+" as default");
e.printStackTrace();
Log.warning("Could not set PrivacyList " + listname+" as default", e);
}
}
@ -324,8 +319,7 @@ public class PrivacyManager {
plist.setListAsActive(false);
}
} catch (XMPPException | SmackException e) {
Log.warning("Could not decline active privacy list");
e.printStackTrace();
Log.warning("Could not decline active privacy list", e);
}
}
@ -341,8 +335,7 @@ public class PrivacyManager {
}
}
} catch (XMPPException | SmackException e) {
Log.warning("Could not decline default privacy list");
e.printStackTrace();
Log.warning("Could not decline default privacy list", e);
}
}
@ -449,8 +442,7 @@ public class PrivacyManager {
}
} catch (Exception e) {
// e.printStackTrace();
Log.error("PrivacyManager#goToVisible: " + e.getMessage());
Log.error("PrivacyManager#goToVisible: ", e);
}
}
@ -467,8 +459,7 @@ public class PrivacyManager {
SparkManager.getConnection().sendStanza(PresenceManager.getAvailablePresence());
Log.debug("List \"" + INVISIBLE_LIST_NAME + "\" has been activated ");
} catch (Exception e) {
// e.printStackTrace();
Log.error("PrivacyManager#activateGloballyInvisibleList: " + e.getMessage());
Log.error("PrivacyManager#activateGloballyInvisibleList: ", e);
}
}
@ -486,8 +477,7 @@ public class PrivacyManager {
} catch (Exception e){
// it can return item-not-found if there is no active list.
// so it is fine to fall here.
//e.printStackTrace();
Log.error("PrivacyManager#isGloballyInvisibleListActive: " + e.getMessage());
Log.error("PrivacyManager#isGloballyInvisibleListActive: ", e);
}
return false;
}
@ -518,8 +508,7 @@ public class PrivacyManager {
}
catch (XMPPException | SmackException e)
{
Log.warning("PrivacyManager#ensureGloballyInvisibleListExists: Could not create PrivacyList " + INVISIBLE_LIST_NAME);
//e.printStackTrace();
Log.warning("PrivacyManager#ensureGloballyInvisibleListExists: Could not create PrivacyList " + INVISIBLE_LIST_NAME, e);
}
return list;