mirror/Spark
3
0
Fork 0
mirror of https://github.com/igniterealtime/Spark.git synced 2025-10-29 19:57:28 +00:00
Code Issues Projects Releases Wiki Activity

SPARK-2204: Code cleanup: Remove unnecessary modifiers from interfaces methods and inner classes

Browse Source
This commit is contained in:
arthur 2020-11-15 00:30:08 +03:00
parent 1785f1843b
commit fda951eabf
15 changed files with 42 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/main/java/org/jivesoftware/spark/plugin/Plugin.java
View File

@ -37,7 +37,7 @@ public interface Plugin {
*
* @see org.jivesoftware.spark.PluginManager
*/
public void initialize();
void initialize();
/**
* This method is invoked by the <code>PluginManager</code> when Spark
@ -48,7 +48,7 @@ public interface Plugin {
* be called, but on normal terminations of Spark, this method will be
* invoked.
*/
public void shutdown();
void shutdown();
/**
* This method is invoked by the <code>PluginManager</code> before Spark
@ -62,7 +62,7 @@ public interface Plugin {
*
* @return true if the plugin can shut currently.
*/
public boolean canShutDown();
boolean canShutDown();
/**
@ -71,6 +71,6 @@ public interface Plugin {
* will need to release all your in-memory resources in the #shutdown method. This
* method should be used to remove on disk resources such as files, images, etc.
*/
public void uninstall();
void uninstall();
}
}

14
core/src/main/java/org/jivesoftware/spark/ui/ContactGroupListener.java
View File

@ -33,28 +33,28 @@ public interface ContactGroupListener {
*
* @param item the ContactItem.
*/
public void contactItemAdded(ContactItem item);
void contactItemAdded(ContactItem item);
/**
* Notifies the user that a <code>ContactItem</code> has been removed from a ContactGroup.
*
* @param item the ContactItem removed.
*/
public void contactItemRemoved(ContactItem item);
void contactItemRemoved(ContactItem item);
/**
* Notifies the user that a ContactItem within the ContactGroup has been double-clicked.
*
* @param item the ContactItem double clicked.
*/
public void contactItemDoubleClicked(ContactItem item);
void contactItemDoubleClicked(ContactItem item);
/**
* Notifies the user that a ContactItem within the ContactGroup has been clicked.
*
* @param item the ContactItem clicked.
*/
public void contactItemClicked(ContactItem item);
void contactItemClicked(ContactItem item);
/**
* Notifies the user that a popup call has occured on the ContactGroup.
@ -63,7 +63,7 @@ public interface ContactGroupListener {
* @param item the ContactItem clicked within the ContactGroup.
* @deprecated see {@link ContextMenuListener}
*/
public void showPopup(MouseEvent e, ContactItem item);
void showPopup(MouseEvent e, ContactItem item);
/**
* Notifies the user that a popup call has occured on the ContactGroup.
@ -72,7 +72,7 @@ public interface ContactGroupListener {
* @param items the ContactItems within the ContactGroup.
* @deprecated see <code>ContextMenuListener</code>
*/
public void showPopup(MouseEvent e, Collection<ContactItem> items);
void showPopup(MouseEvent e, Collection<ContactItem> items);
/**
* Notifies the user that a Popup event has occured on the ContactGroup title
@ -81,5 +81,5 @@ public interface ContactGroupListener {
* @param e the MouseEvent that triggered the event.
* @param group the ContactGroup.
*/
public void contactGroupPopup(MouseEvent e, ContactGroup group);
void contactGroupPopup(MouseEvent e, ContactGroup group);
}

12
core/src/main/java/org/jivesoftware/spark/ui/ContainerComponent.java
View File

@ -22,15 +22,15 @@ import javax.swing.JComponent;
*/
public interface ContainerComponent {
public abstract String getTabTitle();
String getTabTitle();
public abstract String getFrameTitle();
String getFrameTitle();
public abstract ImageIcon getTabIcon();
ImageIcon getTabIcon();
public abstract JComponent getGUI();
JComponent getGUI();
public abstract String getToolTipDescription();
String getToolTipDescription();
public abstract boolean closing();
boolean closing();
}

2
core/src/main/java/org/jivesoftware/spark/ui/LinkInterceptor.java
View File

@ -30,5 +30,5 @@ public interface LinkInterceptor {
* @param link the link that was clicked.
* @return true if the user wishes to handle the link.
*/
public boolean handleLink(MouseEvent mouseEvent, String link);
boolean handleLink(MouseEvent mouseEvent, String link);
}

8
core/src/main/java/org/jivesoftware/sparkimpl/plugin/gateways/GatewayItem.java
View File

@ -7,10 +7,6 @@ package org.jivesoftware.sparkimpl.plugin.gateways;
*
*/
public interface GatewayItem {
public void signedIn(boolean signedIn);
public boolean isLoggedIn();
void signedIn(boolean signedIn);
boolean isLoggedIn();
}

4
core/src/main/java/org/jivesoftware/sparkimpl/plugin/idle/IdleTime.java
View File

@ -2,5 +2,5 @@ package org.jivesoftware.sparkimpl.plugin.idle;
public interface IdleTime {
public abstract long getIdleTimeMillis();
}
long getIdleTimeMillis();
}

2
core/src/main/java/org/jivesoftware/sparkimpl/plugin/idle/linux/LinuxIdleTime.java
View File

@ -24,7 +24,7 @@ public class LinuxIdleTime implements IdleTime {
interface Xss extends Library {
Xss INSTANCE = Native.loadLibrary("Xss", Xss.class);
public class XScreenSaverInfo extends Structure {
class XScreenSaverInfo extends Structure {
public X11.Window window; /* screen saver window */
public int state; /* ScreenSaver{Off,On,Disabled} */
public int kind; /* ScreenSaver{Blanked,Internal,External} */

2
core/src/main/java/org/jivesoftware/sparkimpl/plugin/idle/mac/MacIdleTime.java
View File

@ -25,7 +25,7 @@ public class MacIdleTime implements IdleTime {
* @param eventType
* @return the elapsed seconds since the last input event
*/
public double CGEventSourceSecondsSinceLastEventType(int sourceStateId, int eventType);
double CGEventSourceSecondsSinceLastEventType(int sourceStateId, int eventType);
}
@Override

7
core/src/main/java/org/jivesoftware/sparkimpl/plugin/idle/windows/Win32IdleTime.java
View File

@ -22,7 +22,7 @@ public class Win32IdleTime implements IdleTime {
* @see "http://msdn2.microsoft.com/en-us/library/ms724408.aspx"
* @return number of milliseconds that have elapsed since the system was started.
*/
public int GetTickCount();
int GetTickCount();
}
public interface User32 extends StdCallLibrary {
@ -31,7 +31,7 @@ public class Win32IdleTime implements IdleTime {
* Contains the time of the last input.
* @see "http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/windowsuserinterface/userinput/keyboardinput/keyboardinputreference/keyboardinputstructures/lastinputinfo.asp"
*/
public static class LASTINPUTINFO extends Structure {
class LASTINPUTINFO extends Structure {
public int cbSize = 8;
/// Tick count of when the last input event was received.
@ -48,7 +48,7 @@ public class Win32IdleTime implements IdleTime {
* @see "http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/windowsuserinterface/userinput/keyboardinput/keyboardinputreference/keyboardinputfunctions/getlastinputinfo.asp"
* @return time of the last input event, in milliseconds
*/
public boolean GetLastInputInfo(LASTINPUTINFO result);
boolean GetLastInputInfo(LASTINPUTINFO result);
};
/**
@ -62,6 +62,5 @@ public class Win32IdleTime implements IdleTime {
User32.INSTANCE.GetLastInputInfo(lastInputInfo);
return Kernel32.INSTANCE.GetTickCount() - lastInputInfo.dwTime;
}
}

8
plugins/meet/src/main/java/de/mxro/process/ProcessListener.java
View File

@ -13,25 +13,25 @@ public interface ProcessListener {
*
* @param line
*/
public void onOutputLine(String line);
void onOutputLine(String line);
/**
* When the process wrote a line to its error output stream.
*
* @param line
*/
public void onErrorLine(String line);
void onErrorLine(String line);
/**
* When the output stream is closed.
*/
public void onProcessQuit(int returnValue);
void onProcessQuit(int returnValue);
/**
* When an unexpected error is thrown while interacting with the process.
*
* @param t
*/
public void onError(Throwable t);
void onError(Throwable t);
}

2
plugins/meet/src/main/java/de/mxro/process/Spawn.java
View File

@ -90,7 +90,7 @@ public class Spawn {
}
public interface Callback<Type> {
public void onDone(Type t);
void onDone(Type t);
}
/**

4
plugins/meet/src/main/java/de/mxro/process/XProcess.java
View File

@ -14,11 +14,11 @@ public interface XProcess {
*
* @param line
*/
public void sendLine(String line);
void sendLine(String line);
/**
* Try to destroy the process
*/
public void destory();
void destory();
}

10
plugins/meet/src/main/java/de/mxro/process/internal/StreamListener.java
View File

@ -1,11 +1,7 @@
package de.mxro.process.internal;
public interface StreamListener {
public void onOutputLine(String line);
public void onClosed();
public void onError(Throwable t);
void onOutputLine(String line);
void onClosed();
void onError(Throwable t);
}

4
plugins/roar/src/main/java/org/jivesoftware/spark/roar/displaytype/MacNotificationCenter.java
View File

@ -20,12 +20,12 @@ public class MacNotificationCenter {
interface NSUserNotificationsBridge extends Library {
final File dylib = new File(Spark.getPluginDirectory().getAbsolutePath()
File dylib = new File(Spark.getPluginDirectory().getAbsolutePath()
+ File.separator + "roar" + File.separator + "native" + File.separator + "NSUserNotificationsBridge.dylib" );
NSUserNotificationsBridge instance = Native.loadLibrary(dylib.getAbsolutePath(), NSUserNotificationsBridge.class);
public int sendNotification(String title, String subtitle, String text, int timeoffset, String sound);
int sendNotification(String title, String subtitle, String text, int timeoffset, String sound);
}
public static void sendNotification(String title, String bodyText) {

4
plugins/roar/src/main/java/org/jivesoftware/spark/roar/displaytype/RoarDisplayType.java
View File

@ -8,12 +8,12 @@ public interface RoarDisplayType {
/**
* Do stuff when a message is received
*/
public void messageReceived(ChatRoom room, Message message, PropertyBundle bundle);
void messageReceived(ChatRoom room, Message message, PropertyBundle bundle);
/**
* Do stuff when a message is sent
*/
public void messageSent(ChatRoom room, Message message);
void messageSent(ChatRoom room, Message message);
/**
* Do stuff when the Popup closes