The recent fix for SPARK-945 already stored the preference dialog size and position, which fixed most of this
bug. When that was implemented, a rogue invocation of .pack() was placed after the stored settings were applied.
This resized the component again.
This is a fix to what I assume to be a bug. The method, used by the UI part where plugins are managed,
is documented as 'remove and uninstall' a plugin. It only removed, but did not uninstall. I've fixed that
with this commit.
To fix the issue at hand, improving the readability of the code helps a lot. In this commit,
I've applied a code formatter (to just the Plugin Manager code) and made some basic changes
(added/improved log messages mostly).
This ensures that the error dialog is centered, in relation to it's parent. Also, when expanding
the details (which changes the size of the dialog), the dialog is repositioned again (to remain
centered).
This commit:
- reworks the login method to remove some redundant code;
- applies the MessageDialog-provided error dialog generator to the login method;
- refactored the MessageDialog error dialog generator (to allow for toggling of the large stacktrace pane).
In all, this should improve the error messages during login. The same technique could be re-used elsewhere.
This commit adds a new 'security' tab to the advanced login settings. Here, security-related
settings are made available.
Also, this commit makes slight modifications to the other tabs, by making the components be
oriented more to the top-left corner (instead of being centered - which looks pretty ugly).
Instead of adding the zip files to git, this commit adds the unzipped content, and ensures that the Maven build generates the zip files. This way, editing is a lot easier, and changes are better tracked.
The old code was doing "smiley-text to image" lookup by converting everything to lowercase, then doing a
case insensitive lookup. My last commit made that lookup case sensitive, which caused lookups for :-D and :-P to fail.
This commit remove the to-lowercase conversion of the text that's used in the lookup, fixing those instances again.
Actions that don't affect the UI should not be executed in the heavily synchronized dispatcher. It will needlessly delay execution, but also make the dispatcher thread unavailable for tasks that do belong there.
