When an event listener throws an exception, it should not prevent other
listeners from being executed, nor should the exception propagate further
up the stack (which would stop processing).
* SPARK-1755: Remove listener when closing chat.
When a one-on-one tab is closed, the corresponding listener (that waits
for data to be displayed in that tab) should be deregistered. This fixes
an issue with ROAR plugin popups increasing in volume.
* SPARK-1783: Don't relay on opaque being possible.
* SPARK-1735: MUC occupants list should have width
This commit attempts to prevent that the occupants list in a MUC
screen has a near-zero width.
* SPARK-1772: Icons for muc role fix
* SPARK-1735: MUC occupants list should have vertical scrollbar
* SPARK-1740: Allow SASL GSS-API to be executed as it was in SMACK 3
SMACK 4 uses the fully qualified host name, when negotiating GSS-API
via SASL. SMACK 3 used the XMPP domain name instead. Spark should
have a configurable option that allows it to fall back to the old
mechanism (which is likely needed to connect to servers that
have already been configured to accept SSO from older versions of
Spark).
This commit also brings a reorganization of the code of the
'advanced connection settings' dialog - simply because it was pretty
unpractical as it was. Small modifications have been made to the
layout.
* SPARK-1740: Allow SASL GSS-API to be executed as it was in SMACK 3
* SPARK-1735: MUC occupants list should have width
This commit attempts to prevent that the occupants list in a MUC
screen has a near-zero width.
* SPARK-1772: Icons for muc role fix
* SPARK-1735: MUC occupants list should have vertical scrollbar
* SPARK-1740: Allow SASL GSS-API to be executed as it was in SMACK 3
SMACK 4 uses the fully qualified host name, when negotiating GSS-API
via SASL. SMACK 3 used the XMPP domain name instead. Spark should
have a configurable option that allows it to fall back to the old
mechanism (which is likely needed to connect to servers that
have already been configured to accept SSO from older versions of
Spark).
This commit also brings a reorganization of the code of the
'advanced connection settings' dialog - simply because it was pretty
unpractical as it was. Small modifications have been made to the
layout.
* SPARK-1735: MUC occupants list should have width
This commit attempts to prevent that the occupants list in a MUC
screen has a near-zero width.
* SPARK-1772: Icons for muc role fix
* SPARK-1735: MUC occupants list should have vertical scrollbar
* SPARK-1735: MUC occupants list should have width
This commit attempts to prevent that the occupants list in a MUC
screen has a near-zero width.
* SPARK-1772: Icons for muc role fix
A user cannot have both a resource based on host name, as well as
based on Spark version. A radiobutton is not suitable either, as
a user can also opt to use neither.
The SSO settings in the 'advanced connection settings' dialog has a
checkbox that displays 'advanced' options. Those options are not that
advanced, and the additional checkbox is confusing. It's better to
remove that checkbox (reduces confusion), and show those extra
settings immediately.
The file transfer manager should, if enabled, always get initialized.
The old code depended on a authentication to succeed. However, if that
occurred before the file transfer manager was invoked, initialization
would never occur.
1-on-1 message displaying is tricky. When in a regular chat, Spark
should listen to messages sent by any resource, associated to any
of the JIDs of the peer. In context of a MUC private message however,
the filter MUST be applied to the full jid (which will be:
roomname@servicename/nickname).
* Prevent exceptions from going unnoticed.
* SPARK-1750: Spark should reconnect by default.
This commit restored the automatic reconnection that's attempted
by Spark, when an XMPP connection unexpectedly fails. The commit
makes use of a construct offered by Smack (which was changed from
Smack 3 to 4).
