Commit Graph

114 Commits

Author SHA1 Message Date
d714fb6112 SPARK-2204: Code cleanup: Remove unused imports 2020-11-17 23:34:46 +03:00
7c6b4e827f SPARK-2204: Code cleanup: Remove unused fields and variables 2020-11-17 23:26:30 +03:00
0fb85eeb68 SPARK-2204: Code cleanup: Remove unused assignments and redundant catch clauses 2020-11-17 21:59:49 +03:00
517496e82c SPARK-2204: Code cleanup: Convert wrapper types to primitive when possible 2020-11-17 21:42:17 +03:00
7fa5bc29b9 SPARK-2204: Code cleanup: Remove unused imports 2020-11-17 00:59:13 +03:00
ff7175800c SPARK-2204: Code cleanup: Delete declaration of exceptions that are never thrown 2020-11-17 00:27:11 +03:00
bcd8f0c671 SPARK-2204: Code cleanup: Delete some empty unused methods 2020-11-17 00:05:07 +03:00
fb5a40c69a SPARK-2204: Code cleanup: Add private and final modifiers to methods if possible 2020-11-16 23:37:28 +03:00
75682fec07 SPARK-2204: Code cleanup: Remove redundant final modifier from private and static methods 2020-11-16 22:48:52 +03:00
ff255e458e SPARK-2204: Code cleanup: Solve some more issues with AIC/lambdas 2020-11-16 22:41:57 +03:00
6db11cfcf0 SPARK-2204: Code cleanup: Replace Collections.sort() with List.sort() 2020-11-15 22:06:13 +03:00
e474e1c67f SPARK-2204: Code cleanup: Use Java 8 features like lambda statements/expressions, and method references instead of anonymous inner classes implementing functional interfaces 2020-11-15 22:02:28 +03:00
4fbfb88db6 SPARK-2204: Code cleanup: Optimize try-catch statements 2020-11-15 20:56:49 +03:00
79a4e366f0 SPARK-2204: Code cleanup: Remove explicit type arguments when applicable
This will improve code readability.
2020-11-15 02:02:41 +03:00
e2f9214cda SPARK-2204: Code cleanup: Replace StringBuffer with StringBuilder when applicable 2020-11-15 01:57:55 +03:00
9cc1a85b43 SPARK-2204: Code cleanup: Replace String.indexOf() with contains() when applicable 2020-11-15 01:51:02 +03:00
3d80c6f9dc SPARK-2204: Code cleanup: Replace valueOf-methods with parse-methods to avoid redundant boxing 2020-11-15 01:47:52 +03:00
1bce50f546 SPARK-2204: Code cleanup: Replace while-loops with foreach-loops (enhanced for statements) 2020-11-15 01:40:45 +03:00
872de24ead SPARK-2204: Code cleanup: Replace for-loops with foreach-loops (enhanced for statements) 2020-11-15 01:32:09 +03:00
cb68ec37d7 SPARK-2204: Code cleanup: Replace if-sequences with switches and compare-methods calls when applicable 2020-11-15 01:19:12 +03:00
3505abc5d5 SPARK-2204: Code cleanup: Replace string literals with Standard Charset objects when applicable 2020-11-15 01:03:02 +03:00
bbf8d95caa SPARK-2204: Code cleanup: Make fields final if possible
This can have a good effect on performance, I think
2020-11-15 00:58:49 +03:00
5c9f41151e SPARK-2204: Code cleanup: Replace C-style array declarations with Java-style ones
Just for justice:)
2020-11-15 00:50:51 +03:00
1491bb0cde SPARK-2204: Code cleanup: Remove unnecessary modifiers from enum constructors and inner enums 2020-11-15 00:35:55 +03:00
fda951eabf SPARK-2204: Code cleanup: Remove unnecessary modifiers from interfaces methods and inner classes 2020-11-15 00:30:08 +03:00
1785f1843b SPARK-2204: Code cleanup: Solve control flow issues 2020-11-14 23:16:59 +03:00
dec3a3e4cf update Jira links to https + atlassian.net address 2020-11-14 07:30:07 -06:00
67638034d2 march master branch toward 2.9.5-SNAPSHOT 2020-11-14 07:05:11 -06:00
b1f908b696 Denote release 2.9.4 2020-11-14 06:45:21 -06:00
506e744fbd SPARK-1469: Code cleanup: Fix probable bugs: Remove unused assignment and redundant initializers 2020-11-13 23:00:43 +03:00
caaf9db56f SPARK-1469: Code cleanup: Fix probable bugs: Remove empty statements.
Also remove the code that does nothing.
2020-11-13 21:53:51 +03:00
0b4b174eef SPARK-1469: Code cleanup: remove redundant local variables. 2020-11-04 23:57:51 +03:00
96a097c649 SPARK-1469: Code cleanup: resolve control flow issues. 2020-11-04 23:14:18 +03:00
8685a8cb19 SPARK-1469: Code cleanup: make all error outputs use Log.error(). 2020-11-04 22:35:43 +03:00
93d76d662f SPARK-1469: Code cleanup: remove unused imports. 2020-11-04 22:17:50 +03:00
c7ce8bf3a1 SPARK-1469: Code cleanup: resolve some threading issues. 2020-11-04 01:11:21 +03:00
bc3e88fe8a SPARK-1469: Code cleanup: fix error handling. 2020-11-04 00:25:55 +03:00
fae96978d0 SPARK-1469: Code cleanup: remove redundant code constructs. 2020-11-04 00:01:02 +03:00
4359d04f6c SPARK-1469: Code cleanup: make nested classes static if applicable. 2020-11-03 22:11:19 +03:00
fb616c83bf SPARK-1469: Code cleanup: resolve performance issues related to string concatenations. 2020-11-03 00:56:14 +03:00
c6e4037aa1 SPARK-1469: Code cleanup: replace iterations with bulk operations. 2020-11-02 23:43:30 +03:00
ed533c0254 SPARK-1469: Code cleanup: delete unused imports. 2020-11-02 23:43:30 +03:00
297993d69a Delete usage of deprecated method.
Deprecated method:
org.jxmpp.util.XmppStringUtils.parseBareAddress
2020-10-27 22:22:25 +03:00
93c1c784fb Replace usage of deprecated method with alternative.
Deprecated method:
org.jivesoftware.smack.packet.Stanza.setFrom(java.lang.String)
Alternative method:
org.jivesoftware.smack.packet.Stanza.setFrom(org.jxmpp.jid.Jid)
2020-10-27 22:18:20 +03:00
8d614399bb Replace usage of deprecated method with alternative and delete method itself.
Deprecated method:
org.jivesoftware.spark.ChatManager.getChatRoom(java.lang.String)
Alternative method:
org.jivesoftware.spark.ChatManager.getChatRoom(org.jxmpp.jid.EntityBareJid)
2020-10-25 22:44:40 +03:00
e59dffbcd8 Replace usage of deprecated method with alternative and remove method itself.
Deprecated method:
org.jivesoftware.spark.UserManager.getUserNicknameFromJID(java.lang.CharSequence)
Alternative method:
org.jivesoftware.spark.UserManager.getUserNicknameFromJID(org.jxmpp.jid.BareJid)
2020-10-25 21:48:20 +03:00
52f4d7ab05 Replace usage of deprecated method with alternative and remove method itself.
Deprecated method:
```
org.jivesoftware.spark.SessionManager.getBareAddress
```
Alternative method:
```
org.jivesoftware.spark.SessionManager.getUserBareAddress
```
Alternative method renamed from getBareUserAddress() to getUserBareAddress().
2020-10-25 20:59:23 +03:00
48708bdb07 Replace usage of deprecated method with alternative.
Deprecated method:
```
public void org.jivesoftware.smack.packet.setTo(String)
```
Alternative method:
```
public void org.jivesoftware.smack.packet.setTo(Jid)
```
2020-10-25 20:36:22 +03:00
ff3099aead Replace usage of deprecated method with alternative and remove method itself.
Deprecated method: org.jivesoftware.spark.ui.ChatRoom.getRoomname().
Alternative method: org.jivesoftware.spark.ui.ChatRoom.getBareJid().
2020-10-25 20:09:41 +03:00
fb4799a6aa Fix renamed method call 2020-10-25 19:48:55 +03:00