Commit Graph

3441 Commits

Author SHA1 Message Date
b783924b88 Merge pull request #514 from akrherz/291
Denote Spark 2.9.1 Release
v2.9.1
2020-08-25 21:18:39 +03:00
4c7f54d2be Denote Spark 2.9.1 Release 2020-08-25 13:14:31 -05:00
3aff25b0c6 Merge pull request #513 from guusdk/SPARK-2151_Reversi-indexoutofbounds
SPARK-2151: Prevent IndexOutOfBoundsException in Reversi
2020-08-22 09:31:58 +03:00
efd6fb9d69 SPARK-2151: Prevent IndexOutOfBoundsException in Reversi
The old code attempts to iterate over 65 positions on a board that has 64. That's not going to work.

With this fix, I didn't get the exception that I had while previously playing this game. Unlike before, I can now successfully finish a game.
2020-08-21 21:54:27 +02:00
3d807a8adc Add date stamp ticket to 2.9.0 2020-08-20 11:08:37 +03:00
cdcf666533 Merge pull request #512 from guusdk/SPARK-2149_online-offline-notification-fix
SPARK-2149: Prevent notification from popping up on every presence change
2020-08-19 10:59:59 +03:00
2218cebdc3 Remove SM from the list 2020-08-19 10:54:07 +03:00
4c0c20a26e SPARK-2149: Prevent notification from popping up on every presence change
Notifications (when enabled) should online occur when a user that was previously online goes offline, or the other way around.
2020-08-19 09:49:13 +02:00
d1f8ec9dd3 Merge pull request #511 from guusdk/SPARK-2148_own-nickname-in-chat-history_2
SPARK-2148: Properly parse nickname from own JID in chat history log
2020-08-18 13:42:59 +03:00
70147ad0a2 SPARK-2148: Properly parse nickname from own JID in chat history log 2020-08-18 12:08:18 +02:00
89a124ac9b Merge pull request #510 from guusdk/SPARK-2148_own-nickname-in-chat-history
SPARK-2148: Fix displaying of own nickname in history
2020-08-18 12:37:02 +03:00
716747d27b SPARK-2148: Fix displaying of own nickname in history
When opening a chat window, the previously exchanged messages are displayed. In this history, your own nickname should be used, instead of your own JID.
2020-08-18 09:09:58 +02:00
5916368145 march master branch toward 2.9.1-SNAPSHOT 2020-08-17 08:13:37 -05:00
661da9e619 Merge pull request #509 from akrherz/290
Denote Spark 2.9.0 Release
v2.9.0
2020-08-17 15:20:24 +03:00
f1465b521d Denote Spark 2.9.0 Release 2020-08-17 07:13:31 -05:00
084b199ff6 Merge pull request #508 from guusdk/SPARK-2147_guard-against-dom4j-based-xxe-attacks
SPARK-2147 Guard against CVE-2020-10683 (dom4j reading external entities)
2020-08-17 11:44:27 +03:00
58560ea5ca Merge pull request #507 from guusdk/plugins_increase_versions
Increase version number of all plugins
2020-08-17 11:41:58 +03:00
6eb7905d45 Add OWASP dependency check to build
The check is currenty optional and placed
inside the profile 'owasp-check'.
One can directly invoke the plugin via
 'mvn org.owasp:dependency-check-maven:check'
An attempt at resolving SPARK-2113.
2020-08-16 19:14:51 +02:00
634865d0ac Guard against CVE-2020-10683 (dom4j reading external entities) 2020-08-16 19:11:38 +02:00
49149a5bf0 Increase version number of all plugins
Since the last release, major changes were applied to the project. To reflect this, I've increased the version number of all of the plugins.

Not all plugins might have had functional changes, but given that the project structure has changed a lot, some kind of increase (that will allow us to tell plugins before and after this release apart) could be helpful.
2020-08-16 18:56:14 +02:00
c3c57ac5d5 Merge pull request #506 from guusdk/SPARK-1895_More_verbose_errors
SPARK-1895: Show errors in chat transcript.
2020-08-15 16:16:01 +03:00
49c4f225ac Merge pull request #505 from guusdk/SPARK-2012_Use-bookmark-name-for-room
SPARK-2012: Use bookmark name when listing rooms
2020-08-15 16:14:55 +03:00
15da1abc6a SPARK-1895: Show errors in chat transcript.
When a message that contains an error is received, display an error message to the end-user, so that they know something went wrong.
2020-08-15 14:42:30 +02:00
ec3b75de36 SPARK-2012: Use bookmark name when listing rooms
The bookmark name should contain the name of the room. It's preferable to show the name of the room in the listing of bookmarked rooms, as opposed to the room ID.
2020-08-15 14:26:55 +02:00
e2cd24f42e Merge pull request #504 from wrooot/master
SPARK-2141 rename Unfiled
2020-08-12 22:43:39 +03:00
55f22983d5 SPARK-2141 added Unfiled translation 2020-08-12 22:42:36 +03:00
f78d989c76 SPARK-2141 rename Unfiled 2020-08-12 22:40:44 +03:00
8bf2433d26 SPARK-2141 rename Unfiled 2020-08-12 22:39:24 +03:00
6b89d28ef7 Bump Bouncy Castle to 1.66 2020-08-08 15:55:38 +03:00
4af4d40e9c Merge pull request #482 from Neustradamus/bouncycastle
SPARK-2146: Bouncy Castle 1.65 instead of 1.57
2020-08-08 15:46:50 +03:00
ccaac5ce40 Merge pull request #503 from guusdk/SPARK-2141
SPARK-2141: Contacts should always be shown, even if they're not in a group
2020-08-08 14:32:28 +03:00
ea1dafd3e3 Merge pull request #502 from guusdk/SPARK-2140_disable-stream-management
Disable Smacks support for Stream Management (for now)
2020-08-05 23:20:41 +03:00
56b2237227 SPARK-2141: Contacts should always be shown, even if they're not in a group
This commit restores functionality that already existed, but was ... disabled?

When a user is not in any group on the contact list, it is now displayed in a psuedo-group, called 'unfiled' (this is similar to the 'offline contacts' psuedo group).
2020-08-05 19:37:17 +02:00
53743efaa7 Disable Smacks support for Stream Management (for now)
We ideally enable Stream Management (see SPARK-2140), but for that, the reconnection logic in Spark probably needs work. I'm disabling it for now, until we have had a proper look.
2020-08-05 17:06:59 +02:00
59272b6568 Merge pull request #501 from guusdk/SPARK-2138_game-fixes
Spark-2138: Game fixes
2020-08-05 11:48:00 +03:00
e8f7de8a02 SPARK-2138: Reversi - Replace AsyncStanzaListener with IqRequestHandler
When processing an incoming IQ request (such as a game invitation), the version of Smack that we use does not allow us to use an AsyncStanzaListener anymore.

Before all registered stanza listeners are even invoked, Smack has determined that no IqRequestHandler has been registered to process the request, and will already have sent back an error.
2020-08-05 10:27:37 +02:00
9f9ad4586e SPARK-2138: Reversi - IQ error stanzas must have a child element
To conform with XMPP specifications (and Smacks enforcement of them) add an error condition to the IQ error response that's used to decline a game invitation.
2020-08-05 10:27:37 +02:00
8a1a8a7113 SPARK-2138: TicTacToe - IQ error stanzas must have a child element
To conform with XMPP specifications (and Smacks enforcement of them) add an error condition to the IQ error response that's used to decline a game invitation.
2020-08-05 10:27:50 +02:00
aca69b943c SPARK-2138: TicTacToe - Fix addressing of invite response processing
When processing a response, the 'to' and 'from' addresses have already been swapped.
2020-08-05 10:27:41 +02:00
671824f915 SPARK-2138: TicTacToe - Process unexpected errors on game invites are reject
When a game inivitation gets answered by a generic error (eg 'feature-not-implemented') rather than an explicit decline, process this as a decline. Prior to this commit, the code threw an exception as it didn't recognize the response as either an invite accept or decline.
2020-08-05 10:27:37 +02:00
d60ee89dfc SPARK-2138: TicTacToe - Replace AsyncStanzaListener with IqRequestHandler
When processing an incoming IQ request (such as a game invitation), the version of Smack that we use does not allow us to use an AsyncStanzaListener anymore.

Before all registered stanza listeners are even invoked, Smack has determined that no IqRequestHandler has been registered to process the request, and will already have sent back an error.
2020-08-05 09:55:00 +02:00
1a0e14769a Merge pull request #500 from guusdk/SPARK-1784_roar-popup-surpress
SPARK-1784: Do not surpress ROAR popup when chat container is inactiv…
2020-08-05 07:35:44 +03:00
72900a31de SPARK-1784: Do not surpress ROAR popup when chat container is inactive/has no focus
Prior to this change, popups where surpressed when the chat container was not explicitly closed.
2020-08-04 22:21:53 +02:00
bb626ef34f Merge pull request #499 from guusdk/roar
Various ROAR fixes
2020-08-04 23:03:52 +03:00
d8d59d742b SPARK-1898: ROAR do not show popup on own messages
If the author of an inbound message is the local user (potentially using a different client), then there's no need to show a popup.
2020-08-04 21:42:57 +02:00
27814b9df4 SPARK-2137: Log warning when 'appdir' is not set 2020-08-04 21:42:57 +02:00
5d85de9e8f SPARK-2136: Do not show unsupportable ROAR display types.
The system tray based popup/toaster is not supported on all platforms. It shouldn't be offered when it is not supported.
2020-08-04 21:42:57 +02:00
53c15faf8f SPARK-2134: Replace com.sun.awt.AWTUtilities usage
Do not use an implementation that is not available in all JREs.
2020-08-04 21:42:57 +02:00
8a8855a652 SPARK-2135: Immediately make use of updated ROAR config change
When changing the type of popup, immediately use the updated value.
2020-08-04 11:40:48 +02:00
ee4c3ec030 Merge pull request #498 from guusdk/SPARK-2110_missing-at-in-unescaped-jid
SPARK-2110: Fix nicknames & add missing '@' in result of unescaping JIDs
2020-08-04 12:06:10 +03:00