Commit Graph

90 Commits

Author SHA1 Message Date
fda951eabf SPARK-2204: Code cleanup: Remove unnecessary modifiers from interfaces methods and inner classes 2020-11-15 00:30:08 +03:00
1785f1843b SPARK-2204: Code cleanup: Solve control flow issues 2020-11-14 23:16:59 +03:00
dec3a3e4cf update Jira links to https + atlassian.net address 2020-11-14 07:30:07 -06:00
67638034d2 march master branch toward 2.9.5-SNAPSHOT 2020-11-14 07:05:11 -06:00
b1f908b696 Denote release 2.9.4 2020-11-14 06:45:21 -06:00
506e744fbd SPARK-1469: Code cleanup: Fix probable bugs: Remove unused assignment and redundant initializers 2020-11-13 23:00:43 +03:00
caaf9db56f SPARK-1469: Code cleanup: Fix probable bugs: Remove empty statements.
Also remove the code that does nothing.
2020-11-13 21:53:51 +03:00
0b4b174eef SPARK-1469: Code cleanup: remove redundant local variables. 2020-11-04 23:57:51 +03:00
96a097c649 SPARK-1469: Code cleanup: resolve control flow issues. 2020-11-04 23:14:18 +03:00
8685a8cb19 SPARK-1469: Code cleanup: make all error outputs use Log.error(). 2020-11-04 22:35:43 +03:00
93d76d662f SPARK-1469: Code cleanup: remove unused imports. 2020-11-04 22:17:50 +03:00
c7ce8bf3a1 SPARK-1469: Code cleanup: resolve some threading issues. 2020-11-04 01:11:21 +03:00
bc3e88fe8a SPARK-1469: Code cleanup: fix error handling. 2020-11-04 00:25:55 +03:00
fae96978d0 SPARK-1469: Code cleanup: remove redundant code constructs. 2020-11-04 00:01:02 +03:00
4359d04f6c SPARK-1469: Code cleanup: make nested classes static if applicable. 2020-11-03 22:11:19 +03:00
fb616c83bf SPARK-1469: Code cleanup: resolve performance issues related to string concatenations. 2020-11-03 00:56:14 +03:00
c6e4037aa1 SPARK-1469: Code cleanup: replace iterations with bulk operations. 2020-11-02 23:43:30 +03:00
ed533c0254 SPARK-1469: Code cleanup: delete unused imports. 2020-11-02 23:43:30 +03:00
297993d69a Delete usage of deprecated method.
Deprecated method:
org.jxmpp.util.XmppStringUtils.parseBareAddress
2020-10-27 22:22:25 +03:00
93c1c784fb Replace usage of deprecated method with alternative.
Deprecated method:
org.jivesoftware.smack.packet.Stanza.setFrom(java.lang.String)
Alternative method:
org.jivesoftware.smack.packet.Stanza.setFrom(org.jxmpp.jid.Jid)
2020-10-27 22:18:20 +03:00
8d614399bb Replace usage of deprecated method with alternative and delete method itself.
Deprecated method:
org.jivesoftware.spark.ChatManager.getChatRoom(java.lang.String)
Alternative method:
org.jivesoftware.spark.ChatManager.getChatRoom(org.jxmpp.jid.EntityBareJid)
2020-10-25 22:44:40 +03:00
e59dffbcd8 Replace usage of deprecated method with alternative and remove method itself.
Deprecated method:
org.jivesoftware.spark.UserManager.getUserNicknameFromJID(java.lang.CharSequence)
Alternative method:
org.jivesoftware.spark.UserManager.getUserNicknameFromJID(org.jxmpp.jid.BareJid)
2020-10-25 21:48:20 +03:00
52f4d7ab05 Replace usage of deprecated method with alternative and remove method itself.
Deprecated method:
```
org.jivesoftware.spark.SessionManager.getBareAddress
```
Alternative method:
```
org.jivesoftware.spark.SessionManager.getUserBareAddress
```
Alternative method renamed from getBareUserAddress() to getUserBareAddress().
2020-10-25 20:59:23 +03:00
48708bdb07 Replace usage of deprecated method with alternative.
Deprecated method:
```
public void org.jivesoftware.smack.packet.setTo(String)
```
Alternative method:
```
public void org.jivesoftware.smack.packet.setTo(Jid)
```
2020-10-25 20:36:22 +03:00
ff3099aead Replace usage of deprecated method with alternative and remove method itself.
Deprecated method: org.jivesoftware.spark.ui.ChatRoom.getRoomname().
Alternative method: org.jivesoftware.spark.ui.ChatRoom.getBareJid().
2020-10-25 20:09:41 +03:00
fb4799a6aa Fix renamed method call 2020-10-25 19:48:55 +03:00
bb937127ab march master branch toward 2.9.4-SNAPSHOT 2020-10-24 07:05:19 -05:00
24dce9789b Denote Spark 2.9.3 Release 2020-10-24 06:40:29 -05:00
1beadf33c3 Bump junit from 4.12 to 4.13.1 in /plugins/translator
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md)
- [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-10-13 09:10:49 +00:00
31abf18ca4 Refactor: rename getRoomJid() to getBareJid() in ChatRoom class and its derived classes for more clarity. 2020-10-07 18:14:09 +03:00
c4b4515641 Update readme.md 2020-09-03 12:09:33 +01:00
2d6102d779 electron version of meet plugin 2020-09-02 00:19:42 +01:00
928a0ad85e march master branch toward 2.9.3-SNAPSHOT 2020-08-30 13:22:12 -05:00
53d9ed6df3 Denote Spark 2.9.2 Release 2020-08-30 19:46:45 +02:00
407c8cdad3 Merge pull request #517 from guusdk/SPARK-2157_fastpath-jid-compare-fix
SPARK-2157: Prevent comparing JID with String for FastPath agent
2020-08-26 21:37:24 +03:00
4b4453e7a4 Merge pull request #516 from guusdk/SPARK-2156_invalid-jid-comparison
SPARK-2156: Prevent comparing JID with String for serverAddress
2020-08-26 21:37:06 +03:00
835f63ce93 SPARK-2157: Prevent comparing JID with String for FastPath agent 2020-08-26 20:01:41 +02:00
32ebc0d4ab SPARK-2156: Prevent comparing JID with String for serverAddress 2020-08-26 19:53:50 +02:00
2c48ffe1a8 march master branch toward 2.9.2-SNAPSHOT 2020-08-25 13:35:13 -05:00
4c7f54d2be Denote Spark 2.9.1 Release 2020-08-25 13:14:31 -05:00
efd6fb9d69 SPARK-2151: Prevent IndexOutOfBoundsException in Reversi
The old code attempts to iterate over 65 positions on a board that has 64. That's not going to work.

With this fix, I didn't get the exception that I had while previously playing this game. Unlike before, I can now successfully finish a game.
2020-08-21 21:54:27 +02:00
5916368145 march master branch toward 2.9.1-SNAPSHOT 2020-08-17 08:13:37 -05:00
f1465b521d Denote Spark 2.9.0 Release 2020-08-17 07:13:31 -05:00
49149a5bf0 Increase version number of all plugins
Since the last release, major changes were applied to the project. To reflect this, I've increased the version number of all of the plugins.

Not all plugins might have had functional changes, but given that the project structure has changed a lot, some kind of increase (that will allow us to tell plugins before and after this release apart) could be helpful.
2020-08-16 18:56:14 +02:00
e8f7de8a02 SPARK-2138: Reversi - Replace AsyncStanzaListener with IqRequestHandler
When processing an incoming IQ request (such as a game invitation), the version of Smack that we use does not allow us to use an AsyncStanzaListener anymore.

Before all registered stanza listeners are even invoked, Smack has determined that no IqRequestHandler has been registered to process the request, and will already have sent back an error.
2020-08-05 10:27:37 +02:00
9f9ad4586e SPARK-2138: Reversi - IQ error stanzas must have a child element
To conform with XMPP specifications (and Smacks enforcement of them) add an error condition to the IQ error response that's used to decline a game invitation.
2020-08-05 10:27:37 +02:00
8a1a8a7113 SPARK-2138: TicTacToe - IQ error stanzas must have a child element
To conform with XMPP specifications (and Smacks enforcement of them) add an error condition to the IQ error response that's used to decline a game invitation.
2020-08-05 10:27:50 +02:00
aca69b943c SPARK-2138: TicTacToe - Fix addressing of invite response processing
When processing a response, the 'to' and 'from' addresses have already been swapped.
2020-08-05 10:27:41 +02:00
671824f915 SPARK-2138: TicTacToe - Process unexpected errors on game invites are reject
When a game inivitation gets answered by a generic error (eg 'feature-not-implemented') rather than an explicit decline, process this as a decline. Prior to this commit, the code threw an exception as it didn't recognize the response as either an invite accept or decline.
2020-08-05 10:27:37 +02:00
d60ee89dfc SPARK-2138: TicTacToe - Replace AsyncStanzaListener with IqRequestHandler
When processing an incoming IQ request (such as a game invitation), the version of Smack that we use does not allow us to use an AsyncStanzaListener anymore.

Before all registered stanza listeners are even invoked, Smack has determined that no IqRequestHandler has been registered to process the request, and will already have sent back an error.
2020-08-05 09:55:00 +02:00