mirror of
https://github.com/igniterealtime/Spark.git
synced 2026-08-18 02:56:24 +00:00
9722494adb
Selecting a room in the conference room browser labelled the bookmark button with the opposite of the room's actual state: an unbookmarked room offered "Remove bookmark" with the delete icon, and a bookmarked one offered to bookmark it again. Clicking still did the right thing, so the button simply described the wrong action. addBookmarkUI() means "the room is bookmarked, so offer to remove it" — which is how bookmarkRoom() already calls it, passing the state that results from the toggle it has just performed. Only the selection listener negated the value. Drop the negation there, and pass false rather than true when nothing is selected, so the disabled button rests on "Bookmark room" instead of "Remove bookmark". Rename the parameter to isBookmarked and correct its javadoc, which described the inverted meaning.