Marcelo H. Terres 9722494adb SPARK-2410: Correct the bookmark button state in the room browser
Selecting a room in the conference room browser labelled the bookmark button
with the opposite of the room's actual state: an unbookmarked room offered
"Remove bookmark" with the delete icon, and a bookmarked one offered to
bookmark it again. Clicking still did the right thing, so the button simply
described the wrong action.

addBookmarkUI() means "the room is bookmarked, so offer to remove it" — which
is how bookmarkRoom() already calls it, passing the state that results from
the toggle it has just performed. Only the selection listener negated the
value. Drop the negation there, and pass false rather than true when nothing
is selected, so the disabled button rests on "Bookmark room" instead of
"Remove bookmark".

Rename the parameter to isBookmarked and correct its javadoc, which described
the inverted meaning.
2026-08-17 20:26:15 +03:00
2023-12-27 13:49:48 +01:00
2026-08-02 22:46:39 +03:00
2017-06-22 20:02:55 +02:00
2023-12-27 13:49:48 +01:00
2026-07-01 02:34:55 +03:00
2016-10-28 10:51:17 +02:00
2026-03-30 10:06:30 +03:00

Spark spark-64x64

Spark is an Open Source, cross-platform IM client optimized for businesses and organizations.

  • Group Chat
  • In-line Spell Checking
  • End-to-end (E2E) Message Encryption with OTR.
  • Tabbed Conversations
  • File Transfer
  • Screen Capture Sharing
  • Message translations.

Combined with the Openfire server, Spark is the easiest and best alternative to using unsecure public IM networks.

Spark - an Ignite Realtime community project.

Build Status

Resources

Install

Download the last release from the GitHub releases page or nightly build with the latest changes. For Windows, if you are not sure, if it's recommended to download the spark_*-with-jre-amd64.exe that has bundled JRE.

Screenshots

Spark_Login

Spark_menu

Spark_MUC

Bug Reporting

Only a few users have access for filling bugs in the tracker. New users should:

  1. Create a Discourse account
  2. Login to a Discourse account
  3. Click on the New Topic button
  4. Choose the Spark Dev category and provide a detailed description of the bug.

Please search for your issues in the bug tracker before reporting.

Run from sources

git clone https://github.com/igniterealtime/Spark.git
mvn verify
cd Spark/core
mvn exec:java

To run from an IDE execute the Main class org.jivesoftware.Spark and specify VM option -Ddebug.mode=true.

Ignite Realtime

Ignite Realtime is an Open Source community composed of end-users and developers around the world who are interested in applying innovative, open-standards-based Real Time Collaboration to their businesses and organizations. We're aimed at disrupting proprietary, non-open standards-based systems and invite you to participate in what's already one of the biggest and most active Open Source communities.

Languages
Java 99.9%