mirror/projectm
3
0
Fork 0
mirror of https://github.com/projectM-visualizer/projectm.git synced 2026-02-05 01:35:43 +00:00
Code Issues Projects Releases Wiki Activity

Fix a buffer overrun in PCM::GetFrameAudioData().

Browse Source 
This did not have any real impact, as the excess bytes were written into the next buffer, which was then immediately "fixed up" during the following copy call with the correct data, but could cause a crash and other nasty things if someone would reorder the class members or insert something in between.
This commit is contained in:
Kai Blaschke
2024-01-30 10:54:16 +01:00
parent 2c5a763dc1
commit fbb74ccd0b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libprojectM/Audio/PCM.cpp
View File

@ -73,10 +73,10 @@ auto PCM::GetFrameAudioData() const -> FrameAudioData
{
FrameAudioData data{};
std::copy(m_waveformL.begin(), m_waveformL.end(), data.waveformLeft.begin());
std::copy(m_waveformR.begin(), m_waveformR.end(), data.waveformRight.begin());
std::copy(m_spectrumL.begin(), m_spectrumL.end(), data.spectrumLeft.begin());
std::copy(m_spectrumR.begin(), m_spectrumR.end(), data.spectrumRight.begin());
std::copy(m_waveformL.begin(), m_waveformL.begin() + WaveformSamples, data.waveformLeft.begin());
std::copy(m_waveformR.begin(), m_waveformR.begin() + WaveformSamples, data.waveformRight.begin());
std::copy(m_spectrumL.begin(), m_spectrumL.begin() + SpectrumSamples, data.spectrumLeft.begin());
std::copy(m_spectrumR.begin(), m_spectrumR.begin() + SpectrumSamples, data.spectrumRight.begin());
data.bass = m_bass.CurrentRelative();
data.mid = m_middles.CurrentRelative();