mirror/snipe-it
3
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2026-08-18 03:06:23 +00:00
Code Issues Projects Releases Wiki Activity

SCIM: Fixed #18014 - pagination duplicates

Browse Source
This commit is contained in:
snipe
2026-07-22 12:59:13 +01:00
parent 168c5c0340
commit c5faea6576
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/Models/SnipeSCIMConfig.php
View File

@ -359,6 +359,22 @@ class SnipeSCIMConfig
'withRelations' => [],
'description' => 'User Account',
// #18014: the arietimmerman library's ResourceController::index
// only adds an ORDER BY when the SCIM provider supplies sortBy, and
// even then only puts the id tiebreaker on the cursor branch.
// That leaves the startIndex/count path (which every real SCIM
// client uses) with a bare LIMIT/OFFSET query. MySQL is free
// to return rows in any order without ORDER BY, and pages can
// overlap when the optimizer's plan is non-stable. Handing the
// library a base query with orderBy('users.id') baked in gives
// it a stable base ordering. Trade-off. If a provider supplies
// sortBy=X the library appends X as a SECONDARY sort, so X
// becomes a tiebreaker for ids rather than the primary sort.
// In practice virtually no SCIM client submits sortBy, so this
// is an acceptable degradation for the edge case in exchange
// for correct pagination for everyone IMHO - snipe.
'query' => SCIMUser::query()->orderBy('users.id'),
'map' => (new SnipeRootComplex)->withSubAttributes(
new class('schemas', ['urn:ietf:params:scim:schemas:core:2.0:User', self::ENTERPRISE, self::GROKABILITY]) extends Constant
{
@ -675,6 +691,10 @@ class SnipeSCIMConfig
'withRelations' => [],
'description' => 'Group',
// #18014: same stable-pagination base sort as getUserConfig.
// See that method for the full explanation and trade-off.
'query' => $this->getGroupClass()::query()->orderBy('permission_groups.id'),
'map' => complex()->withSubAttributes(
new class('schemas', ['urn:ietf:params:scim:schemas:core:2.0:Group']) extends Constant
{