mirror/tinyusb
3
0
Fork 0
mirror of https://github.com/hathach/tinyusb.git synced 2026-08-18 11:02:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: address second codex/copilot review round

Browse Source 
- claude.yml: drop the issues "assigned" trigger; its author_association
  gate keys on the issue author, not the assigner, so a maintainer
  assigning an outside contributor's issue would be wrongly skipped.
- claude-code-review.yml: issues: read -> write so use_sticky_comment can
  create/update its PR comment via the issues API.
- hil SKILL.md: make local/remote command blocks copy-pasteable (drop
  [-b BOARD_NAME] notation for concrete examples) and fix timeout
  (600000 ms is 10 min; use 1200000 ms for the stated 20 min).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
hathach
2026-06-02 00:24:05 +07:00
parent 1ea04f7fe6
commit 044cd06f87
3 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
.claude/skills/hil/SKILL.md
View File

@ -27,27 +27,37 @@ If `local.json` is missing on `htpc`, ask the user to supply one (only fall back
## Local execution
Set `CONFIG` from `hostname` first, then run:
Set `CONFIG` from `hostname` first (`test/hil/local.json` on htpc, `test/hil/tinyusb.json` on ci):
```bash
CONFIG=test/hil/local.json # on htpc
# CONFIG=test/hil/tinyusb.json # on ci
python3 test/hil/hil_test.py [-b BOARD_NAME] -B examples "$CONFIG" $EXTRA_ARGS
CONFIG=test/hil/local.json # on ci use: CONFIG=test/hil/tinyusb.json
# All boards in the config:
python3 test/hil/hil_test.py -B examples "$CONFIG"
# A single board (replace stm32f723disco):
python3 test/hil/hil_test.py -b stm32f723disco -B examples "$CONFIG"
```
Append pass-through flags (`-v`, `-r 1`, …) to either command as needed.
## Remote execution (htpc → ci.lan only)
`test/hil/hil_ci.sh` handles dir setup, scp of test scripts, rsync of firmware (`.elf`/`.bin`/`.hex`), and runs `hil_test.py` on `ci.lan` with `tinyusb.json`:
```bash
bash test/hil/hil_ci.sh [-b BOARD_NAME] [extra hil_test.py args...]
# All boards:
bash test/hil/hil_ci.sh
# A single board, with pass-through flags:
bash test/hil/hil_ci.sh -b raspberry_pi_pico2 -t host/cdc_msc_hid -r 1
```
Env overrides: `REMOTE`, `REMOTE_DIR`, `CONFIG`. Fails fast if the build dir/repo layout is missing.
## Timing
Runs take 2-5 min. Use a timeout ≥ 20 min (600000 ms). NEVER cancel early.
Runs take 2-5 min. Use a timeout ≥ 20 min (1200000 ms). NEVER cancel early.
## Reporting

2
.github/workflows/claude-code-review.yml vendored
View File

@ -21,7 +21,7 @@ jobs:
permissions:
contents: read
pull-requests: write
issues: read
issues: write # use_sticky_comment posts/updates a PR comment via the issues API
id-token: write
actions: read # Required for Claude to read CI results on PRs

5
.github/workflows/claude.yml vendored
View File

@ -6,7 +6,10 @@ on:
pull_request_review_comment:
types: [created]
issues:
types: [opened, assigned]
# only "opened" — an issue's author_association gates the summon below;
# "assigned" would gate on the issue author, not the assigner, so a
# maintainer assigning an outsider's issue would be wrongly skipped.
types: [opened]
pull_request_review:
types: [submitted]