mirror/tinyusb
3
0
Fork 0
mirror of https://github.com/hathach/tinyusb.git synced 2026-08-18 11:02:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

dynamic_switch: hoist while(1) out for OS_NONE

Browse Source 
Sonar flagged the loop body as executing only once on OS_NONE because
the OS_NONE branch returns inside the first iteration (main() drives
the task again). Make the while(1) conditional on RTOS so the OS_NONE
build is a straight-line function with no misleading loop.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
hathach
2026-05-30 00:52:22 +07:00
parent fc933e341d
commit a64eb336c4
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
examples/dual/dynamic_switch/src/main.c
View File

@ -281,7 +281,9 @@ void usb_mode_switch(void) {
void cdc_task(void *param) {
(void) param;
#if CFG_TUSB_OS == OPT_OS_FREERTOS
while (1) {
#endif
// Only touch device-CDC APIs while we're in device mode. After
// usb_mode_switch() sets current_role to INVALID and tusb_deinit() runs,
// calling tud_cdc_write_flush() here would hit a deinit'd device stack.
@ -295,13 +297,10 @@ void cdc_task(void *param) {
}
tud_cdc_write_flush();
}
#if CFG_TUSB_OS == OPT_OS_FREERTOS
vTaskDelay(pdMS_TO_TICKS(10));
#else
return; // main loop will call us again
#endif
}
#endif
}
//--------------------------------------------------------------------+
@ -369,7 +368,9 @@ void tuh_umount_cb(uint8_t daddr) {
void print_devinfo_task(void *param) {
(void) param;
#if CFG_TUSB_OS == OPT_OS_FREERTOS
while (1) {
#endif
if (current_role == TUSB_ROLE_HOST) {
for (uint8_t daddr = 1; daddr < TU_ARRAY_SIZE(need_devinfo); daddr++) {
if (need_devinfo[daddr]) {
@ -378,13 +379,10 @@ void print_devinfo_task(void *param) {
}
}
}
#if CFG_TUSB_OS == OPT_OS_FREERTOS
vTaskDelay(pdMS_TO_TICKS(10));
#else
return;
#endif
}
#endif
}
static void print_one_device(uint8_t daddr) {