mirror/tinyusb
3
0
Fork 0
mirror of https://github.com/hathach/tinyusb.git synced 2026-06-25 22:43:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

dwc2: cleanup setup_packet pointer cast (review feedback)

Browse Source 
Cast DOEPDMA0 through uintptr_t and use sizeof(tusb_control_request_t)
instead of the magic constant 8, matching project convention. Add a
reference to Programming Guide v4.20a 9.1.2.1 for the DOEPDMAn-8 rule.

Addresses Copilot review comment; no functional change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
hathach
2026-06-04 20:46:49 +07:00
parent b5e080732e
commit a900ea93db
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/portable/synopsys/dwc2/dcd_dwc2.c
View File

@ -1031,7 +1031,9 @@ static void handle_epout_dma(uint8_t rhport, uint8_t epnum, dwc2_doepint_t doepi
dcd_dcache_invalidate(_dcd_usbbuf.setup_buffer, sizeof(_dcd_usbbuf.setup_buffer));
tusb_control_request_t *setup_packet = (tusb_control_request_t *) (epout0->doepdma - 8);
// DOEPDMA0 has advanced past the last received SETUP packet; back up one packet to the latest valid one
// (Programming Guide v4.20a section 9.1.2.1: "DOEPDMAn-8 provides the pointer to the last valid SETUP data")
tusb_control_request_t *setup_packet = (tusb_control_request_t *) (uintptr_t) (epout0->doepdma - sizeof(tusb_control_request_t));
dcd_event_setup_received(rhport, (uint8_t*)setup_packet, true);
// Prepare EP0 for next setup if this setup has no data stage